X-Git-Url: http://git.marmaro.de/?a=blobdiff_plain;ds=sidebyside;f=sbr%2Fm_getfld2.c;h=de38435c01267e1a328721834f5d98d3c2a81321;hb=bebbba12196b01deca4e33631937fdfdf605b75c;hp=91164f3c1a47a7b596b4f137720bb6076b200d9d;hpb=f5df6f250dc5862488efb0198823c68f5b573ccc;p=mmh

diff --git a/sbr/m_getfld2.c b/sbr/m_getfld2.c
index 91164f3..de38435 100644
--- a/sbr/m_getfld2.c
+++ b/sbr/m_getfld2.c
@@ -23,11 +23,22 @@ enum threestate {
 */
 static enum threestate is_falted(FILE *);
 static size_t copyname(char *, char *);
+static int is_separator(char *);
 
 
 /*
-** For the states FLD2, BODY2 and FMTERR2 memory is allocated for f->value.
-** For the states LENERR2, ERR2 and FILEEOF2 no memory is allocated.
+** FLD2:	We read a (complete) header field
+** BODY2:	We read a body line
+** LENERR2:	Line is too long (>998, as defined by RFC 822)
+** FMTERR2:	Header field invalid
+** IOERR2:	Failure to read
+** FILEEOF2:	We're at the end of the file
+**
+** f->name is only filled in FLD2.
+**
+** In FLD2, f->value contains the field's (complete) value only;
+** in BODY2, LENERR2 and FMTERR2 f->value contains the whole line;
+** in IOERR2 and FILEEOF2 f->value is not set.
 */
 enum state
 m_getfld2(enum state s, struct field *f, FILE *msg)
@@ -38,22 +49,26 @@ m_getfld2(enum state s, struct field *f, FILE *msg)
 	enum threestate falted;
 
 	nchars = getline(&tmpline, &len, msg);
-	if (nchars == -1) {
+	if (nchars < 1) {
 		if (feof(msg)) {
 			return FILEEOF2;
 		} else {
-			return ERR2;
+			return IOERR2;
 		}
 	}
 
+	*f->name = '\0';
+	f->namelen = 0;
+
 	if (nchars >= NAMESZ) {
-		free(tmpline);
+		if (f->value) {
+			free(f->value);
+		}
+		f->value = tmpline;
+		f->valuelen = nchars;
 		return LENERR2;
 	}
 
-	*f->name = '\0';
-	f->namelen = 0;
-
 	switch (s) {
 	case FLD2:
 		if (*(tmpline + nchars - 1) != '\n') {
@@ -66,7 +81,7 @@ m_getfld2(enum state s, struct field *f, FILE *msg)
 			return FMTERR2;
 		}
 
-		if (nchars > 0 && (*tmpline == '\n' || *tmpline == '-')) {
+		if (is_separator(tmpline)) {
 			/* header/body separator found */
 			free(tmpline);
 			return m_getfld2(BODY2, f, msg);
@@ -95,11 +110,15 @@ m_getfld2(enum state s, struct field *f, FILE *msg)
 			nchars = getline(&tmpline, &len, msg);
 			if (nchars <= 0) {
 				free(tmpline);
-				return ERR2;
+				return IOERR2;
 			}
 
 			if (nchars >= NAMESZ) {
-				free(tmpline);
+				if (f->value) {
+					free(f->value);
+				}
+				f->value = tmpline;
+				f->valuelen = nchars;
 				return LENERR2;
 			}
 
@@ -125,7 +144,7 @@ m_getfld2(enum state s, struct field *f, FILE *msg)
 
 		if (falted == FAIL) {
 			free(tmpline);
-			return ERR2;
+			return IOERR2;
 		}
 
 		free(tmpline);
@@ -175,11 +194,17 @@ static size_t
 copyname(char *dst, char *src)
 {
 	size_t len;
-	char *sep = strchr(src, ':');
+	char *cp, *sep;
 
-	if (!sep) {
+	if (!(sep = strchr(src, ':'))) {
 		return 0;
 	}
+	/* whitespace is forbidden in name */
+	for (cp=src; cp<sep; cp++) {
+		if (isspace(*cp)) {
+			return 0;
+		}
+	}
 
 	len = sep - src;
 	if (len >= NAMESZ) {
@@ -191,3 +216,19 @@ copyname(char *dst, char *src)
 
 	return strlen(dst);
 }
+
+static int
+is_separator(char *line)
+{
+	/*
+	** In MH, lines that are consists of dashes only are
+	** separators as well ... not so in RFC 822.
+	*/
+	while (*line == '-') {
+		line++;
+	}
+	if (strcmp("\n", line)==0) {
+		return 1;
+	}
+	return 0;
+}