X-Git-Url: http://git.marmaro.de/?a=blobdiff_plain;f=sbr%2Fm_getfld.c;h=5bd6bbbaed434c578b577ce6a157f92d8e3b43ea;hb=b33ba7a7953d06a123ee59811903f0eb7f69e120;hp=df48026574bc7c012e6d99dae46c67fcf17b85c2;hpb=611d68d19204d7cbf5bd585391249cb5bafca846;p=mmh diff --git a/sbr/m_getfld.c b/sbr/m_getfld.c index df48026..5bd6bbb 100644 --- a/sbr/m_getfld.c +++ b/sbr/m_getfld.c @@ -10,51 +10,18 @@ #include /* -** This module has a long and checkered history. First, it didn't burst -** maildrops correctly because it considered two CTRL-A:s in a row to be -** an inter-message delimiter. It really is four CTRL-A:s followed by a -** newline. Unfortunately, MMDF will convert this delimiter *inside* a -** message to a CTRL-B followed by three CTRL-A:s and a newline. This -** caused the old version of m_getfld() to declare eom prematurely. The -** fix was a lot slower than +** This module has a long and checkered history. ** -** c == '\001' && peekc (iob) == '\001' +** [ Here had been some history of delimiter problems in MMDF maildrops ... ] ** -** but it worked, and to increase generality, MBOX style maildrops could -** be parsed as well. Unfortunately the speed issue finally caught up with -** us since this routine is at the very heart of MH. +** Unfortunately the speed issue finally caught up with us since this +** routine is at the very heart of MH. To speed things up considerably, the +** routine Eom() was made an auxilary function called by the macro eom(). +** Unless we are bursting a maildrop, the eom() macro returns FALSE saying +** we aren't at the end of the message. ** -** To speed things up considerably, the routine Eom() was made an auxilary -** function called by the macro eom(). Unless we are bursting a maildrop, -** the eom() macro returns FALSE saying we aren't at the end of the -** message. +** [ ... and here had been some more of it. ] ** -** After mhl was made a built-in in msh, m_getfld() worked just fine -** (using m_unknown() at startup). Until one day: a message which was -** the result of a bursting was shown. Then, since the burst boundaries -** aren't CTRL-A:s, m_getfld() would blinding plunge on past the boundary. -** Very sad. The solution: introduce m_eomsbr(). This hook gets called -** after the end of each line (since testing for eom involves an fseek()). -** This worked fine, until one day: a message with no body portion arrived. -** Then the -** -** while (eom(c = getc(iob), iob)) -** continue; -** -** loop caused m_getfld() to return FMTERR. So, that logic was changed to -** check for (*eom_action) and act accordingly. -** -** [ Note by meillo 2011-10: -** as msh was removed from mmh, m_eomsbr() became irrelevant. ] -** -** This worked fine, until one day: someone didn't use four CTRL:A's as -** their delimiters. So, the bullet got bit and we read mts.h and -** continue to struggle on. It's not that bad though, since the only time -** the code gets executed is when inc (or msh) calls it, and both of these -** have already called mts_init(). -** -** [ Note by meillo 2012-02: -** MMDF-style maildrops (4x ^A) and mts_init() were removed. ] ** ** ------------------------ ** (Written by Van Jacobson for the mh6 m_getfld, January, 1986): @@ -76,9 +43,8 @@ ** If you hack on this and slow it down, I, my children and my ** children's children will curse you. ** -** This routine gets used on three different types of files: normal, -** single msg files, "packed" unix or mmdf mailboxs (when used by inc) -** and packed, directoried bulletin board files (when used by msh). +** This routine gets used on two different types of files: normal, +** single msg files and "packed" unix mailboxs (when used by inc). ** The biggest impact of different file types is in "eom" testing. The ** code has been carefully organized to test for eom at appropriate ** times and at no other times (since the check is quite expensive). @@ -188,14 +154,6 @@ static int (*eom_action)(int) = NULL; # define DEFINED__FILBUF_TO_SOMETHING_SPECIFIC #endif -#ifdef SCO_5_STDIO -# define _ptr __ptr -# define _cnt __cnt -# define _base __base -# define _filbuf(fp) ((fp)->__cnt = 0, __filbuf(fp)) -# define DEFINED__FILBUF_TO_SOMETHING_SPECIFIC -#endif - #ifndef DEFINED__FILBUF_TO_SOMETHING_SPECIFIC extern int _filbuf(FILE*); #endif @@ -612,17 +570,21 @@ finish: return (state); } -static char fromline[BUFSIZ] = ""; void thisisanmbox(FILE *iob) { register int c; - register long pos; char text[10]; register char *cp; register char *delimstr; + c = getc(iob); + if (feof(iob)) { + return; + } + ungetc(c, iob); + /* ** Figure out what the message delimitter string is for this ** maildrop. (This used to be part of m_Eom but I didn't like @@ -635,7 +597,6 @@ thisisanmbox(FILE *iob) ** abort. */ - pos = ftell(iob); if (fread(text, sizeof(*text), 5, iob) != 5) { adios(NULL, "Read error"); } @@ -644,11 +605,9 @@ thisisanmbox(FILE *iob) } ismbox = TRUE; delimstr = "\nFrom "; - cp = fromline; - while ((c = getc(iob)) != '\n' && cp - fromline < BUFSIZ - 1) - *cp++ = c; - *cp = '\0'; - + while ((c = getc(iob)) != '\n' && c >= 0) { + continue; + } c = strlen(delimstr); fdelim = (unsigned char *) mh_xmalloc((size_t) (c + 3)); *fdelim++ = '\0'; @@ -684,7 +643,6 @@ m_Eom(int c, FILE *iob) register long pos = 0L; register int i; char text[10]; - register char *cp; pos = ftell(iob); if ((i = fread(text, sizeof *text, edelimlen, iob)) != edelimlen || @@ -702,43 +660,15 @@ m_Eom(int c, FILE *iob) } if (ismbox) { - cp = fromline; - while ((c = getc(iob)) != '\n' && c >= 0 && cp - fromline < BUFSIZ - 1) - *cp++ = c; - *cp = '\0'; + while ((c = getc(iob)) != '\n' && c >= 0) { + continue; + } } return 1; } -/* -** Return the Return-Path and Delivery-Date header information. -** -** Currently, I'm assuming that the "From " line takes the following form: -** "From" sender@host date (sendmail delivery) -*/ -int -get_returnpath(char *rp, int rplen, char *dd, int ddlen) -{ - char *cp; - - if (!(cp = strchr(fromline, ' '))) { - return 0; - } - /* Extract the Return-Path. */ - snprintf(rp, rplen, "%.*s\n", (int)(cp - fromline), fromline); - /* Advance over the whitespace. */ - while (*cp == ' ' || *cp == '\t') { - cp++; - } - /* Extract the Delivery-Date. */ - snprintf(dd, ddlen, "%.*s\n", 24, cp); - *fromline = '\0'; - return 1; -} - - static unsigned char * matchc(int patln, char *pat, int strln, char *str) {