From 587e977a97865f091131355f6dd250ece99f7adb Mon Sep 17 00:00:00 2001 From: David Levine Date: Sun, 23 Sep 2012 09:02:18 -0500 Subject: [PATCH] Removed double quotes around case arguments in test scripts. --- test/README | 4 ++++ test/post/test-messageid | 2 +- test/whatnow/test-attach-detach | 2 +- test/whatnow/test-cd | 2 +- test/whatnow/test-ls | 2 +- 5 files changed, 8 insertions(+), 4 deletions(-) diff --git a/test/README b/test/README index 7b1de5f..1932cd7 100644 --- a/test/README +++ b/test/README @@ -78,3 +78,7 @@ assignment in export statements. checkbashisms, available at http://sourceforge.net/projects/checkbaskisms/, might help some catch problems. Though it misses all of the troublesome constructs, except for assignment in an export statement, listed above. + +The "Portable Shell" section of the Autoconf info manual has a wealth +of tips for avoiding portability problems in shell scripts. It might +be available by entering: info autoconf portable. diff --git a/test/post/test-messageid b/test/post/test-messageid index 1dc4f0c..45f75d0 100755 --- a/test/post/test-messageid +++ b/test/post/test-messageid @@ -68,7 +68,7 @@ test_messageid () cur=`mhpath cur` # Verify that Message-ID is of the right form. We'll see how # portable these grep regular expressions are. - case "$msgid_style" in + case $msgid_style in localname) # e.g., Message-ID: <5348.1342884222@localhost.localdomain> id='^Message-ID: <[0-9]\{1,\}\.[0-9]\{1,\}@' diff --git a/test/whatnow/test-attach-detach b/test/whatnow/test-attach-detach index 7d538a2..9f308aa 100755 --- a/test/whatnow/test-attach-detach +++ b/test/whatnow/test-attach-detach @@ -41,7 +41,7 @@ set +e whatnowtest=`echo cd | TERM=dumb whatnow -prompt ''` set -e -case "${whatnowtest}" in +case ${whatnowtest} in cd) cat > "$expected" < "$expected" < "$expected" <