Use sysexits.h for better exit-codes

[mmh] / uip / scan.c

diff --git a/uip/scan.c b/uip/scan.c
index f53cf1d..0f755ca 100644 (file)
--- a/uip/scan.c
+++ b/uip/scan.c
@@ -14,6 +14,7 @@
 #include <errno.h>
 #include <unistd.h>
 #include <locale.h>
+#include <sysexits.h>
 
 static struct swit switches[] = {
 #define FORMSW  0
@@ -60,34 +61,34 @@ main(int argc, char **argv)
                        switch (smatch(++cp, switches)) {
                        case AMBIGSW:
                                ambigsw(cp, switches);
-                               exit(1);
+                               exit(EX_USAGE);
                        case UNKWNSW:
-                               adios(NULL, "-%s unknown", cp);
+                               adios(EX_USAGE, NULL, "-%s unknown", cp);
 
                        case HELPSW:
                                snprintf(buf, sizeof(buf), "%s [+folder] [msgs] [switches]", invo_name);
                                print_help(buf, switches, 1);
-                               exit(0);
+                               exit(argc == 2 ? EX_OK : EX_USAGE);
                        case VERSIONSW:
                                print_version(invo_name);
-                               exit(0);
+                               exit(argc == 2 ? EX_OK : EX_USAGE);
 
                        case FORMSW:
                                if (!(form = *argp++) || *form == '-')
-                                       adios(NULL, "missing argument to %s",
+                                       adios(EX_USAGE, NULL, "missing argument to %s",
                                                        argp[-2]);
                                continue;
 
                        case WIDTHSW:
                                if (!(cp = *argp++) || *cp == '-')
-                                       adios(NULL, "missing argument to %s",
+                                       adios(EX_USAGE, NULL, "missing argument to %s",
                                                        argp[-2]);
                                width = atoi(cp);
                                continue;
 
                        case FILESW:
                                if (!(cp = *argp++) || (cp[0] == '-' && cp[1]))
-                                       adios(NULL, "missing argument to %s",
+                                       adios(EX_USAGE, NULL, "missing argument to %s",
                                                        argp[-2]);
                                if (strcmp(file = cp, "-")!=0)
                                        file = getcpy(expanddir(cp));
@@ -96,7 +97,7 @@ main(int argc, char **argv)
                }
                if (*cp == '+' || *cp == '@') {
                        if (folder)
-                               adios(NULL, "only one folder at a time!");
+                               adios(EX_USAGE, NULL, "only one folder at a time!");
                        else
                                folder = getcpy(expandfol(cp));
                } else
@@ -113,16 +114,16 @@ main(int argc, char **argv)
        */
        if (file) {
                if (msgs.size)
-                       adios(NULL, "\"msgs\" not allowed with -file");
+                       adios(EX_USAGE, NULL, "\"msgs\" not allowed with -file");
                if (folder)
-                       adios(NULL, "\"+folder\" not allowed with -file");
+                       adios(EX_USAGE, NULL, "\"+folder\" not allowed with -file");
 
                /* check if "file" is really stdin */
                if (strcmp(file, "-") == 0) {
                        in = stdin;
                        file = "stdin";
                } else if (!(in = fopen(file, "r"))) {
-                       adios(file, "unable to open");
+                       adios(EX_IOERR, file, "unable to open");
                }
 
                thisisanmbox(in);
@@ -132,7 +133,7 @@ main(int argc, char **argv)
                                break;
                }
                fclose(in);
-               exit(0);
+               exit(EX_OK);
        }
 
        /*
@@ -146,20 +147,20 @@ main(int argc, char **argv)
        maildir = toabsdir(folder);
 
        if (chdir(maildir) == NOTOK)
-               adios(maildir, "unable to change directory to");
+               adios(EX_OSERR, maildir, "unable to change directory to");
 
        /* read folder and create message structure */
        if (!(mp = folder_read(folder)))
-               adios(NULL, "unable to read folder %s", folder);
+               adios(EX_IOERR, NULL, "unable to read folder %s", folder);
 
        /* check for empty folder */
        if (mp->nummsg == 0)
-               adios(NULL, "no messages in %s", folder);
+               adios(EX_DATAERR, NULL, "no messages in %s", folder);
 
        /* parse all the message ranges/sequences and set SELECTED */
        for (msgnum = 0; msgnum < msgs.size; msgnum++)
                if (!m_convert(mp, msgs.msgs[msgnum]))
-                       exit(1);
+                       exit(EX_USAGE);
        seq_setprev(mp);  /* set the Previous-Sequence */
 
        context_replace(curfolder, folder);  /* update current folder */
@@ -212,7 +213,7 @@ main(int argc, char **argv)
                                break;
 
                        default:
-                               adios(NULL, "scan() botch(%d)", state);
+                               adios(EX_SOFTWARE, NULL, "scan() botch(%d)", state);
 
                        case SCNEOF:
                                advise(NULL, "message %d: empty", msgnum);