X-Git-Url: http://git.marmaro.de/?p=mmh;a=blobdiff_plain;f=uip%2Fap.c;h=41eae6a2274964b28422475640f542f40af57a31;hp=9f8e6f0ff67dd7f078e9e2b552f3a2ebebb820b0;hb=6e9577f324bef90765a5edc02044eb111ec48072;hpb=5f2b39344cca1086c975d47b730929d8f1904214

diff --git a/uip/ap.c b/uip/ap.c
index 9f8e6f0..41eae6a 100644
--- a/uip/ap.c
+++ b/uip/ap.c
@@ -9,6 +9,9 @@
 #include <h/mh.h>
 #include <h/addrsbr.h>
 #include <h/fmt_scan.h>
+#include <h/utils.h>
+#include <locale.h>
+#include <sysexits.h>
 
 #define NADDRS 100
 
@@ -28,6 +31,8 @@ static struct swit switches[] = {
 	{ NULL, 0 }
 };
 
+char *version=VERSION;
+
 static struct format *fmt;
 
 static int dat[5];
@@ -47,9 +52,7 @@ main(int argc, char **argv)
 	char buf[BUFSIZ], **argp;
 	char **arguments, *addrs[NADDRS];
 
-#ifdef LOCALE
 	setlocale(LC_ALL, "");
-#endif
 	invo_name = mhbasename(argv[0]);
 
 	/* read user profile/context */
@@ -63,22 +66,22 @@ main(int argc, char **argv)
 			switch (smatch(++cp, switches)) {
 			case AMBIGSW:
 				ambigsw(cp, switches);
-				done(1);
+				exit(EX_USAGE);
 
 			case UNKWNSW:
-				adios(NULL, "-%s unknown", cp);
+				adios(EX_USAGE, NULL, "-%s unknown", cp);
 
 			case HELPSW:
 				snprintf(buf, sizeof(buf), "%s [switches] addrs ...", invo_name);
 				print_help(buf, switches, 1);
-				done(1);
+				exit(argc == 2 ? EX_OK : EX_USAGE);
 			case VERSIONSW:
 				print_version(invo_name);
-				done(1);
+				exit(argc == 2 ? EX_OK : EX_USAGE);
 
 			case FORMSW:
 				if (!(form = *argp++) || *form == '-')
-					adios(NULL, "missing argument to %s", argp[-2]);
+					adios(EX_USAGE, NULL, "missing argument to %s", argp[-2]);
 				continue;
 
 			case NORMSW:
@@ -90,14 +93,14 @@ main(int argc, char **argv)
 			}
 		}
 		if (addrp > NADDRS)
-			adios(NULL, "more than %d addresses", NADDRS);
+			adios(EX_USAGE, NULL, "more than %d addresses", NADDRS);
 		else
 			addrs[addrp++] = cp;
 	}
 	addrs[addrp] = NULL;
 
 	if (addrp == 0)
-		adios(NULL, "usage: %s [switches] addrs ...", invo_name);
+		adios(EX_USAGE, NULL, "usage: %s [switches] addrs ...", invo_name);
 
 	/* get new format string */
 	fmtstr = new_fs(form, FORMAT);
@@ -114,8 +117,7 @@ main(int argc, char **argv)
 	for (addrp = 0; addrs[addrp]; addrp++)
 		status += process(addrs[addrp], normalize);
 
-	done(status);
-	return 1;
+	return status;
 }
 
 struct pqpair {
@@ -129,24 +131,22 @@ static int
 process(char *arg, int norm)
 {
 	int status = 0;
-	register char *cp;
+	char *cp;
 	char buffer[BUFSIZ + 1], error[BUFSIZ];
-	register struct comp *cptr;
-	register struct pqpair *p, *q;
+	struct comp *cptr;
+	struct pqpair *p, *q;
 	struct pqpair pq;
-	register struct mailname *mp;
+	struct mailname *mp;
 
 	(q = &pq)->pq_next = NULL;
 	while ((cp = getname(arg))) {
-		if ((p = (struct pqpair *)
-				calloc((size_t) 1, sizeof(*p))) == NULL)
-			adios(NULL, "unable to allocate pqpair memory");
+		p = mh_xcalloc(1, sizeof(*p));
 		if ((mp = getm(cp, NULL, 0, norm, error)) == NULL) {
-			p->pq_text = getcpy(cp);
-			p->pq_error = getcpy(error);
+			p->pq_text = mh_xstrdup(cp);
+			p->pq_error = mh_xstrdup(error);
 			status++;
 		} else {
-			p->pq_text = getcpy(mp->m_text);
+			p->pq_text = mh_xstrdup(mp->m_text);
 			mnfree(mp);
 		}
 		q = (q->pq_next = p);
@@ -163,11 +163,11 @@ process(char *arg, int norm)
 		fmt_scan(fmt, buffer, BUFSIZ, dat);
 		fputs(buffer, stdout);
 
-		free(p->pq_text);
+		mh_free0(&(p->pq_text));
 		if (p->pq_error)
-			free(p->pq_error);
+			mh_free0(&(p->pq_error));
 		q = p->pq_next;
-		free((char *) p);
+		mh_free0(&p);
 	}
 
 	return status;