X-Git-Url: http://git.marmaro.de/?p=mmh;a=blobdiff_plain;f=uip%2Fmhstore.c;h=47b7c025075ffff66a6cdf4e98ae6471c71cdaf5;hp=b0c08da1b58bda8aafb36f7eaa668eb7cfc4f130;hb=6e9577f324bef90765a5edc02044eb111ec48072;hpb=5f2b39344cca1086c975d47b730929d8f1904214 diff --git a/uip/mhstore.c b/uip/mhstore.c index b0c08da..47b7c02 100644 --- a/uip/mhstore.c +++ b/uip/mhstore.c @@ -10,12 +10,15 @@ #include #include #include -#include #include #include #include #include #include +#include +#include +#include +#include static struct swit switches[] = { #define AUTOSW 0 @@ -37,6 +40,7 @@ static struct swit switches[] = { { NULL, 0 } }; +char *version=VERSION; /* mhparse.c */ extern char *tmp; /* directory to place temp files */ @@ -64,7 +68,7 @@ void flush_errors(void); /* mhfree.c */ void free_content(CT); extern CT *cts; /* The list of top-level contents to display */ -void freects_done(int) NORETURN; +void freects_done(); /* ** static prototypes @@ -130,11 +134,11 @@ main(int argc, char **argv) CT ct, *ctp; FILE *fp; - done=freects_done; + if (atexit(freects_done) != 0) { + adios(EX_OSERR, NULL, "atexit failed"); + } -#ifdef LOCALE setlocale(LC_ALL, ""); -#endif invo_name = mhbasename(argv[0]); /* read user profile/context */ @@ -151,17 +155,17 @@ main(int argc, char **argv) switch (smatch(++cp, switches)) { case AMBIGSW: ambigsw(cp, switches); - done(1); + exit(EX_USAGE); case UNKWNSW: - adios(NULL, "-%s unknown", cp); + adios(EX_USAGE, NULL, "-%s unknown", cp); case HELPSW: snprintf(buf, sizeof(buf), "%s [+folder] [msgs] [switches]", invo_name); print_help(buf, switches, 1); - done(1); + exit(argc == 2 ? EX_OK : EX_USAGE); case VERSIONSW: print_version(invo_name); - done(1); + exit(argc == 2 ? EX_OK : EX_USAGE); case AUTOSW: autosw++; @@ -172,27 +176,27 @@ main(int argc, char **argv) case PARTSW: if (!(cp = *argp++) || *cp == '-') - adios(NULL, "missing argument to %s", + adios(EX_USAGE, NULL, "missing argument to %s", argp[-2]); if (npart >= NPARTS) - adios(NULL, "too many parts (starting with %s), %d max", cp, NPARTS); + adios(EX_USAGE, NULL, "too many parts (starting with %s), %d max", cp, NPARTS); parts[npart++] = cp; continue; case TYPESW: if (!(cp = *argp++) || *cp == '-') - adios(NULL, "missing argument to %s", + adios(EX_USAGE, NULL, "missing argument to %s", argp[-2]); if (ntype >= NTYPES) - adios(NULL, "too many types (starting with %s), %d max", cp, NTYPES); + adios(EX_USAGE, NULL, "too many types (starting with %s), %d max", cp, NTYPES); types[ntype++] = cp; continue; case FILESW: if (!(cp = *argp++) || (*cp == '-' && cp[1])) - adios(NULL, "missing argument to %s", + adios(EX_USAGE, NULL, "missing argument to %s", argp[-2]); - file = *cp == '-' ? cp : getcpy(expanddir(cp)); + file = *cp == '-' ? cp : mh_xstrdup(expanddir(cp)); continue; case DEBUGSW: @@ -202,9 +206,9 @@ main(int argc, char **argv) } if (*cp == '+' || *cp == '@') { if (folder) - adios(NULL, "only one folder at a time!"); + adios(EX_USAGE, NULL, "only one folder at a time!"); else - folder = getcpy(expandfol(cp)); + folder = mh_xstrdup(expandfol(cp)); } else app_msgarg(&msgs, cp); } @@ -239,7 +243,7 @@ main(int argc, char **argv) /* ** Cache the current directory before we do any chdirs()'s. */ - cwd = getcpy(pwd()); + cwd = mh_xstrdup(pwd()); /* ** Check for storage directory. If specified, @@ -249,17 +253,16 @@ main(int argc, char **argv) if ((cp = context_find(nmhstorage)) && *cp) tmp = concat(cp, "/", invo_name, NULL); else - tmp = getcpy(toabsdir(invo_name)); + tmp = mh_xstrdup(toabsdir(invo_name)); if (file && msgs.size) - adios(NULL, "cannot specify msg and file at same time!"); + adios(EX_USAGE, NULL, "cannot specify msg and file at same time!"); /* ** check if message is coming from file */ if (file) { - if (!(cts = (CT *) calloc((size_t) 2, sizeof(*cts)))) - adios(NULL, "out of memory"); + cts = mh_xcalloc(2, sizeof(*cts)); ctp = cts; if ((ct = parse_mime(file))) @@ -275,25 +278,23 @@ main(int argc, char **argv) maildir = toabsdir(folder); if (chdir(maildir) == NOTOK) - adios(maildir, "unable to change directory to"); + adios(EX_OSERR, maildir, "unable to change directory to"); /* read folder and create message structure */ if (!(mp = folder_read(folder))) - adios(NULL, "unable to read folder %s", folder); + adios(EX_IOERR, NULL, "unable to read folder %s", folder); /* check for empty folder */ if (mp->nummsg == 0) - adios(NULL, "no messages in %s", folder); + adios(EX_DATAERR, NULL, "no messages in %s", folder); /* parse all the message ranges/sequences and set SELECTED */ for (msgnum = 0; msgnum < msgs.size; msgnum++) if (!m_convert(mp, msgs.msgs[msgnum])) - done(1); + exit(EX_USAGE); seq_setprev(mp); /* set the previous-sequence */ - if (!(cts = (CT *) calloc((size_t) (mp->numsel + 1), - sizeof(*cts)))) - adios(NULL, "out of memory"); + cts = mh_xcalloc(mp->numsel + 1, sizeof(*cts)); ctp = cts; for (msgnum = mp->lowsel; msgnum <= mp->hghsel; msgnum++) { @@ -308,7 +309,7 @@ main(int argc, char **argv) } if (!*cts) - done(1); + exit(EX_SOFTWARE); userrs = 1; SIGNAL(SIGQUIT, quitser); @@ -338,8 +339,7 @@ main(int argc, char **argv) for (ctp = cts; *ctp; ctp++) free_content(*ctp); - free((char *) cts); - cts = NULL; + mh_free0(&cts); /* If reading from a folder, do some updating */ if (mp) { @@ -349,8 +349,7 @@ main(int argc, char **argv) context_save(); /* save the context file */ } - done(0); - return 1; + return 0; } @@ -362,9 +361,10 @@ pipeser(int i) fflush(stdout); fprintf(stderr, "\n"); fflush(stderr); + exit(EX_TEMPFAIL); } - done(1); + exit(EX_IOERR); /* NOTREACHED */ } @@ -383,9 +383,9 @@ store_all_messages(CT *cts) ** store any contents. */ if ((cp = context_find(nmhstorage)) && *cp) - dir = getcpy(cp); + dir = mh_xstrdup(cp); else - dir = getcpy(cwd); + dir = mh_xstrdup(cwd); for (ctp = cts; *ctp; ctp++) { ct = *ctp; @@ -454,7 +454,7 @@ store_switch(CT ct) break; default: - adios(NULL, "unknown content type %d", ct->c_type); + adios(EX_DATAERR, NULL, "unknown content type %d", ct->c_type); break; } @@ -469,7 +469,7 @@ store_switch(CT ct) static int store_generic(CT ct) { - char **ap, **vp, *cp; + char **ap, **vp, *cp, *filename; CI ci = &ct->c_ctinfo; /* @@ -478,6 +478,18 @@ store_generic(CT ct) ** (only the "message" subtype "rfc822" will use store_generic). */ if (autosw && ct->c_type != CT_MESSAGE) { + /* First check for "filename" in Content-Disposition header */ + filename = extract_name_value("filename", ct->c_dispo); + if (filename && strcmp(filename, ct->c_dispo)!=0) { + /* We found "filename" */ + cp = mhbasename(filename); + if (*cp && *cp!='.' && *cp!='|' && *cp!='!' && + !strchr(cp, '%')) { + /* filename looks good: use it */ + ct->c_storeproc = mh_xstrdup(cp); + goto finished; + } + } /* ** Check the attribute/value pairs, for the attribute "name". ** If found, take the basename, do a few sanity checks and @@ -491,12 +503,13 @@ store_generic(CT ct) if (*cp && *cp!='.' && *cp!='|' && *cp!='!' && !strchr(cp, '%')) { /* filename looks good: use it */ - ct->c_storeproc = getcpy(cp); + ct->c_storeproc = mh_xstrdup(cp); } break; } } +finished: return store_content(ct, NULL); } @@ -567,8 +580,7 @@ store_partial(CT ct) return NOTOK; } - if ((base = (CT *) calloc((size_t) (i + 1), sizeof(*base))) == NULL) - adios(NULL, "out of memory"); + base = mh_xcalloc(i + 1, sizeof(*base)); ctq = base; for (ctp = cts; *ctp; ctp++) { @@ -614,7 +626,7 @@ missing_part: ct = *ctq++; if (store_content(ct, NULL) == NOTOK) { losing: - free((char *) base); + mh_free0(&base); return NOTOK; } @@ -624,7 +636,7 @@ losing: goto losing; } - free((char *) base); + mh_free0(&base); return OK; } @@ -647,12 +659,12 @@ store_external(CT ct) msg = add(concat("\n\t", *ap, ": ", *ep, NULL), msg); } if (!(fp = fopen(ct->c_file, "r"))) { - adios(ct->c_file, "unable to open"); + adios(EX_IOERR, ct->c_file, "unable to open"); } fseek(fp, ct->c_begin, SEEK_SET); while (!feof(fp) && ftell(fp) < ct->c_end) { if (!fgets(buf, sizeof buf, fp)) { - adios(ct->c_file, "unable to read"); + adios(EX_IOERR, ct->c_file, "unable to read"); } *strchr(buf, '\n') = '\0'; msg = add(concat("\n\t", buf, NULL), msg); @@ -730,11 +742,11 @@ store_content(CT ct, CT p) */ if (p) { appending = 1; - ct->c_storage = getcpy(p->c_storage); + ct->c_storage = mh_xstrdup(p->c_storage); /* record the folder name */ if (p->c_folder) { - ct->c_folder = getcpy(p->c_folder); + ct->c_folder = mh_xstrdup(p->c_folder); } goto got_filename; } @@ -774,11 +786,11 @@ store_content(CT ct, CT p) /* Store content in temporary file for now */ tmpfilenam = m_mktemp(invo_name, NULL, NULL); - ct->c_storage = getcpy(tmpfilenam); + ct->c_storage = mh_xstrdup(tmpfilenam); /* Get the folder name */ if (cp[1]) - folder = getcpy(expandfol(cp)); + folder = mh_xstrdup(expandfol(cp)); else folder = getcurfol(); @@ -786,10 +798,10 @@ store_content(CT ct, CT p) create_folder(toabsdir(folder), 0, exit); /* Record the folder name */ - ct->c_folder = getcpy(folder); + ct->c_folder = mh_xstrdup(folder); if (cp[1]) - free(folder); + mh_free0(&folder); goto got_filename; } @@ -808,7 +820,7 @@ store_content(CT ct, CT p) return show_content_aux(ct, 0, buffer + 1, dir); /* record the filename */ - ct->c_storage = getcpy(buffer); + ct->c_storage = mh_xstrdup(buffer); got_filename: /* flush the output stream */