X-Git-Url: http://git.marmaro.de/?p=mmh;a=blobdiff_plain;f=uip%2Fprompter.c;h=2adbd480864787cd9f07de89b89a982eb7e31f60;hp=e42e8df7c93bac10a71484b6c32c409a4cd19555;hb=b6823062c9806496b39ff12bf1fbe43ae127c96c;hpb=11f38fca55972832ee09a3b1ac8693050500545b

diff --git a/uip/prompter.c b/uip/prompter.c
index e42e8df..2adbd48 100644
--- a/uip/prompter.c
+++ b/uip/prompter.c
@@ -13,6 +13,10 @@
 #include <signal.h>
 #include <setjmp.h>
 #include <unistd.h>
+#include <ctype.h>
+#include <sys/stat.h>
+#include <locale.h>
+#include <sysexits.h>
 
 static struct swit switches[] = {
 #define PREPSW  0
@@ -72,19 +76,20 @@ main(int argc, char **argv)
 			switch (smatch(++cp, switches)) {
 			case AMBIGSW:
 				ambigsw(cp, switches);
-				exit(1);
+				exit(EX_USAGE);
 			case UNKWNSW:
-				adios(NULL, "-%s unknown", cp);
+				adios(EX_USAGE, NULL, "-%s unknown", cp);
 
 			case HELPSW:
 				snprintf(buffer, sizeof(buffer),
 						"%s [switches] file",
 						invo_name);
 				print_help(buffer, switches, 1);
-				exit(0);
+				exit(argc == 2 ? EX_OK : EX_USAGE);
+
 			case VERSIONSW:
 				print_version(invo_name);
-				exit(0);
+				exit(argc == 2 ? EX_OK : EX_USAGE);
 
 			case PREPSW:
 				prepend++;
@@ -112,14 +117,17 @@ main(int argc, char **argv)
 		}
 	}
 
-	if (!drft)
-		adios(NULL, "usage: %s [switches] file", invo_name);
-	if ((in = fopen(drft, "r")) == NULL)
-		adios(drft, "unable to open");
+	if (!drft) {
+		adios(EX_USAGE, NULL, "usage: %s [switches] file", invo_name);
+	}
+	if ((in = fopen(drft, "r")) == NULL) {
+		adios(EX_IOERR, drft, "unable to open");
+	}
 
 	tfile = m_mktemp2(NULL, invo_name, NULL, &out);
-	if (tfile == NULL)
-		adios("prompter", "unable to create temporary file");
+	if (tfile == NULL) {
+		adios(EX_CANTCREAT, "prompter", "unable to create temporary file");
+	}
 	chmod(tmpfil, 0600);
 	strncpy(tmpfil, tfile, sizeof(tmpfil));
 
@@ -133,7 +141,6 @@ main(int argc, char **argv)
 		switch (state = m_getfld(state, name, field, sizeof(field),
 				in)) {
 		case FLD:
-		case FLDEOF:
 		case FLDPLUS:
 			/*
 			** Check if the value of field contains
@@ -161,8 +168,7 @@ main(int argc, char **argv)
 				if (i == -1) {
 abort:
 					unlink(tmpfil);
-					/* sysexits.h EX_DATAERR */
-					exit(1);
+					exit(EX_DATAERR);
 				}
 				if (i || (field[0]!='\n' && field[0]!='\0')) {
 					fprintf(out, "%s:", name);
@@ -176,18 +182,9 @@ abort:
 				}
 			}
 
-			if (state == FLDEOF) {  /* moby hack */
-				/* draft has no body separator; only headers */
-				fprintf(out, "--------\n");
-				if (!qbody)
-					break;
-				printf("--------\n");
-				goto has_no_body;
-			}
 			continue;
 
 		case BODY:
-		case BODYEOF:
 		case FILEEOF:
 			fprintf(out, "--------\n");
 			if (qbody) {
@@ -233,7 +230,7 @@ has_no_body:
 			break;
 
 		default:
-			adios(NULL, "skeleton is poorly formatted");
+			adios(EX_DATAERR, NULL, "skeleton is poorly formatted");
 		}
 		break;
 	}
@@ -246,17 +243,19 @@ has_no_body:
 	fclose(out);
 	SIGNAL(SIGINT, SIG_IGN);
 
-	if ((fdi = open(tmpfil, O_RDONLY)) == NOTOK)
-		adios(tmpfil, "unable to re-open");
-	if ((fdo = creat(drft, m_gmprot())) == NOTOK)
-		adios(drft, "unable to write");
+	if ((fdi = open(tmpfil, O_RDONLY)) == NOTOK) {
+		adios(EX_IOERR, tmpfil, "unable to re-open");
+	}
+	if ((fdo = creat(drft, m_gmprot())) == NOTOK) {
+		adios(EX_IOERR, drft, "unable to write");
+	}
 	cpydata(fdi, fdo, tmpfil, drft);
 	close(fdi);
 	close(fdo);
 	unlink(tmpfil);
 
 	context_save();  /* save the context file */
-	return 0;
+	return EX_OK;
 }
 
 
@@ -264,7 +263,7 @@ int
 getln(char *buffer, int n)
 {
 	int c;
-	sig_atomic_t psigint;
+	sig_atomic_t psigint = sigint;
 	char *cp;
 
 	cp = buffer;
@@ -273,7 +272,6 @@ getln(char *buffer, int n)
 	switch (setjmp(sigenv)) {
 	case 0:
 		wtuser = 1;
-		psigint = sigint;
 		break;
 
 	default: