X-Git-Url: http://git.marmaro.de/?p=mmh;a=blobdiff_plain;f=uip%2Frcvstore.c;h=5fd9ae06df622099567784b322a84c88162c12da;hp=fbddda7faba9d0fc51df3d34e004c157df56513a;hb=a8984c0e490cda653615bc0e1d4743ad8fe7a2a7;hpb=fede6e42d81ce34fd5c1bbe7fb2757b281c2573a

diff --git a/uip/rcvstore.c b/uip/rcvstore.c
index fbddda7..5fd9ae0 100644
--- a/uip/rcvstore.c
+++ b/uip/rcvstore.c
@@ -7,10 +7,15 @@
 */
 
 #include <h/mh.h>
+#include <h/utils.h>
 #include <fcntl.h>
 #include <h/signals.h>
 #include <errno.h>
 #include <signal.h>
+#include <unistd.h>
+#include <sys/stat.h>
+#include <locale.h>
+#include <sysexits.h>
 
 static struct swit switches[] = {
 #define CRETSW  0
@@ -44,7 +49,7 @@ static struct swit switches[] = {
 */
 static char *tmpfilenam = NULL;
 
-static void unlink_done();
+void unlink_done();
 
 int
 main(int argc, char **argv)
@@ -58,7 +63,9 @@ main(int argc, char **argv)
 	struct msgs *mp;
 	struct stat st;
 
-	atexit(unlink_done);
+	if (atexit(unlink_done) != 0) {
+		adios(EX_OSERR, NULL, "atexit failed");
+	}
 
 	setlocale(LC_ALL, "");
 	invo_name = mhbasename(argv[0]);
@@ -75,27 +82,27 @@ main(int argc, char **argv)
 			switch (smatch(++cp, switches)) {
 			case AMBIGSW:
 				ambigsw(cp, switches);
-				exit(1);
+				exit(EX_USAGE);
 			case UNKWNSW:
-				adios(NULL, "-%s unknown", cp);
+				adios(EX_USAGE, NULL, "-%s unknown", cp);
 
 			case HELPSW:
 				snprintf(buf, sizeof(buf),
 						"%s [+folder] [switches]",
 						invo_name);
 				print_help(buf, switches, 1);
-				exit(1);
+				exit(argc == 2 ? EX_OK : EX_USAGE);
 			case VERSIONSW:
 				print_version(invo_name);
-				exit(1);
+				exit(argc == 2 ? EX_OK : EX_USAGE);
 
 			case SEQSW:
 				if (!(cp = *argp++) || *cp == '-')
-					adios(NULL, "missing argument name to %s", argp[-2]);
+					adios(EX_USAGE, NULL, "missing argument name to %s", argp[-2]);
 
 				/* check if too many sequences specified */
 				if (seqp >= NUMATTRS)
-					adios(NULL, "too many sequences (more than %d) specified", NUMATTRS);
+					adios(EX_USAGE, NULL, "too many sequences (more than %d) specified", NUMATTRS);
 				seqs[seqp++] = cp;
 				continue;
 
@@ -130,11 +137,11 @@ main(int argc, char **argv)
 		}
 		if (*cp == '+' || *cp == '@') {
 			if (folder)
-				adios(NULL, "only one folder at a time!");
+				adios(EX_USAGE, NULL, "only one folder at a time!");
 			else
-				folder = getcpy(expandfol(cp));
+				folder = mh_xstrdup(expandfol(cp));
 		} else {
-			adios(NULL, "usage: %s [+folder] [switches]",
+			adios(EX_USAGE, NULL, "usage: %s [+folder] [switches]",
 					invo_name);
 		}
 	}
@@ -149,15 +156,15 @@ main(int argc, char **argv)
 	/* check if folder exists */
 	if (stat(maildir, &st) == NOTOK) {
 		if (errno != ENOENT)
-			adios(maildir, "error on folder");
+			adios(EX_IOERR, maildir, "error on folder");
 		if (!create)
-			adios(NULL, "folder %s doesn't exist", maildir);
+			adios(EX_USAGE, NULL, "folder %s doesn't exist", maildir);
 		if (!makedir(maildir))
-			adios(NULL, "unable to create folder %s", maildir);
+			adios(EX_CANTCREAT, NULL, "unable to create folder %s", maildir);
 	}
 
 	if (chdir(maildir) == NOTOK)
-		adios(maildir, "unable to change directory to");
+		adios(EX_OSERR, maildir, "unable to change directory to");
 
 	/* ignore a few signals */
 	SIGNAL(SIGHUP, SIG_IGN);
@@ -168,7 +175,7 @@ main(int argc, char **argv)
 	/* create a temporary file */
 	tmpfilenam = m_mktemp(invo_name, &fd, NULL);
 	if (tmpfilenam == NULL) {
-		adios("rcvstore", "unable to create temporary file");
+		adios(EX_CANTCREAT, "rcvstore", "unable to create temporary file");
 	}
 	chmod(tmpfilenam, m_gmprot());
 
@@ -177,23 +184,23 @@ main(int argc, char **argv)
 
 	if (fstat(fd, &st) == NOTOK) {
 		unlink(tmpfilenam);
-		adios(tmpfilenam, "unable to fstat");
+		adios(EX_IOERR, tmpfilenam, "unable to fstat");
 	}
 	if (close(fd) == NOTOK)
-		adios(tmpfilenam, "error closing");
+		adios(EX_IOERR, tmpfilenam, "error closing");
 
 	/* don't add file if it is empty */
 	if (st.st_size == 0) {
 		unlink(tmpfilenam);
 		advise(NULL, "empty file");
-		exit(0);
+		exit(EX_OK);
 	}
 
 	/*
 	** read folder and create message structure
 	*/
 	if (!(mp = folder_read(folder)))
-		adios(NULL, "unable to read folder %s", folder);
+		adios(EX_IOERR, NULL, "unable to read folder %s", folder);
 
 	/*
 	** Link message into folder, and possibly add
@@ -201,7 +208,7 @@ main(int argc, char **argv)
 	*/
 	if ((msgnum = folder_addmsg(&mp, tmpfilenam, 0, unseensw, 0, 0, NULL))
 			== -1)
-		exit(1);
+		exit(EX_SOFTWARE);
 
 	/*
 	** Add the message to any extra sequences
@@ -209,7 +216,7 @@ main(int argc, char **argv)
 	*/
 	for (seqp = 0; seqs[seqp]; seqp++) {
 		if (!seq_addmsg(mp, seqs[seqp], msgnum, publicsw, zerosw))
-			exit(1);
+			exit(EX_SOFTWARE);
 	}
 
 	seq_setunseen(mp, 1);  /* add new msgs to unseen sequences */
@@ -220,13 +227,13 @@ main(int argc, char **argv)
 	unlink(tmpfilenam);  /* remove temporary file */
 	tmpfilenam = NULL;
 
-	return 0;
+	return EX_OK;
 }
 
 /*
 ** Clean up and exit
 */
-static void
+void
 unlink_done()
 {
 	if (tmpfilenam && *tmpfilenam) {