X-Git-Url: http://git.marmaro.de/?p=mmh;a=blobdiff_plain;f=uip%2Fspost.c;h=5b51ad4ce76190d356bc4c06473bfa75dffd2332;hp=cc163ac0b2fa672a72350163eb36a3f563bd5eec;hb=d3540eaa4251b3a282115a72ed5d1bb39ce74b3f;hpb=5b792c4424571f05bc2008e3109797d18d7d00d1

diff --git a/uip/spost.c b/uip/spost.c
index cc163ac..5b51ad4 100644
--- a/uip/spost.c
+++ b/uip/spost.c
@@ -26,48 +26,36 @@ struct swit switches[] = {
 	{ "filter filterfile", 0 },
 #define NFILTSW  1
 	{ "nofilter", 0 },
-#define FRMTSW  2
-	{ "format", 0 },
-#define NFRMTSW  3
-	{ "noformat", 0 },
-#define REMVSW  4
-	{ "remove", 0 },
-#define NREMVSW  5
-	{ "noremove", 0 },
-#define VERBSW  6
+#define VERBSW  2
 	{ "verbose", 0 },
-#define NVERBSW  7
+#define NVERBSW  3
 	{ "noverbose", 0 },
-#define WATCSW  8
+#define WATCSW  4
 	{ "watch", 0 },
-#define NWATCSW  9
+#define NWATCSW  5
 	{ "nowatch", 0 },
-#define BACKSW  10
+#define BACKSW  6
 	{ "backup", 0 },
-#define NBACKSW  11
+#define NBACKSW  7
 	{ "nobackup", 0 },
-#define ALIASW  12
+#define ALIASW  8
 	{ "alias aliasfile", 0 },
-#define NALIASW  13
+#define NALIASW  9
 	{ "noalias", 0 },
-#define WIDTHSW  14
-	{ "width columns", 0 },
-#define VERSIONSW  15
+#define VERSIONSW  10
 	{ "version", 0 },
-#define HELPSW  16
+#define HELPSW  11
 	{ "help", 0 },
-#define DEBUGSW  17
+#define DEBUGSW  12
 	{ "debug", -5 },
-#define DISTSW  18
+#define DISTSW  13
 	{ "dist", -4 },  /* interface from dist */
-#define PUSHSW  19  /* fork to sendmail then exit */
+#define PUSHSW  14  /* fork to sendmail then exit */
 	{ "push", -4 },
-#define NPUSHSW  20  /* exec sendmail */
+#define NPUSHSW  15  /* exec sendmail */
 	{ "nopush", -6 },
-#define LIBSW  21
+#define LIBSW  16
 	{ "library directory", -7 },
-#define ANNOSW  22
-	{ "idanno number", -6 },
 	{ NULL, 0 }
 };
 
@@ -109,7 +97,7 @@ static struct headers NHeaders[] = {
 	{ "Date", HNOP, MDAT },
 	{ "Subject", HSUB, 0 },
 	{ "To", HADR|HTRY, MVIS },
-	{ "cc", HADR|HTRY, MVIS },
+	{ "Cc", HADR|HTRY, MVIS },
 	{ "Bcc", HADR|HTRY|HBCC|HNIL, MINV },
 	{ "Message-Id", HBAD, 0 },
 	{ "Fcc", HFCC, 0 },
@@ -133,17 +121,13 @@ static struct headers RHeaders[] = {
 };
 
 
-static short fccind = 0;  /* index into fccfold[] */
-
 static int badmsg = 0;  /* message has bad semantics */
 static int verbose = 0;  /* spell it out */
 static int debug = 0;  /* debugging post */
-static int rmflg = 1;  /* remove temporary file when done */
 static int watch = 0;  /* watch the delivery process */
-static int backflg = 0;  /* rename input file as *.bak when done */
+static int backflg = 0;  /* prepend backup prefix to input file when done */
 static int pushflg = 0;  /* if going to fork to sendmail */
 static int aliasflg = 0;  /* if going to process aliases */
-static int outputlinelen=72;
 
 static unsigned msgflags = 0;  /* what we've seen */
 
@@ -153,11 +137,10 @@ static enum {
 
 static char tmpfil[] = "/tmp/pstXXXXXX";
 
-static char from[BUFSIZ];  /* my network address */
-static char signature[BUFSIZ];  /* my signature */
 static char *filter = NULL;  /* the filter for BCC'ing */
 static char *subject = NULL;  /* the subject field for BCC'ing */
 static char *fccfold[FCCS];  /* foldernames for FCC'ing */
+static short fccind = 0;  /* index into fccfold[] */
 
 static struct headers *hdrtab;  /* table for the message we're doing */
 static FILE *out;  /* output (temp) file */
@@ -170,23 +153,18 @@ extern char *sendmail;
 extern char *getfullname(void);
 extern char *getusername(void);
 
-extern boolean  draft_from_masquerading;  /* defined in mts.c */
-
 /*
 ** static prototypes
 */
 static void putfmt(char *, char *, FILE *);
-static void start_headers(void);
 static void finish_headers(FILE *);
 static int get_header(char *, struct headers *);
 static void putadr(char *, struct mailname *);
 static int putone(char *, int, int);
-static void insert_fcc(struct headers *, unsigned char *);
-static void file(char *);
+static void insert_fcc(char *, unsigned char *);
 static void fcc(char *, char *);
 
 #if 0
-static void die(char *, char *, ...);
 static void make_bcc_file(void);
 #endif
 
@@ -208,7 +186,6 @@ main(int argc, char **argv)
 	if (context_foil(NULL) == -1)
 		done(1);
 
-	mts_init(invo_name);
 	arguments = getarguments(invo_name, argc, argv, 0);
 	argp = arguments;
 
@@ -248,13 +225,6 @@ main(int argc, char **argv)
 				filter = NULL;
 				continue;
 
-			case REMVSW:
-				rmflg++;
-				continue;
-			case NREMVSW:
-				rmflg = 0;
-				continue;
-
 			case BACKSW:
 				backflg++;
 				continue;
@@ -289,21 +259,12 @@ main(int argc, char **argv)
 							argp[-2]);
 				aliasflg = 1;
 				if ((state = alias(cp)) != AK_OK)
-					adios(NULL, "aliasing error in file %s - %s", cp, akerror(state) );
+					adios(NULL, "aliasing error in file %s - %s", cp, akerror(state));
 				continue;
 			case NALIASW:
 				aliasflg = 0;
 				continue;
 
-			case WIDTHSW:
-				if (!(cp = *argp++) || *cp == '-')
-					adios(NULL, "missing argument to %s",
-							argp[-2]);
-				outputlinelen = atoi(cp);
-				if (outputlinelen <= 10)
-					outputlinelen = 72;
-				continue;
-
 			case LIBSW:
 				if (!(cp = *argp++) || *cp == '-')
 					adios(NULL, "missing argument to %s",
@@ -312,13 +273,6 @@ main(int argc, char **argv)
 				if (context_foil(cp) == -1)
 					done(1);
 				continue;
-
-			case ANNOSW:
-				/* -idanno switch ignored */
-				if (!(cp = *argp++) || *cp == '-')
-					adios(NULL, "missing argument to %s",
-							argp[-2]);
-				continue;
 			}
 		}
 		if (msg)
@@ -333,22 +287,20 @@ main(int argc, char **argv)
 	if ((in = fopen(msg, "r")) == NULL)
 		adios(msg, "unable to open");
 
-	start_headers();
 	if (debug) {
 		verbose++;
 		out = stdout;
-	}
-	else {
+	} else {
 #ifdef HAVE_MKSTEMP
-			if ((out = fdopen( mkstemp(tmpfil), "w" )) == NULL )
-				adios(tmpfil, "unable to create");
+		if ((out = fdopen(mkstemp(tmpfil), "w")) == NULL)
+			adios(tmpfil, "unable to create");
 #else
-			mktemp(tmpfil);
-			if ((out = fopen(tmpfil, "w")) == NULL)
-				adios(tmpfil, "unable to create");
-			chmod(tmpfil, 0600);
+		mktemp(tmpfil);
+		if ((out = fopen(tmpfil, "w")) == NULL)
+			adios(tmpfil, "unable to create");
+		chmod(tmpfil, 0600);
 #endif
-		}
+	}
 
 	hdrtab = (msgstate == normal) ? NHeaders : RHeaders;
 
@@ -395,8 +347,8 @@ main(int argc, char **argv)
 		}
 		break;
 	}
-
 	fclose(in);
+
 	if (backflg) {
 		strncpy(buf, m_backup(msg), sizeof(buf));
 		if (rename(msg, buf) == NOTOK)
@@ -404,21 +356,25 @@ main(int argc, char **argv)
 	}
 
 	if (debug) {
+		/* stop here */
 		done(0);
 	}
-	else
-		fclose(out);
 
-	file(tmpfil);
+	fclose(out);
+
+	/* process Fcc */
+	for (i=0; i<fccind; i++) {
+		fcc(tmpfil, fccfold[i]);
+	}
 
 	/*
 	** re-open the temp file, unlink it and exec sendmail, giving it
 	** the msg temp file as std in.
 	*/
-	if (freopen(tmpfil, "r", stdin) == NULL)
+	if (!freopen(tmpfil, "r", stdin)) {
 		adios(tmpfil, "can't reopen for sendmail");
-	if (rmflg)
-		unlink(tmpfil);
+	}
+	unlink(tmpfil);
 
 	argp = sargv;
 	*argp++ = "send-mail";
@@ -431,7 +387,7 @@ main(int argc, char **argv)
 
 	if (pushflg && !(watch || verbose)) {
 		/* fork to a child to run sendmail */
-		for (i=0; (pid = vfork()) == NOTOK && i < 5; i++)
+		for (i=0; (pid = fork()) == NOTOK && i < 5; i++)
 			sleep(5);
 		switch (pid) {
 		case NOTOK:
@@ -464,13 +420,16 @@ putfmt(char *name, char *str, FILE *out)
 		str++;
 
 	if ((i = get_header(name, hdrtab)) == NOTOK) {
+		/* some boring header: push it through */
 		fprintf(out, "%s: %s", name, str);
 		return;
 	}
 
+	/* one of the interesting headers */
 	hdr = &hdrtab[i];
-	if (hdr->flags & HIGN)
+	if (hdr->flags & HIGN) {
 		return;
+	}
 	if (hdr->flags & HBAD) {
 		advise(NULL, "illegal header line -- %s:", name);
 		badmsg++;
@@ -478,18 +437,26 @@ putfmt(char *name, char *str, FILE *out)
 	}
 	msgflags |= hdr->set;
 
-	if (hdr->flags & HSUB)
-		subject = subject ? add(str, add("\t", subject)) :
-				getcpy(str);
+	if (hdr->flags & HSUB) {
+		if (subject) {
+			/* append mupliple subject */
+			char *cp = concat(subject, "\t", str, NULL);
+			free(subject);
+			subject = cp;
+		} else {
+			subject = getcpy(str);
+		}
+	}
 
 	if (hdr->flags & HFCC) {
-		if ((cp = strrchr(str, '\n')))
-			*cp = 0;
+		if ((cp = strrchr(str, '\n'))) {
+			*cp = '\0';
+		}
 		for (cp = pp = str; (cp = strchr(pp, ',')); pp = cp) {
-			*cp++ = 0;
-			insert_fcc(hdr, pp);
+			*cp++ = '\0';
+			insert_fcc(hdr->value, pp);
 		}
-		insert_fcc(hdr, pp);
+		insert_fcc(hdr->value, pp);
 		return;
 	}
 
@@ -513,7 +480,7 @@ putfmt(char *name, char *str, FILE *out)
 			register struct mailname *mp = 0;
 
 			while ((cp = getname(str))) {
-				mp = getm( cp, NULL, 0, AD_HOST, NULL);
+				mp = getm(cp, NULL, 0, AD_HOST, NULL);
 				if (f == 0) {
 					f = mp;
 					mp->m_next = mp;
@@ -524,7 +491,7 @@ putfmt(char *name, char *str, FILE *out)
 				}
 			}
 			f = mp->m_next; mp->m_next = 0;
-			putadr( name, f );
+			putadr(name, f);
 		} else {
 			/*
 			** The author(s) of spost decided that alias
@@ -545,105 +512,63 @@ putfmt(char *name, char *str, FILE *out)
 			** alias processing as well.
 			** -- Dan Harkless <dan-nmh@dilvish.speed.net>
 			*/
-			fprintf(out, "%s: %s", name, str );
+			fprintf(out, "%s: %s", name, str);
 		}
 	}
 }
 
 
+/*
+** Add yet missing headers.
+*/
 static void
-start_headers(void)
+finish_headers(FILE *out)
 {
 	char *cp;
-	char sigbuf[BUFSIZ];
+	char from[BUFSIZ];  /* my network address */
+	char signature[BUFSIZ];  /* my signature */
+	char *resentstr = (msgstate == resent) ? "Resent-" : "";
 
-	strncpy(from, getusername(), sizeof(from));
+	if (!(msgflags & MDAT)) {
+		fprintf(out, "%sDate: %s\n", resentstr, dtimenow(0));
+	}
 
+	strncpy(from, getusername(), sizeof(from));
 	if ((cp = getfullname()) && *cp) {
-		strncpy(sigbuf, cp, sizeof(sigbuf));
-		snprintf(signature, sizeof(signature), "%s <%s>",
-				sigbuf,  from);
-	} else
-		snprintf(signature, sizeof(signature), "%s",  from);
-}
-
-
-static void
-finish_headers(FILE *out)
-{
-	switch (msgstate) {
-	case normal:
-		if (!(msgflags & MDAT))
-			fprintf(out, "Date: %s\n", dtimenow(0));
-
-		if (msgflags & MFRM) {
-			/*
-			** There was already a From: in the draft.
-			** Don't add one.
-			*/
-			if (!draft_from_masquerading)
-				/*
-				** mts.conf didn't contain
-				** "masquerade:[...]draft_from[...]"
-				** so we'll reveal the user's
-				** actual account@thismachine
-				** address in a Sender: header
-				** (and use it as the envelope
-				** From: later).
-				*/
-				fprintf(out, "Sender: %s\n", from);
-		} else
-			fprintf(out, "From: %s\n", signature);
-
-#ifdef notdef
-		if (!(msgflags & MVIS))
-			fprintf(out, "Bcc: Blind Distribution List: ;\n");
-#endif /* notdef */
-		break;
-
-	case resent:
-		if (!(msgflags & MRDT))
-			fprintf(out, "Resent-Date: %s\n", dtimenow(0));
-		if (msgflags & MRFM) {
-			/*
-			** There was already a Resent-From: in draft.
-			** Don't add one.
-			*/
-			if (!draft_from_masquerading)
-				/*
-				** mts.conf didn't contain
-				** "masquerade:[...]draft_from[...]"
-				** so we'll reveal the user's
-				** actual account@thismachine
-				** address in a Sender: header
-				** (and use it as the envelope
-				** From: later).
-				*/
-				fprintf(out, "Resent-Sender: %s\n",
-						from);
-		} else
-			/* Construct a Resent-From: header. */
-			fprintf(out, "Resent-From: %s\n", signature);
+		snprintf(signature, sizeof(signature), "%s <%s>", cp, from);
+	} else {
+		snprintf(signature, sizeof(signature), "%s", from);
+	}
+	if (!(msgflags & MFRM)) {
+		fprintf(out, "%sFrom: %s\n", resentstr, signature);
+	} else {
+		/* In case the From: header contains multiple addresses. */
+		fprintf(out, "%sSender: %s\n", resentstr, from);
+	}
 #ifdef notdef
-		if (!(msgflags & MVIS))
-			fprintf(out, "Resent-Bcc: Blind Re-Distribution List: ;\n");
+	if (!(msgflags & MVIS))
+		fprintf(out, "%sBcc: Blind Distribution List: ;\n", resentstr);
 #endif /* notdef */
-		break;
-	}
 
-	if (badmsg)
+	if (badmsg) {
 		adios(NULL, "re-format message and try again");
+	}
 }
 
 
+/*
+** Return index of the requested header in the table, or NOTOK if missing.
+*/
 static int
 get_header(char *header, struct headers *table)
 {
 	struct headers *h;
 
-	for (h = table; h->value; h++)
-		if (!mh_strcasecmp(header, h->value))
+	for (h=table; h->value; h++) {
+		if (mh_strcasecmp(header, h->value)==0) {
 			return (h - table);
+		}
+	}
 
 	return NOTOK;
 }
@@ -674,34 +599,37 @@ putadr(char *name, struct mailname *nl)
 		if (mp->m_nohost) {
 			/* a local name - see if it's an alias */
 			cp = akvalue(mp->m_mbox);
-			if (cp == mp->m_mbox)
+			if (cp == mp->m_mbox) {
 				/* wasn't an alias - use what the user typed */
 				linepos = putone(mp->m_text, linepos, namelen);
-			else
+			} else {
 				/* an alias - expand it */
 				while ((cp = getname(cp))) {
 					if (linepos > MAX_SM_FIELD) {
-							fprintf(out, "\n%s: ", name);
-							linepos = namelen;
+						fprintf(out, "\n%s: ", name);
+						linepos = namelen;
 					}
-					mp2 = getm( cp, NULL, 0, AD_HOST, NULL);
+					mp2 = getm(cp, NULL, 0, AD_HOST, NULL);
 					if (akvisible()) {
 						mp2->m_pers = getcpy(mp->m_mbox);
-						linepos = putone( adrformat(mp2), linepos, namelen );
+						linepos = putone(adrformat(mp2), linepos, namelen);
 					} else {
-						linepos = putone( mp2->m_text, linepos, namelen );
+						linepos = putone(mp2->m_text,
+								linepos,
+								namelen);
 					}
-					mnfree( mp2 );
+					mnfree(mp2);
 				}
+			}
 		} else {
 			/* not a local name - use what the user typed */
-			linepos = putone( mp->m_text, linepos, namelen );
+			linepos = putone(mp->m_text, linepos, namelen);
 		}
 		mp2 = mp;
 		mp = mp->m_next;
-		mnfree( mp2 );
+		mnfree(mp2);
 	}
-	putc( '\n', out );
+	putc('\n', out);
 }
 
 static int
@@ -710,41 +638,44 @@ putone(char *adr, int pos, int indent)
 	register int len;
 	static int linepos;
 
-	len = strlen( adr );
+	len = strlen(adr);
 	if (pos == indent)
 		linepos = pos;
-	else if (linepos+len > outputlinelen) {
-		fprintf( out, ",\n%*s", indent, "");
+	else if (linepos+len > OUTPUTLINELEN) {
+		fprintf(out, ",\n%*s", indent, "");
 		linepos = indent;
 		pos += indent + 2;
 	} else {
-		fputs( ", ", out );
+		fputs(", ", out);
 		linepos += 2;
 		pos += 2;
 	}
-	fputs( adr, out );
+	fputs(adr, out);
 
 	linepos += len;
 	return (pos+len);
 }
 
 
+/*
+** Insert the normalized value from pp into fccfold[].
+*/
 static void
-insert_fcc(struct headers *hdr, unsigned char *pp)
+insert_fcc(char *name, unsigned char *pp)
 {
-	unsigned char   *cp;
+	unsigned char *cp;
 
 	for (cp = pp; isspace(*cp); cp++)
 		continue;
 	for (pp += strlen(pp) - 1; pp > cp && isspace(*pp); pp--)
 		continue;
 	if (pp >= cp)
-		*++pp = 0;
-	if (*cp == 0)
+		*++pp = '\0';
+	if (!*cp)
 		return;
 
 	if (fccind >= FCCS)
-		adios(NULL, "too many %ss", hdr->value);
+		adios(NULL, "too many %ss", name);
 	fccfold[fccind++] = getcpy(cp);
 }
 
@@ -771,25 +702,19 @@ make_bcc_file(void)
 	chmod(bccfil, 0600);
 
 	fprintf(out, "Date: %s\n", dtimenow(0));
-	if (msgflags & MFRM) {
-	  /* There was already a From: in the draft.  Don't add one. */
-	  if (!draft_from_masquerading)
-		/*
-		** mts.conf didn't contain "masquerade:[...]draft_from[...]"
-		** so we'll reveal the user's actual account@thismachine
-		** address in a Sender: header (and use it as the envelope
-		** From: later).
-		*/
-		fprintf(out, "Sender: %s\n", from);
-	} else
+	if (!(msgflags & MFRM)) {
 		/* Construct a From: header. */
 		fprintf(out, "From: %s\n", signature);
+	} else {
+		/* Add a Sender: header in case the From: header is fake. */
+		fprintf(out, "Sender: %s\n", from);
+	}
 	if (subject)
 		fprintf(out, "Subject: %s", subject);
 	fprintf(out, "BCC:\n\n------- Blind-Carbon-Copy\n\n");
 	fflush(out);
 
-	if (filter == NULL) {
+	if (!filter) {
 		if ((fd = open(tmpfil, O_RDONLY)) == NOTOK)
 			adios(NULL, "unable to re-open");
 		cpydgst(fd, fileno(out), tmpfil, bccfil);
@@ -797,11 +722,11 @@ make_bcc_file(void)
 	} else {
 		vec[0] = mhbasename(mhlproc);
 
-		for (i = 0; (child_id = vfork()) == NOTOK && i < 5; i++)
+		for (i = 0; (child_id = fork()) == NOTOK && i < 5; i++)
 			sleep(5);
 		switch (child_id) {
 		case NOTOK:
-			adios("vfork", "unable to");
+			adios("fork", "unable to");
 
 		case OK:
 			dup2(fileno(out), 1);
@@ -830,20 +755,8 @@ make_bcc_file(void)
 }
 #endif /* if 0 */
 
-/* FCC INTERACTION */
-
-static void
-file(char *path)
-{
-	int i;
-
-	if (fccind == 0)
-		return;
-
-	for (i = 0; i < fccind; i++)
-		fcc(path, fccfold[i]);
-}
 
+/* FCC INTERACTION */
 
 static void
 fcc(char *file, char *folder)
@@ -857,53 +770,39 @@ fcc(char *file, char *folder)
 				folder);
 	fflush(stdout);
 
-	for (i = 0; (child_id = vfork()) == NOTOK && i < 5; i++)
+	for (i = 0; (child_id = fork()) == NOTOK && i < 5; i++)
 		sleep(5);
 	switch (child_id) {
 	case NOTOK:
-		if (!verbose)
-			fprintf(stderr, "  %sFcc %s: ", msgstate == resent ?
-					"Resent-" : "", folder);
-		fprintf(verbose ? stdout : stderr, "no forks, so not ok\n");
+		if (verbose) {
+			printf("Sorry man, but we had no more forks.\n");
+		} else {
+			fprintf(stderr, "Skipped %sFcc %s: unable to fork.\n",
+					msgstate == resent ? "Resent-" : "",
+					folder);
+		}
 		break;
 
 	case OK:
 		snprintf(fold, sizeof(fold), "%s%s",
-			*folder == '+' || *folder == '@' ? "" : "+", folder);
+				*folder == '+' || *folder == '@' ? "" : "+",
+				folder);
 		execlp(fileproc, mhbasename(fileproc),
-			"-link", "-file", file, fold, NULL);
+				"-link", "-file", file, fold, NULL);
 		_exit(-1);
 
 	default:
 		if ((status = pidwait(child_id, OK))) {
-			if (!verbose)
-				fprintf(stderr, "  %sFcc %s: ",
+			if (verbose) {
+				printf(" errored (0%o)\n", status);
+			} else {
+				fprintf(stderr, "  %sFcc %s: errored (0%o)\n",
 						msgstate == resent ?
-						"Resent-" : "", folder);
-			fprintf(verbose ? stdout : stderr, " errored (0%o)\n",
-					status);
+						"Resent-" : "", folder,
+						status);
+			}
 		}
 	}
 
 	fflush(stdout);
 }
-
-
-#if 0
-
-/*
-** TERMINATION
-*/
-
-static void
-die(char *what, char *fmt, ...)
-{
-	va_list ap;
-
-	va_start(ap, fmt);
-	advertise(what, NULL, fmt, ap);
-	va_end(ap);
-
-	done(1);
-}
-#endif