From: Joel Reicher <jjr@panacea.null.org>
Date: Mon, 24 Apr 2006 07:10:03 +0000 (+0000)
Subject: ssequal() does not check for a substring, but for a prefix, so added a
X-Git-Tag: nmh-1_3_RC1~32
X-Git-Url: http://git.marmaro.de/?p=mmh;a=commitdiff_plain;h=b577e47e7c6c40e0968af4472ed9dc52e9b64f58;hp=43d85eaa38c25385082958d831fc926c5e619eac

ssequal() does not check for a substring, but for a prefix, so added a
comment to this effect. If this is sufficient, the function body should
remain unchanged but the name and comments should be modified. If not,
then the function needs to be corrected.
---

diff --git a/sbr/ssequal.c b/sbr/ssequal.c
index 615404a..32edca9 100644
--- a/sbr/ssequal.c
+++ b/sbr/ssequal.c
@@ -12,6 +12,14 @@
 #include <h/mh.h>
 
 /*
+ * THIS CODE DOES NOT WORK AS ADVERTISED.
+ * It is actually checking if s1 is a PREFIX of s2.
+ * All calls to this function need to be checked to see
+ * if that needs to be changed. Prefix checking is cheaper, so
+ * should be kept if it's sufficient.
+ */
+
+/*
  * Check if s1 is a substring of s2.
  * If yes, then return 1, else return 0.
  */