From: Philipp Takacs Date: Sun, 14 May 2023 00:12:49 +0000 (+0200) Subject: fix threadid NULL deref X-Git-Url: http://git.marmaro.de/?p=mmh;a=commitdiff_plain;h=fc888ece449bca0362696d561cb0887b128e045d fix threadid NULL deref strchr returns NULL if the character is not found. --- diff --git a/sbr/getthreadid.c b/sbr/getthreadid.c index a1ad7a0..abac78d 100644 --- a/sbr/getthreadid.c +++ b/sbr/getthreadid.c @@ -54,8 +54,11 @@ threadid(char *msgid, char *referens) } start = strchr(threadfrom, '<'); + if (!start) { + return NULL; + } end = strchr(start, '>'); - if (!(*start) || !(*end)) { + if (!end) { return NULL; } *end = '\0';