10 years agoCosmetic change
markus schnalke [Sun, 20 Nov 2011 20:17:44 +0000 (21:17 +0100)]
Cosmetic change

10 years agoAdded comment
markus schnalke [Sun, 20 Nov 2011 20:14:29 +0000 (21:14 +0100)]
Added comment

10 years agoSimplification: Removed unnecessary variable
markus schnalke [Sun, 20 Nov 2011 20:13:07 +0000 (21:13 +0100)]
Simplification: Removed unnecessary variable

10 years agoThe existence of the profile entry Path is already enforced by context_read().
markus schnalke [Sun, 20 Nov 2011 11:38:17 +0000 (12:38 +0100)]
The existence of the profile entry Path is already enforced by context_read().
Hence, removed the obscure ``free(path("./", TFOLDER));'' calls.
Still I don't see the sense in these lines, but they won't get executed,
as the condition is checked before (and the program aborts then).
Probably that's obsolete stuff that remained through several reworks.

10 years agoCode reformating.
markus schnalke [Sat, 5 Nov 2011 18:07:47 +0000 (19:07 +0100)]
Code reformating.

10 years agoImproved pluspath() and used it instead of path() where appropriate.
markus schnalke [Sat, 5 Nov 2011 17:40:23 +0000 (18:40 +0100)]
Improved pluspath() and used it instead of path() where appropriate.

10 years agoRefactored sbr/getfolder.c
markus schnalke [Sat, 5 Nov 2011 17:13:17 +0000 (18:13 +0100)]
Refactored sbr/getfolder.c

10 years agoIntroduced FDEF and FCUR for speaking arguments to getfolder().
markus schnalke [Sat, 5 Nov 2011 16:56:07 +0000 (17:56 +0100)]
Introduced FDEF and FCUR for speaking arguments to getfolder().
Maybe it would be better to two separate functions, but I cannot
imagine good names for them ... :-(

10 years agoRearranged code in the file.
markus schnalke [Sat, 5 Nov 2011 16:51:30 +0000 (17:51 +0100)]
Rearranged code in the file.

10 years agoRefactoring in sbr/path.c.
markus schnalke [Sat, 5 Nov 2011 16:35:13 +0000 (17:35 +0100)]
Refactoring in sbr/path.c.
Especially: Replaced compath() with a more general packpath().

10 years agoRenamed r1bindex() to mhbasename(), to make its function becomes clear.
markus schnalke [Sat, 5 Nov 2011 13:04:02 +0000 (14:04 +0100)]
Renamed r1bindex() to mhbasename(), to make its function becomes clear.
All calls to r1bindex() had '/' as second argument. For everything else
one can use strrchr(3) instead of r1bindex().

10 years agoRenamed ssequal() to isprefix(), because that's what it checks.
markus schnalke [Sat, 5 Nov 2011 10:47:42 +0000 (11:47 +0100)]
Renamed ssequal() to isprefix(), because that's what it checks.

10 years agoRemoved defines for obsolete BSD bcopy functions; Use getc() directly.
markus schnalke [Sat, 5 Nov 2011 09:31:30 +0000 (10:31 +0100)]
Removed defines for obsolete BSD bcopy functions; Use getc() directly.

10 years agoWe don't need macros for only putting two strings next to each other.
markus schnalke [Sat, 5 Nov 2011 09:26:18 +0000 (10:26 +0100)]
We don't need macros for only putting two strings next to each other.

10 years agoRemoved references to bboards, as we don't support them anymore.
markus schnalke [Sat, 5 Nov 2011 08:43:56 +0000 (09:43 +0100)]
Removed references to bboards, as we don't support them anymore.

10 years agoBroke long lines.
markus schnalke [Tue, 1 Nov 2011 14:55:31 +0000 (15:55 +0100)]
Broke long lines.

10 years agoDon't call writev() anymore.
markus schnalke [Tue, 1 Nov 2011 08:29:08 +0000 (09:29 +0100)]
Don't call writev() anymore.
It might be a sexy syscall, but it's not portable and more complex than
the mainstream solution. For sexy source program, go elsewhere!

10 years agoRemoved outc(), which only called putchar(), while having the same signature.
markus schnalke [Tue, 1 Nov 2011 08:10:19 +0000 (09:10 +0100)]
Removed outc(), which only called putchar(), while having the same signature.
I substituted all outc() calls with calls to putchar().

10 years agoRemoved the space between function names and the opening parenthesis.
markus schnalke [Tue, 1 Nov 2011 08:05:30 +0000 (09:05 +0100)]
Removed the space between function names and the opening parenthesis.

10 years agoReformated comments and long lines
markus schnalke [Mon, 31 Oct 2011 14:06:33 +0000 (15:06 +0100)]
Reformated comments and long lines

10 years agoRemoved the draft message in favor for a consistent draft folder facility
markus schnalke [Sun, 30 Oct 2011 10:35:54 +0000 (11:35 +0100)]
Removed the draft message in favor for a consistent draft folder facility
- reworked sbr/m_draft.c (of course)
- removed the -draftfolder/-draftmessage/-nodraftfolder switches
- removed the -draft switch from anno and refile
- no more need to question on existing draft message - yay!
Everything is more consistent now. Cornercases went away. :-)

(Also fixed the switch numbering, as already done for other files earlier.)

10 years agoFixed broken swit numbering (there are more files to fix)
markus schnalke [Sun, 16 Oct 2011 17:50:26 +0000 (19:50 +0200)]
Fixed broken swit numbering (there are more files to fix)

10 years agoRemoved the whom program, which relayed on post(8) functionality.
markus schnalke [Sun, 16 Oct 2011 09:48:09 +0000 (11:48 +0200)]
Removed the whom program, which relayed on post(8) functionality.
We can later add one again, which only expands aliases but does not
require the MTA to support -bv.

10 years agoRemoved the split feature of send.
markus schnalke [Sun, 16 Oct 2011 08:47:04 +0000 (10:47 +0200)]
Removed the split feature of send.
It would split large messages into several partial ones, using MIME.
But if a message contains one large file attached, it won't solve the
problem. We better go without this feature and leave it to the user.

11 years agoRemoved unneeded sbr code.
markus schnalke [Fri, 7 Oct 2011 08:41:15 +0000 (10:41 +0200)]
Removed unneeded sbr code.
memmove() and strerror() removed again. ;-) Mmh takes C89, at least, for

11 years agoRearranged whitespace (and comments) in all the code!
markus schnalke [Fri, 7 Oct 2011 06:35:27 +0000 (08:35 +0200)]
Rearranged whitespace (and comments) in all the code!
The primary goal was to only indent with tabs and not mix them with spaces.
Also, no more tabs should appear past the first printable char on each line.
Now editing the sources will be much easier, no matter which editor one uses,
and rearranging won't break aligned code.
(Beware, the changeset is huge, but the `diff -w' changes are moderate.)

11 years agoRemoved mhn, as it was already replaced by mhlist/mhshow/mhstore.
markus schnalke [Wed, 5 Oct 2011 19:13:58 +0000 (21:13 +0200)]
Removed mhn, as it was already replaced by mhlist/mhshow/mhstore.

11 years agoRemoved msh, vmh and wmh.
markus schnalke [Wed, 5 Oct 2011 17:09:27 +0000 (19:09 +0200)]
Removed msh, vmh and wmh.
The latter ones were long time obsolete; now they went away.
Msh has hardly to do with everyday mmh usage, and we don't support bboards
This one changeset saves us about 7,000 lines of code. *yay*

11 years agoRemoved unused and not compiling program wmh.
markus schnalke [Wed, 5 Oct 2011 16:21:11 +0000 (18:21 +0200)]
Removed unused and not compiling program wmh.
It was added 1986, and is not even mentioned in nmh's history.
The website is (was?)

11 years agoRemoved obsolete MTS docs from README.developers
markus schnalke [Wed, 5 Oct 2011 16:14:41 +0000 (18:14 +0200)]
Removed obsolete MTS docs from README.developers

11 years agoClarification fix in man/, related to -debug.
markus schnalke [Wed, 5 Oct 2011 10:29:01 +0000 (12:29 +0200)]
Clarification fix in man/, related to -debug.

11 years agoReworked LINK, now named `altmsglink', similar to BACKUP_PREFIX.
markus schnalke [Wed, 5 Oct 2011 10:25:09 +0000 (12:25 +0200)]
Reworked LINK, now named `altmsglink', similar to BACKUP_PREFIX.

11 years agoMoved default file/folder modes from acconfig.h to config/config.c
markus schnalke [Wed, 5 Oct 2011 09:42:08 +0000 (11:42 +0200)]
Moved default file/folder modes from acconfig.h to config/config.c

11 years agoRemoved --with-{editor,pager} configure options.
markus schnalke [Wed, 5 Oct 2011 09:28:46 +0000 (11:28 +0200)]
Removed --with-{editor,pager} configure options.
We keep defaulting to vi and more, but search in PATH at run time.
Nowadays, both programs should be available via PATH everywhere.
Otherwise, the the path in the profile.

11 years agoDocumented -debug switch or mhparam(1)
markus schnalke [Wed, 5 Oct 2011 08:22:17 +0000 (10:22 +0200)]
Documented -debug switch or mhparam(1)

11 years agoMoved sendmail item to better place in man page mh-profile(5)
markus schnalke [Wed, 5 Oct 2011 07:55:16 +0000 (09:55 +0200)]
Moved sendmail item to better place in man page mh-profile(5)

11 years agoRemoved configure option --with-hash-prefix and moved backup-prefix to profile
markus schnalke [Wed, 5 Oct 2011 07:48:37 +0000 (09:48 +0200)]
Removed configure option --with-hash-prefix and moved backup-prefix to profile

11 years agoRenamed to the more modern name
markus schnalke [Tue, 4 Oct 2011 19:39:54 +0000 (21:39 +0200)]
Renamed to the more modern name

11 years agoNicer structure in summary printing of the configure script.
markus schnalke [Tue, 4 Oct 2011 19:07:22 +0000 (21:07 +0200)]
Nicer structure in summary printing of the configure script.

11 years agoMoved the sendmail path config line from mts.conf to the MH profile
markus schnalke [Tue, 4 Oct 2011 19:05:33 +0000 (21:05 +0200)]
Moved the sendmail path config line from mts.conf to the MH profile
This another step in getting rid of the mts stuff.

11 years agoRemoved TLS support. We don't need it anymore as we stopped talking SMTP
markus schnalke [Tue, 4 Oct 2011 17:04:28 +0000 (19:04 +0200)]
Removed TLS support. We don't need it anymore as we stopped talking SMTP
Libcrypto and thelike went away also, as they were needed only for TLS.

11 years agoRemoved SASL support. We don't need it anymore because we talk SMTP no more
markus schnalke [Tue, 4 Oct 2011 16:53:49 +0000 (18:53 +0200)]
Removed SASL support. We don't need it anymore because we talk SMTP no more

11 years agoRemoved the MTS and post; now we always use /usr/sbin/sendmail -t
markus schnalke [Tue, 4 Oct 2011 16:36:14 +0000 (18:36 +0200)]
Removed the MTS and post; now we always use /usr/sbin/sendmail -t
Mmh won't talk SMTP (nor POP).
Also moved OfficialName() from /mts/smtp/hosts.c to sbr/addrsbr.c.

11 years agoRemoved --with-smtpservers configure option and thelike
markus schnalke [Tue, 4 Oct 2011 14:14:46 +0000 (16:14 +0200)]
Removed --with-smtpservers configure option and thelike

11 years agoRemoved all POP support
markus schnalke [Tue, 4 Oct 2011 13:27:47 +0000 (15:27 +0200)]
Removed all POP support
To retrieve mail from POP servers use external tools, e.g. fetchmail.

11 years agoWe'll always use sendmail (spost) now
markus schnalke [Wed, 28 Sep 2011 14:17:08 +0000 (16:17 +0200)]
We'll always use sendmail (spost) now

11 years agoInstall to /usr/local/mmh
markus schnalke [Wed, 28 Sep 2011 10:00:00 +0000 (12:00 +0200)]
Install to /usr/local/mmh

11 years agoThis is the birth of mmh. :-)
markus schnalke [Fri, 9 Sep 2011 19:05:43 +0000 (21:05 +0200)]
This is the birth of mmh. :-)

11 years agoWhoops, user & port were in the wrong order so msgchk didn't work for POP mmh-start
Ken Hornstein [Wed, 13 Apr 2011 14:50:49 +0000 (10:50 -0400)]
Whoops, user & port were in the wrong order so msgchk didn't work for POP

11 years agoUpdated the developer README with a few notes about the git conversion.
Ken Hornstein [Tue, 22 Feb 2011 01:44:30 +0000 (20:44 -0500)]
Updated the developer README with a few notes about the git conversion.

Signed-off-by: Ken Hornstein <>

11 years agoSigned-off-by: Ken Hornstein <>
Paul Vixie [Mon, 7 Feb 2011 19:13:54 +0000 (14:13 -0500)]
Signed-off-by: Ken Hornstein <>

More documentation about the hooks support.

11 years agoClean up code in inc.c
Peter Maydell [Tue, 21 Dec 2010 16:50:24 +0000 (16:50 +0000)]
Clean up code in inc.c

Clean up the confusing use of a variable 'i' in inc.c.
The case where it was being used as 'an error occurred
which means we should not truncate the mailspool' is now
called 'incerr' and merged with the equivalent 'p' variable
used in the POP-specific code. Cases where it was being
used as a random temporary are still called 'i' but now
declared with a much more restricted scope.
This fixes a compilation warning for some compilers.

Signed-off-by: Peter Maydell <>

11 years agoSuppress tsort diagnostic waffle
Peter Maydell [Mon, 20 Dec 2010 21:13:32 +0000 (21:13 +0000)]
Suppress tsort diagnostic waffle

tsort produces waffle to standard error if it detects loops in its input.
For our purposes in ordering object files this is harmless, so just send
it all to /dev/null.

Signed-off-by: Peter Maydell <>

11 years agoFix unused-function warnings in lex output
Peter Maydell [Mon, 20 Dec 2010 21:13:32 +0000 (21:13 +0000)]
Fix unused-function warnings in lex output

Fix the unused-function warnings in the output of lex. In particular, we
silence a warning about yyunput being static but unused by exposing it as
a global function. This costs us a few hundred bytes in the binary but
the other available solutions are flex-specific or more complicated.
YY_NO_UNPUT used to silence this but no longer works in recent flex.
On the other hand YY_NO_INPUT does work to silence warnings about input().

Signed-off-by: Peter Maydell <>

11 years agoFix used-uninitialised warning in fmt_rfc2047.c
Peter Maydell [Mon, 20 Dec 2010 21:13:32 +0000 (21:13 +0000)]
Fix used-uninitialised warning in fmt_rfc2047.c

Fix a used-uninitialised warning in fmt_rfc2047.c.
I don't think it can actually be used uninitialised, but the
code is too complicated for the compiler to realise this.

Signed-off-by: Peter Maydell <>

11 years agoFix used-uninitialised warning in new.c
Peter Maydell [Mon, 20 Dec 2010 21:13:32 +0000 (21:13 +0000)]
Fix used-uninitialised warning in new.c

Fix a used-uninitialised warning in new.c by having the check_folders()
routine return first=last=NULL for empty folder lists. This is a more
sensible API anyway. (It would not actually have been possible for
the code to try to use last while it was uninitialised, as it happens.)

Signed-off-by: Peter Maydell <>

11 years agoFix crash if fnext/fprev are given an empty folder list
Peter Maydell [Mon, 20 Dec 2010 21:13:32 +0000 (21:13 +0000)]
Fix crash if fnext/fprev are given an empty folder list

Add a check for a NULL pointer, which stops fnext/fprev
from segfaulting if given an empty folder list (for example
via 'fnext -folders emptyfile').

Signed-off-by: Peter Maydell <>

11 years agoFix warning in sbr/folder_addmsg.c by code cleanup
Peter Maydell [Mon, 20 Dec 2010 19:54:43 +0000 (19:54 +0000)]
Fix warning in sbr/folder_addmsg.c by code cleanup

Clean up some rather oddly written code in folder_addmsg()
so it is easier to understand for both humans and for the
compiler (and the compiler thus stops complaining about an
uninitialised variable).

Signed-off-by: Peter Maydell <>

11 years agoFix so this compiles without SASL support.
Ken Hornstein [Thu, 16 Dec 2010 18:20:31 +0000 (13:20 -0500)]
Fix so this compiles without SASL support.

Damn you, Oliver Kiddle, for finding all of the bugs I add to nmh!

11 years agoAll of the arguments to AC_ARG_ENABLE need to be quoted, otherwise the
Ken Hornstein [Thu, 16 Dec 2010 18:11:17 +0000 (13:11 -0500)]
All of the arguments to AC_ARG_ENABLE need to be quoted, otherwise the
last action doesn't make it into the configure script.

11 years agoMake sure we ignore
Ken Hornstein [Thu, 16 Dec 2010 18:02:32 +0000 (13:02 -0500)]
Make sure we ignore

11 years agofix typo and clarify two sentences in mhpath man page
Markus Schnalke [Thu, 16 Dec 2010 00:36:43 +0000 (01:36 +0100)]
fix typo and clarify two sentences in mhpath man page

11 years agoimprove mhparam man page
Markus Schnalke [Thu, 16 Dec 2010 00:25:11 +0000 (01:25 +0100)]
improve mhparam man page

11 years agofix badly formatted code found by Markus Schnalke
Oliver Kiddle [Thu, 16 Dec 2010 00:23:16 +0000 (01:23 +0100)]
fix badly formatted code found by Markus Schnalke

11 years agopropagate and check return status of close() in slocal
Scott Snyder [Wed, 15 Dec 2010 21:17:52 +0000 (22:17 +0100)]
propagate and check return status of close() in slocal

11 years agodocument msg parameter to folder
Markus Schnalke [Wed, 15 Dec 2010 21:02:30 +0000 (22:02 +0100)]
document msg parameter to folder

11 years agoswitches need to be renumbered following removal of some switches so,
Oliver Kiddle [Tue, 14 Dec 2010 17:04:01 +0000 (18:04 +0100)]
switches need to be renumbered following removal of some switches so,
e.g. inc -version was not working

11 years agoMassive garbage collection. Remove functionality for APOP, RPOP,
Ken Hornstein [Thu, 9 Dec 2010 20:29:29 +0000 (15:29 -0500)]
Massive garbage collection.  Remove functionality for APOP, RPOP,
all NNTP support (including bboards) and MPOP.

11 years ago * uip/whatnowsbr.c: enforce requirement of at least one file
David Levine [Wed, 8 Dec 2010 20:36:36 +0000 (14:36 -0600)]
* uip/whatnowsbr.c: enforce requirement of at least one file
  argument to attach command.

11 years agoman/ added name= portion to Content-Type
David Levine [Wed, 8 Dec 2010 16:47:03 +0000 (10:47 -0600)]
man/ added name= portion to Content-Type
headers to reflect 2006-10-24 change to uip/sendsbr.c.
That change allowed mhstore to use the (file)name when
extracting attachments.

11 years agoRemove RCS keywords, since they no longer work after git migration.
Ken Hornstein [Fri, 3 Dec 2010 20:23:11 +0000 (15:23 -0500)]
Remove RCS keywords, since they no longer work after git migration.

11 years agoWhoops, forgot to bracket the calls for TLS shutdown with a #ifdef TLS_SUPPORT
Ken Hornstein [Fri, 3 Dec 2010 02:04:30 +0000 (21:04 -0500)]
Whoops, forgot to bracket the calls for TLS shutdown with a #ifdef TLS_SUPPORT

11 years agoUpdate for git conversions (and cleanup of to use autoreconf)
Ken Hornstein [Fri, 3 Dec 2010 01:37:54 +0000 (20:37 -0500)]
Update for git conversions (and cleanup of to use autoreconf)

11 years agoChange to emit a warning when an argument is given to
Ken Hornstein [Thu, 2 Dec 2010 23:03:22 +0000 (18:03 -0500)]
Change to emit a warning when an argument is given to

11 years agoFix the test for sasl.h to look in the correct place. cvs-repository-moved-to-git
Ken Hornstein [Sun, 21 Nov 2010 22:19:51 +0000 (22:19 +0000)]
Fix the test for sasl.h to look in the correct place.

11 years ago(Minor) cleanup of some of the autoconf code with respect to the handling
Ken Hornstein [Fri, 19 Nov 2010 20:13:39 +0000 (20:13 +0000)]
(Minor) cleanup of some of the autoconf code with respect to the handling
of compiler flags for SASL, and also rototill (and simplify) the autoconf
handling for the same.

Add TLS support for the SMTP MTA.

11 years agoman/ fix formatting error that meant a subsection heading
Peter Maydell [Fri, 12 Nov 2010 23:28:26 +0000 (23:28 +0000)]
man/ fix formatting error that meant a subsection heading
wasn't displayed as such. Followon cleanup: since the new heading is too
wide to fit in the margin, tidy the margin to 4 characters wide so we
are consistent with how all the headings are displayed.

11 years add a level of expansion for mandir when printing the
Peter Maydell [Wed, 10 Nov 2010 22:26:07 +0000 (22:26 +0000)] add a level of expansion for mandir when printing the
end-of-configure install path summary.

11 years agoman/ fix error in synopsis: the option is [no]unlink, not [no]link.
Peter Maydell [Tue, 9 Nov 2010 21:33:22 +0000 (21:33 +0000)]
man/ fix error in synopsis: the option is [no]unlink, not [no]link.

11 years agoSilence a (harmless) uninitialized variable warning.
Peter Maydell [Fri, 5 Nov 2010 22:06:10 +0000 (22:06 +0000)]
Silence a (harmless) uninitialized variable warning.

12 years ago * uip/.cvsignore: added "new". PRE_POSIX_CONVERSION
David Levine [Tue, 31 Aug 2010 15:00:53 +0000 (15:00 +0000)]
* uip/.cvsignore:  added "new".

12 years ago#ifdef AI_ADDRCONFIG since older IPv4-only systems may not define this flag,
Earl Hood [Sat, 6 Feb 2010 07:47:38 +0000 (07:47 +0000)]
#ifdef AI_ADDRCONFIG since older IPv4-only systems may not define this flag,
causing files that use to not compile.

12 years agoFixed variable declaration so older compilers will not complain.
Earl Hood [Sat, 6 Feb 2010 07:45:47 +0000 (07:45 +0000)]
Fixed variable declaration so older compilers will not complain.
I.e. Older compilers may not support C99, so variables must be
declared at the beginning of a block.

12 years ago* Bug #15213, #18635: The use of the insecure m_scratch() and
Earl Hood [Thu, 4 Feb 2010 01:39:21 +0000 (01:39 +0000)]
* Bug #15213, #18635: The use of the insecure m_scratch() and
  m_tmpfil() functions have been replaced by m_mktemp()
  or m_mktemp2() functions (defined in sbr/m_mktemp.c).
  The new functions use mkstemp() to securely create
  temporary files to avoid the numerous race conditions
  that exist with the old functions.  This does assume
  that mkstemp() is available.  Unsure if we need to
  create an alternative implementation if mkstemp() is
  not available.  More information about new temp file
  functions in m_mktemp.c, including the support for
  MHTMPDIR, TMPDIR, and TMP envvars.

NOTE: The files sbr/m_scratch.c and sbr/m_tmpfil.c should be removed.
Until more testing verifies changes to support new functions have not
broken functionality, the files are be left in the tree, but comments
have been added stating the functions in them should not be called.

12 years ago* mts/smtp/smtp.c: added SASL support if mts configuration
Earl Hood [Wed, 3 Feb 2010 05:56:56 +0000 (05:56 +0000)]
* mts/smtp/smtp.c: added SASL support if mts configuration
  setting is set to "sendmail".  This is useful if sendmail
  conf option is to a custom script that creates a proxy
  connection to an smtp server.

* sbr/mts.c: added support for MHMTSCONF and MHMTSUSERCONF
  envvars.  The former specifies an alternative system
  mts.conf to use.  The later specifies a user-specific
  mts.conf to use.  This one will be read after the system
  conf, so the user's conf only needs to set options they
  want to override.  The MHMTSUSERCONF allows a user to set
  personal alternative mail submission methods w/o affecting
  other users on the system.

* uip/whom.c: added SASL-based options so address checking
  can work against a server that requires SASL.

12 years ago * uip/mhlistsbr.c, uip/mhlsbr.c, uip/picksbr.c: cast
David Levine [Wed, 30 Dec 2009 01:42:45 +0000 (01:42 +0000)]
* uip/mhlistsbr.c, uip/mhlsbr.c, uip/picksbr.c: cast
pointers to unsigned long before casting to unsigned int
to avoid warnings on 64-bit about casting from pointer
to int of different size.

12 years ago * uip/new.c: cast folder_len to int to avoid warning on
David Levine [Wed, 30 Dec 2009 01:41:47 +0000 (01:41 +0000)]
* uip/new.c: cast folder_len to int to avoid warning on
64-bit about passing a size_t to an int conversion specifier.

12 years ago * uip/inc.c: gcc 4.4.1 noticed that maildir could have been
David Levine [Fri, 25 Dec 2009 14:47:39 +0000 (14:47 +0000)]
* uip/inc.c: gcc 4.4.1 noticed that maildir could have been
used before initialization.  In fact, if that code was ever
reached, maildir would never have been initialized.  It's in
an adios call, so replaced with NULL.

12 years ago* mts/smtp/smtp.c: In sm_auth_sasl (), removed zeroing of
David Levine [Mon, 21 Dec 2009 17:18:04 +0000 (17:18 +0000)]
* mts/smtp/smtp.c: In sm_auth_sasl (), removed zeroing of
sasl_inbuffer because it could be used in sm_fget ().  Also,
removed allocation of sasl_inbuffer because that was done in
either smtp_init () or sendmail_init ().

13 years agoRemove duplicate sm_fgetc() declaration
Josh Bressers [Mon, 26 Jan 2009 13:38:13 +0000 (13:38 +0000)]
Remove duplicate sm_fgetc() declaration

13 years agoFix warning in getaddrinfo() call.
Ken Hornstein [Wed, 21 Jan 2009 19:38:36 +0000 (19:38 +0000)]
Fix warning in getaddrinfo() call.
Add missing support for -port in whatnow.
Make sure the SASL input buffer is allocated when using the sendmail mts.

13 years ago * etc/ Never try to make mhshow start xterm.
Eric Gillespie [Sun, 18 Jan 2009 04:48:42 +0000 (04:48 +0000)]
* etc/ Never try to make mhshow start xterm.

13 years agoNote 'new' commands.
Eric Gillespie [Sat, 17 Jan 2009 16:53:07 +0000 (16:53 +0000)]
Note 'new' commands.

13 years ago * test/runtest, test/tests/inc/test-deb359167,
Eric Gillespie [Sat, 17 Jan 2009 16:47:29 +0000 (16:47 +0000)]
* test/runtest, test/tests/inc/test-deb359167,
test/tests/inc/test-eom-align, test/tests/manpages/test-manpages:
Load via absolute path, otherwise some /bin/sh
(e.g. dash) can't load it.

* uip/, uip/new.c, test/tests/new/test-basic: Add new
program, and fn/fp/unseen symlinks.

* test/{runtest,setup-test}: Move MH profile under Mail directory
so each test script will have its own to muck with, if needed.

* h/, h/crawl_folders.h, sbr/,
sbr/crawl_folders.c, uip/folder.c: Extract the folder crawling
code from folder.c into new crawl_folders function, using a
callback to assemble the folder info in folder.c.  Drop compare
function and use strcmp instead.  Rename addfold and addir to
add_folder and add_children (add dir vs. add folder?
confusing names).

13 years agoMove freeaddrinfo() to inside of our loop; this prevents a memory leak
Ken Hornstein [Fri, 16 Jan 2009 15:48:09 +0000 (15:48 +0000)]
Move freeaddrinfo() to inside of our loop; this prevents a memory leak
and also prevents it from being called with a NULL pointer.

13 years agoMassive overhaul of networking code. Changes:
Ken Hornstein [Fri, 16 Jan 2009 02:28:54 +0000 (02:28 +0000)]
Massive overhaul of networking code.  Changes:

- All networking interfaces now converted to new APIs (getaddrinfo() and
  the like).  All networking now supports IPv6 (with the exception of
  the built-in FTP client).
- SASL security layers are now supported for SMTP.
- Command-line and profile-based selection of the SMTP server and port.

13 years ago* sbr/m_getfld.c: fix two bugs which could cause us to walk off
Peter Maydell [Fri, 26 Dec 2008 21:54:19 +0000 (21:54 +0000)]
* sbr/m_getfld.c: fix two bugs which could cause us to walk off
the beginning of the stdio or prefix-string buffer when checking
for presence of the end-of-message delimiter in some situations.
This might cause inc to dump core if you were unlucky. (This was
Debian bug 359167.)
* test/tests/inc/{md5sums,msgheader.txt,test-deb359167,
test-eom-align,fromline.txt,filler.txt,deb359167.mbox}: new tests
both for the specific problem and to try to check various alignments
of the eom string with the stdio buffer ending.
* test/ Added some functions for doing progress indicators.

13 years agotest/ new file for common utility functions for the test scripts.
Peter Maydell [Fri, 26 Dec 2008 16:32:07 +0000 (16:32 +0000)]
test/ new file for common utility functions for the test scripts.
Moved findprog out of manpage test script into this new file.

13 years agotest/runtest: automatically run setup-test if it hasn't already
Peter Maydell [Thu, 25 Dec 2008 23:30:33 +0000 (23:30 +0000)]
test/runtest: automatically run setup-test if it hasn't already
been done. Improve error handling in test script with 'set -e'.

13 years ago * h/mh.h: raised NAMESZ from 128 to 999. RFC 2822 limits line
David Levine [Thu, 23 Oct 2008 18:38:22 +0000 (18:38 +0000)]
* h/mh.h: raised NAMESZ from 128 to 999.  RFC 2822 limits line
lengths to 998 characters, so a header name can be at most that long.
m_getfld limits header names to 2 less than NAMESZ, which is fine,
because header names must be followed by a colon.  Add one for
terminating NULL.