app_msgarg: de-obfuscate

add some whitespace and break things up.  and add comment to reflect
that this might be (and is) used for more than just msg parameters.

diff --git a/sbr/utils.c b/sbr/utils.c
index cce7378..a279a32 100644 (file)
--- a/sbr/utils.c
+++ b/sbr/utils.c
@@ -213,14 +213,16 @@ num_digits (int n)
 
 /*
  * Append a message arg to an array of them, resizing it if necessary.
- * The function is written to suit the arg parsing code it was extracted
- * from, and will probably be changed when the other code is cleaned up.
+ * Really a simple vector-of-(char *) maintenance routine.
  */
 void
 app_msgarg(struct msgs_array *msgs, char *cp)
 {
-       if(msgs->size >= msgs->max)
-               msgs->msgs = mh_xrealloc(msgs->msgs, (msgs->max+=MAXMSGS)*sizeof(*msgs->msgs));
+       if(msgs->size >= msgs->max) {
+               msgs->max += MAXMSGS;
+               msgs->msgs = mh_xrealloc(msgs->msgs,
+                       msgs->max * sizeof(*msgs->msgs));
+       }
        msgs->msgs[msgs->size++] = cp;
 }