Lots of little code cleanups to prevent warnings - mostly making sure

some function prototypes are available at compile time. Also fixed
Makefile.in so that make nmhdist will work -- it just blew up after
COMPLETION-TCSH was added and ZSH-COMPLETION was changed to
COMPLETION-ZSH.

diff --git a/ChangeLog b/ChangeLog
index 81cf02da6b490677b2e083b4e93b2b7dacc6e862..810b8230b15b0d5323440b9b91a69e3c252529cd 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,21 +1,57 @@
+Sun Sep 12 15:50:34 1999 Doug Morris <doug@mhost.com>
+
+       * updated Makefile.in so it recognized COMPLETION-TCSH and
+       COMPLETION-ZSH (only used in make nmhdist). 
+
+       * added prototype for ruserpas to <h/prototypes.h>. Fixes
+       warnings in mhparse.c and mhbuildsbr.c.
+
+       * added include checks for <time.h> and <sys/time.h> to
+       prevent warnings in fmt_compile.c, fmt_scan.c, lock_file.c,
+       sendsbr.c, mhbuildsbr.c, mhcachesbr.c, picksbr.c, and post.c.
+
+       * added include for <zotnet/mts/mts.h> to ali.c, scan.c, ap.c,
+       rcvdist.c, rcvstore.c, rcvtty.c, and spost.c to remove
+       warnings about implicit definition of mts_init().
+
+       * added <grps.h> to slocal.c to prevent warnings about
+       function initgroups.
+
+       * added <h/signals.h> to prevent warning about missing SIGNAL
+       function.
+
+       * added function prototypes to smtp.c, whatnowproc.c,
+       mhbuildsbr.c, mhparse.c, mshcmds.c, show.c, whatnow.c, mhl.c
+       to fix warnings.
+
+       * explicitly declared mbx_style in mshcmds.c and lused in
+       fmtdump.c as type static int instead of just static to
+       prevent warnings.
+       
+       * various code cleanups to prevent ambiguous statements
+       (brackets for if/thens and parens for complicated if
+       statements).
+
+
 Sun Sep 12 09:19:27 1999 Doug Morris <doug@mhost.com>
 
        * commented out _cleanup() in mf.c because it's the only
-         location in all of the source code where it exists. 
+       location in all of the source code where it exists. 
 
        * Added check for <db1/ndbm.h> which is the new location where
-         linux systems appear to be stuffing this header file.
+       linux systems appear to be stuffing this header file.
 
 Thu Sep  9 23:15:49 1999 Doug Morris <doug@mhost.com>
 
        * fixed varous mkstmep bugs introduced in 1.0.1 by me. Whups!
 
        * added mh_profile SEGV patch from Richard Cohen
-          <richard@jubjub.demon.co.uk> that prevents crashing when
+        <richard@jubjub.demon.co.uk> that prevents crashing when
+        mh_profile doesn't end in a newline. A similar patch was
+       previously sent in by Andrew Bettison <andrewb@zip.com.au>.
 
-          mh_profile doesn't end in a newline.
        * fixed bug in associated with MAILGROUP #define (group "mail"
-         is not universal) -- hard to believe, but true.
+       is not universal) -- hard to believe, but true.
 
 Tue Sep 7 16:47:03 1999 Dan Harkless <dan-nmh@dilvish.speed.net>
 

diff --git a/Makefile.in b/Makefile.in
index 3474570c5a1f2074b8eda26c91cc10846ca9c75d..60fb91591d96a5fe68e32ae50d0d9da757babbf3 100644 (file)
--- a/Makefile.in
+++ b/Makefile.in
@@ -71,9 +71,9 @@ INSTALL_DATA    = @INSTALL_DATA@
 
 # all files in this directory included in the distribution
 DIST = README INSTALL MACHINES COPYRIGHT VERSION DIFFERENCES FAQ \
-       TODO ZSH.COMPLETION MAIL.FILTERING ChangeLog install-sh \
-       mkinstalldirs Makefile.in aclocal.m4 acconfig.h config.h.in \
-       configure.in configure stamp-h.in
+       TODO COMPLETION-ZSH COMPLETION-TCSH MAIL.FILTERING \
+       ChangeLog install-sh mkinstalldirs Makefile.in aclocal.m4 \
+       acconfig.h config.h.in configure.in configure stamp-h.in
 
 # subdirectories in distribution
 SUBDIRS = h config sbr zotnet mts uip etc man

diff --git a/h/prototypes.h b/h/prototypes.h
index 5fe0b0c2c18f9cc46466d52d375011c5edc100c1..59841a22ec3f4d801bfffd01f1c16c41a59ef5fa 100644 (file)
--- a/h/prototypes.h
+++ b/h/prototypes.h
@@ -94,6 +94,7 @@ char *pwd (void);
 char *r1bindex(char *, int);
 void readconfig (struct node **, FILE *, char *, int);
 int refile (char **, char *);
+int ruserpass(char *, char **, char **);
 int remdir (char *);
 int seq_addmsg (struct msgs *, char *, int, int, int);
 int seq_addsel (struct msgs *, char *, int, int);

diff --git a/mts/smtp/hosts.c b/mts/smtp/hosts.c
index 55f339387af6ea2c986fe5e83add4dcad9c07527..daa59b6b6dc074250908bacd906350707ac0d63f 100644 (file)
--- a/mts/smtp/hosts.c
+++ b/mts/smtp/hosts.c
@@ -55,14 +55,16 @@ OfficialName (char *name)
        strncpy (buffer, hp->h_name, sizeof(buffer));
        return buffer;
     }
-    if (hosts.h_name || init_hs ())
+    if (hosts.h_name || init_hs ()) {
        for (h = hosts.h_next; h; h = h->h_next)
-           if (!strcasecmp (h->h_name, q))
+           if (!strcasecmp (h->h_name, q)) {
                return h->h_name;
-           else
+           } else {
                for (r = h->h_aliases; *r; r++)
                    if (!strcasecmp (*r, q))
                        return h->h_name;
+           }
+    }
 
     strncpy (buffer, site, sizeof(buffer));
     return buffer;

diff --git a/mts/smtp/smtp.c b/mts/smtp/smtp.c
index 90b37a82572eacde30dee6fef39c3eb6e62a442a..a0d84d5fbe8a8f2c69e5eb36442521c58c27d24b 100644 (file)
--- a/mts/smtp/smtp.c
+++ b/mts/smtp/smtp.c
@@ -9,10 +9,13 @@
 #include "smtp.h"
 #include <zotnet/mts/mts.h>
 #include <signal.h>
+#include <h/signals.h>
 #ifdef MPOP
 #include <errno.h>
 #endif
 
+
+
 /*
  * This module implements an interface to SendMail very similar
  * to the MMDF mm_(3) routines.  The sm_() routines herein talk
@@ -104,6 +107,8 @@ static int smail_brkany (char, char *);
 char **smail_copyip (char **, char **, int);
 #endif
 
+/* from zotnet/mts/client.c */
+int client (char *, char *, char *, int, char *, int);
 
 int
 sm_init (char *client, char *server, int watch, int verbose,
@@ -125,11 +130,13 @@ sm_init (char *client, char *server, int watch, int verbose,
     if (sm_rfp != NULL && sm_wfp != NULL)
        goto send_options;
 
-    if (client == NULL || *client == '\0')
-       if (clientname)
+    if (client == NULL || *client == '\0') {
+       if (clientname) {
            client = clientname;
-       else
+       } else {
            client = LocalName();       /* no clientname -> LocalName */
+       }
+    }
 
 #ifdef ZMAILER
     if (client == NULL || *client == '\0')

diff --git a/sbr/fmt_compile.c b/sbr/fmt_compile.c
index 339ac0a21b51fb54f936de173f087068e1dffe0d..d3e5ea90c500cbc9fce5d85f43f17391d7aae2b1 100644 (file)
--- a/sbr/fmt_compile.c
+++ b/sbr/fmt_compile.c
@@ -11,6 +11,17 @@
 #include <h/fmt_scan.h>
 #include <h/fmt_compile.h>
 
+#ifdef TIME_WITH_SYS_TIME
+# include <sys/time.h>
+# include <time.h>
+#else
+# ifdef TM_IN_SYS_TIME
+#  include <sys/time.h>
+# else
+#  include <time.h>
+# endif
+#endif
+
 /*
  * hash table for deciding if a component is "interesting"
  */

diff --git a/sbr/fmt_scan.c b/sbr/fmt_scan.c
index 0af69aba2533b64127c4f529be202202e2e40b75..ae311621b22e098e70c6219cbb4f1c8ce8829a3a 100644 (file)
--- a/sbr/fmt_scan.c
+++ b/sbr/fmt_scan.c
@@ -11,6 +11,17 @@
 #include <zotnet/tws/tws.h>
 #include <h/fmt_compile.h>
 
+#ifdef TIME_WITH_SYS_TIME
+# include <sys/time.h>
+# include <time.h>
+#else
+# ifdef TM_IN_SYS_TIME
+#  include <sys/time.h>
+# else
+#  include <time.h>
+# endif
+#endif
+
 #define        NFMTS MAXARGS
 
 extern char *formataddr ();    /* hook for custom address formatting */

diff --git a/sbr/lock_file.c b/sbr/lock_file.c
index fe42196bb2cfc13d4f693e293bdf9a946f41b562..a99c681b19c8d6c16e55d430ea2e0a155b4515bd 100644 (file)
--- a/sbr/lock_file.c
+++ b/sbr/lock_file.c
@@ -8,6 +8,17 @@
 #include <h/mh.h>
 #include <h/signals.h>
 
+#ifdef TIME_WITH_SYS_TIME
+# include <sys/time.h>
+# include <time.h>
+#else
+# ifdef TM_IN_SYS_TIME
+#  include <sys/time.h>
+# else
+#  include <time.h>
+# endif
+#endif
+
 #ifdef HAVE_ERRNO_H
 # include <errno.h>
 #endif

diff --git a/sbr/m_getfld.c b/sbr/m_getfld.c
index 475289331d31c467be76df4e228153daf197af1a..cddf362b2d582a61b390023e592aab45e1d17bad 100644 (file)
--- a/sbr/m_getfld.c
+++ b/sbr/m_getfld.c
@@ -390,7 +390,8 @@ m_getfld (int state, unsigned char *name, unsigned char *buf,
                *cp++ = j = *(iob->_ptr + c);
                c = _filbuf(iob);
 #endif
-                if (c == EOF || (j == '\0' || j == '\n') && c != ' ' && c != '\t') {
+                if (c == EOF || 
+                 ((j == '\0' || j == '\n') && c != ' ' && c != '\t')) {
                    if (c != EOF) {
 #ifdef LINUX_STDIO
                        --iob->_IO_read_ptr;

diff --git a/uip/ali.c b/uip/ali.c
index 54c8b05a00eaf63c1b53c56b6be21d418dc5a330..d03d7173455bd8bf52d03c17f2a8bfd4a9c96e65 100644 (file)
--- a/uip/ali.c
+++ b/uip/ali.c
@@ -8,6 +8,7 @@
 #include <h/mh.h>
 #include <h/addrsbr.h>
 #include <h/aliasbr.h>
+#include <zotnet/mts/mts.h>
 
 /*
  * maximum number of names

diff --git a/uip/ap.c b/uip/ap.c
index 11381f3c868851d963a1a1b2b18e1def6e1b5cf8..2abba4bca32340373ce1d2235692ed5747a99ac8 100644 (file)
--- a/uip/ap.c
+++ b/uip/ap.c
@@ -8,6 +8,7 @@
 #include <h/mh.h>
 #include <h/addrsbr.h>
 #include <h/fmt_scan.h>
+#include <zotnet/mts/mts.h>
 
 #define        NADDRS  100
 

diff --git a/uip/fmtdump.c b/uip/fmtdump.c
index 9ae23b4121075246c0277b2c170a1e142e8c25e1..87e22bf1ae50228d39ed5ddca57551325bca9a61 100644 (file)
--- a/uip/fmtdump.c
+++ b/uip/fmtdump.c
@@ -24,7 +24,7 @@ static struct swit switches[] = {
 
 /* for assignlabel */
 static struct format *lvec[128];
-static lused = 0;
+static int lused = 0;
 
 /*
  * static prototypes

diff --git a/uip/mhbuildsbr.c b/uip/mhbuildsbr.c
index a65736f3c7e234adc22f0cd12658038d2add420b..7e805654e432625f8f974f5f6a4750d3a47bff75 100644 (file)
--- a/uip/mhbuildsbr.c
+++ b/uip/mhbuildsbr.c
@@ -24,6 +24,17 @@
 #include <h/mime.h>
 #include <h/mhparse.h>
 
+#ifdef TIME_WITH_SYS_TIME
+# include <sys/time.h>
+# include <time.h>
+#else
+# ifdef TM_IN_SYS_TIME
+#  include <sys/time.h>
+# else
+#  include <time.h>
+# endif
+#endif
+
 #ifdef HAVE_SYS_WAIT_H
 # include <sys/wait.h>
 #endif

diff --git a/uip/mhcachesbr.c b/uip/mhcachesbr.c
index b372f9501e4448e7f65007e1499b570b47d7b534..c1af218018af4b061f9534d6c7d7df1a62772e53 100644 (file)
--- a/uip/mhcachesbr.c
+++ b/uip/mhcachesbr.c
@@ -18,6 +18,17 @@
 #include <h/mhparse.h>
 #include <h/mhcachesbr.h>
 
+#ifdef TIME_WITH_SYS_TIME
+# include <sys/time.h>
+# include <time.h>
+#else
+# ifdef TM_IN_SYS_TIME
+#  include <sys/time.h>
+# else
+#  include <time.h>
+# endif
+#endif
+
 #ifdef HAVE_SYS_WAIT_H
 # include <sys/wait.h>
 #endif

diff --git a/uip/mhl.c b/uip/mhl.c
index 6ef30fbf21c6b5169c25766360afa56addd2cb76..33e9f3fae750a17bcf3d55b3b29cdf1cfa762b6c 100644 (file)
--- a/uip/mhl.c
+++ b/uip/mhl.c
@@ -7,6 +7,9 @@
 
 #include <h/mh.h>
 
+/* prototype from mhlsbr.c */
+int mhl (int, char **);
+
 
 int
 main (int argc, char **argv)

diff --git a/uip/mshcmds.c b/uip/mshcmds.c
index 3d6e260fe70ae33f081079dbcb1e54d585fbd3d6..13ad35622c3f5136baa8f6d45efbfbc9f54ae838 100644 (file)
--- a/uip/mshcmds.c
+++ b/uip/mshcmds.c
@@ -68,6 +68,8 @@ static int process (int, char *, int, char **);
 static void copy_message (int, FILE *);
 static void copy_digest (int, FILE *);
 
+/* from mhlsbr.c */
+int mhlsbr (int, char **, FILE *(*)());
 
 void
 forkcmd (char **args, char *pgm)
@@ -1456,7 +1458,7 @@ static struct swit packswit[] = {
     { NULL, 0 }
 };
 
-static mbx_style = MMDF_FORMAT;
+static int mbx_style = MMDF_FORMAT;
 
 void
 packcmd (char **args)

diff --git a/uip/picksbr.c b/uip/picksbr.c
index 36ca6956c9e844621bf0e4b3d7b94b64f8c78d4e..b13ea669d56f79a3eb16ea38c817fb330ff4141d 100644 (file)
--- a/uip/picksbr.c
+++ b/uip/picksbr.c
@@ -9,6 +9,17 @@
 #include <zotnet/tws/tws.h>
 #include <h/picksbr.h>
 
+#ifdef TIME_WITH_SYS_TIME
+# include <sys/time.h>
+# include <time.h>
+#else
+# ifdef TM_IN_SYS_TIME
+#  include <sys/time.h>
+# else
+#  include <time.h>
+# endif
+#endif
+
 static struct swit parswit[] = {
 #define        PRAND                   0
     { "and", 0 },

diff --git a/uip/post.c b/uip/post.c
index 8eb3b77fcdaa95d4e66ab5e869b6f18ee2a08318..ffd460e497cb132f53d2286e3194d0ee170a3d82 100644 (file)
--- a/uip/post.c
+++ b/uip/post.c
@@ -20,6 +20,17 @@
 #include <setjmp.h>
 #include <signal.h>
 
+#ifdef TIME_WITH_SYS_TIME
+# include <sys/time.h>
+# include <time.h>
+#else
+# ifdef TM_IN_SYS_TIME
+#  include <sys/time.h>
+# else
+#  include <time.h>
+# endif
+#endif
+
 #ifdef MMDFMTS
 # include <mts/mmdf/util.h>
 # include <mts/mmdf/mmdf.h>

diff --git a/uip/rcvdist.c b/uip/rcvdist.c
index 922670b52448c74d97d181cf3c240dc8e97e6ae4..5fca8ec50433760e31b6dc78ceee278cbf0bd2e6 100644 (file)
--- a/uip/rcvdist.c
+++ b/uip/rcvdist.c
@@ -9,6 +9,7 @@
 #include <h/fmt_scan.h>
 #include <h/rcvmail.h>
 #include <zotnet/tws/tws.h>
+#include <zotnet/mts/mts.h>
 
 static struct swit switches[] = {
 #define        FORMSW       0

diff --git a/uip/rcvstore.c b/uip/rcvstore.c
index 5a3dcbe02447e88823f102053c163e0b489b9f49..43d38892f4581b3d9285073330985996c2c2e2d5 100644 (file)
--- a/uip/rcvstore.c
+++ b/uip/rcvstore.c
@@ -10,6 +10,7 @@
 #include <h/signals.h>
 #include <errno.h>
 #include <signal.h>
+#include <zotnet/mts/mts.h>
 
 static struct swit switches[] = {
 #define CRETSW         0

diff --git a/uip/rcvtty.c b/uip/rcvtty.c
index 464a0276be02936d3025fceb9342ef10d0ac4ba0..f92201271b326eb7db043c037c425da0d065b860 100644 (file)
--- a/uip/rcvtty.c
+++ b/uip/rcvtty.c
@@ -10,6 +10,7 @@
 #include <h/rcvmail.h>
 #include <h/scansbr.h>
 #include <zotnet/tws/tws.h>
+#include <zotnet/mts/mts.h>
 #include <signal.h>
 #include <fcntl.h>
 

diff --git a/uip/scan.c b/uip/scan.c
index cbd92773fe2d6f6452c69e6aa53574698669fe62..b40537c078a2255a15d68f695e04258fd0f8cf45 100644 (file)
--- a/uip/scan.c
+++ b/uip/scan.c
@@ -9,6 +9,7 @@
 #include <h/fmt_scan.h>
 #include <h/scansbr.h>
 #include <zotnet/tws/tws.h>
+#include <zotnet/mts/mts.h>
 #include <errno.h>
 
 /*

diff --git a/uip/sendsbr.c b/uip/sendsbr.c
index b7c4cf24b4447e03687d2a2bb9e1a33015f06ec4..2c2e3a63d428c57e77ace6bb80f7b03f3c037b07 100644 (file)
--- a/uip/sendsbr.c
+++ b/uip/sendsbr.c
@@ -12,6 +12,17 @@
 #include <fcntl.h>
 #include <h/mime.h>
 
+#ifdef TIME_WITH_SYS_TIME
+# include <sys/time.h>
+# include <time.h>
+#else
+# ifdef TM_IN_SYS_TIME
+#  include <sys/time.h>
+# else
+#  include <time.h>
+# endif
+#endif
+
 int debugsw = 0;               /* global */
 int forwsw  = 1;
 int inplace = 1;

diff --git a/uip/show.c b/uip/show.c
index 7927ac564c0275f1b913f8ad304bb0df52ce6748..d656bf9527bde71eeb1dde83d641d4e1a70d0026 100644 (file)
--- a/uip/show.c
+++ b/uip/show.c
@@ -49,6 +49,9 @@ static struct swit switches[] = {
  */
 static int is_nontext(char *);
 
+/* prototype from mhlsbr.c */
+int mhl (int, char **);
+
 #define        SHOW  0
 #define        NEXT  1
 #define        PREV  2

diff --git a/uip/slocal.c b/uip/slocal.c
index c6aa286c54fc5187d67ea3c0d73a31ce59fd7bcd..03dea14832b548a055e1974de12b0273a4ba5758 100644 (file)
--- a/uip/slocal.c
+++ b/uip/slocal.c
@@ -28,6 +28,7 @@
 #include <signal.h>
 #include <sys/ioctl.h>
 #include <fcntl.h>
+#include <grp.h>
 
 #ifdef HAVE_DB1_NDBM_H
 #include <db1/ndbm.h>

diff --git a/uip/spost.c b/uip/spost.c
index f2d6311a2a3425110b7d54f49f6d72033da52fd7..1f3b014b8fb74a79c02c3af17677e40362eae931 100644 (file)
--- a/uip/spost.c
+++ b/uip/spost.c
@@ -14,6 +14,7 @@
 #include <h/aliasbr.h>
 #include <h/dropsbr.h>
 #include <zotnet/tws/tws.h>
+#include <zotnet/mts/mts.h>
 
 #define        uptolow(c)      ((isalpha(c) && isupper (c)) ? tolower (c) : c)
 

diff --git a/uip/whatnow.c b/uip/whatnow.c
index 34c560ee8d29a90f534363d01f2daddba58255b1..0033f8b29d7a70cadeebb7be64707351242ab58b 100644 (file)
--- a/uip/whatnow.c
+++ b/uip/whatnow.c
@@ -7,6 +7,9 @@
 
 #include <h/mh.h>
 
+/* from whatnowsbr.c */
+int WhatNow (int, char **);
+
 
 int
 main (int argc, char **argv)

diff --git a/uip/whatnowproc.c b/uip/whatnowproc.c
index caeeec2c79017cdc54254967c23f461c246299c1..7f88fc48dd413f737422a0f0c6c7c8d6de6f142d 100644 (file)
--- a/uip/whatnowproc.c
+++ b/uip/whatnowproc.c
@@ -17,6 +17,10 @@
  * it will call this routine directly without exec'ing it.
  */
 
+/* from whatnowsbr.c */
+int WhatNow (int, char **);
+
+
 int
 what_now (char *ed, int nedit, int use, char *file, char *altmsg, int dist,
           struct msgs *mp, char *text, int inplace, char *cwd)