Move freeaddrinfo() to inside of our loop; this prevents a memory leak

and also prevents it from being called with a NULL pointer.

diff --git a/sbr/client.c b/sbr/client.c
index ae6968f..732fb47 100644 (file)
--- a/sbr/client.c
+++ b/sbr/client.c
@@ -111,9 +111,10 @@ client (char *args, char *service, char *response, int len_response, int debug)
 
            close(sd);
        }
+
+       freeaddrinfo(res);
     }
 
-    freeaddrinfo(res);
     client_freelist(ap);
     strncpy (response, "no servers available", len_response);
     return NOTOK;