Ken Hornstein [Tue, 28 Feb 2012 03:05:41 +0000 (22:05 -0500)]
Fix bug #1466. It turns out that RFC 934 specifies that any line starting
with a "-" but NOT followed by a space is a valid message delimiter. We
only supported one type of message delimiter. Adapt the code so any
valid delimiter is supported.
David Levine [Tue, 28 Feb 2012 02:56:58 +0000 (20:56 -0600)]
Added cast in conditional to prevent signed/unsigned comparison, and wrapped argument to prevent warning about unused argument when built without SASL support.
Ken Hornstein [Mon, 27 Feb 2012 02:14:04 +0000 (21:14 -0500)]
Fix up some of the pick tests:
- Change sed invocation around to get rid of GNU sed extensions
- Put explicit times in the pick tests (if you don't, it uses the current
hour/minutes as the timestamp, which means it could work or not work
depending on what time of day you run the tests).
David Levine [Thu, 23 Feb 2012 04:21:56 +0000 (22:21 -0600)]
Don't list _sysconfdir/ directory in RPM spec. We don't list any other directories, so now it will be created with the same permissions as all of the others.
David Levine [Wed, 22 Feb 2012 01:31:08 +0000 (19:31 -0600)]
With "make rpm", configure all modified files in sysconfdir (etc) to be saved when erasing or upgrading the package. Also, leave the doc directory whereever "make install" puts it.
David Levine [Sun, 19 Feb 2012 04:36:50 +0000 (22:36 -0600)]
Ken noted that "make check" can be run before installation because the only program in lib that the tests currently use is mhlproc, and we have an mhlproc entry in the test .mh_profile for that. Added showproc and postproc entries in case they're ever needed.
David Levine [Sat, 18 Feb 2012 15:42:04 +0000 (09:42 -0600)]
Added mhpath test. Updated mhpath man page to reflect actual behavior for a message number greater than that of the highest existing message in a folder.
David Levine [Fri, 17 Feb 2012 03:30:43 +0000 (21:30 -0600)]
Rearranged test suite environment variables so that individual tests
can now be run standalone (outside of make). But see WARNING in
test/README about how it's better to use "make check" because that
ensures that the current code in your workspace is tested. Also, the
clean script no longer needs to call setup_test.
Ken Hornstein [Wed, 15 Feb 2012 19:55:25 +0000 (14:55 -0500)]
Hm, it turns out we need to make sure we call getname() until we get
a NULL, otherwise the next set of calls to it will be working from the
"old" search string.
Ken Hornstein [Sun, 12 Feb 2012 04:28:10 +0000 (23:28 -0500)]
Another problem discovered by the test suite.
With multiple sequence arguments on the command line you might end
up with garbage in the sequence[] array (it needs the last argument
to be a NULL. So do two things: make the first two arguments NULL, and
as we add arguments to sequence[] make sure the list has a NULL on the
end.
David Levine [Thu, 9 Feb 2012 03:41:48 +0000 (21:41 -0600)]
Always run setup-test from make test/runalltests, just in case the test build directory (test/testbuild) isn't up to date. It might be nice to replace all the copies in the test build directory with symlinks, then make could keep the test build up to date.
David Levine [Wed, 8 Feb 2012 03:23:37 +0000 (21:23 -0600)]
Removed use of tzset()/tzname in dtimezone(). They caused the returned timezone string to be for the user's current timezone, but the function is supposed to return the string representation of the timezone of its argument. That will be numeric, e.g., +0100, now because we no longer have timezone name support.
David Levine [Tue, 7 Feb 2012 03:47:52 +0000 (21:47 -0600)]
Caught by the test suite: sequences[0] needs to be initialized to NULL at the beginning of the program. That explains why it seg faulted when invoked with a sequence argument.
Ken Hornstein [Mon, 6 Feb 2012 16:31:18 +0000 (11:31 -0500)]
Patch from Harvey Eneman: fixes problem on some systems where a free()
would be called on non-malloc'd memory (only would happen if you had more
than one entry in the server: line in mts.conf).