Glenn Burkhardt [Mon, 30 Jun 2003 18:58:07 +0000 (18:58 +0000)]
fix bug #1393, "sortm core dumps", using patch provided by
Robert Elz, kre@munnari.oz.au. The core dump occurred
when "Subject:" was immediately followed by an
alphanumeric, and "-textfield subject" were used
as arguments.
Glenn Burkhardt [Thu, 26 Jun 2003 01:30:36 +0000 (01:30 +0000)]
fix for bug #578 repl leaks umask; there are several other
places in the code where the umask value is not restored,
so there might be other similar bugs
Glenn Burkhardt [Sun, 22 Jun 2003 23:58:07 +0000 (23:58 +0000)]
Allowed gdbm as substitute for Berkeley db1/ndbm.h libdb1 (check for
gdbm/ndbm.h, libgdbm now); send only stdout to /dev/null when checking for
'broken vi', this allows 'vim' on Solaris to work, since 'vim' closes stdin
and uses stderr for input when running a script.
Jon Steinhart [Mon, 18 Nov 2002 18:25:00 +0000 (18:25 +0000)]
The file README-ATTACHMENTS was removed - it has been moved to the docs
subdirectory. I thought that this had already been done but I guess not.
It's unrelated to the rest of these changes.
The remainder of these changes affect the way that nmh is installed. Nmh
has historically prompted the user for installation when any nmh command
is invoked if it doesn't think that it's installed. This is a problem for
programs that want to, for example, interact with nmh programs via pipes.
These changes alter this behavior. Now, when an nmh program thinks that
nmh isn't installed, it tells the user to run install-mh to install it.
A -check option has been added to install-mh that allows the existence of
an installation to be silently checked and indicated via the exit status.
The bulk of this change is in sbr/read_context.c. In the process of making
these changes, I noticed a fair amount of useless code that I removed. In
particular:
1. The program started with a test for whether or not defpath had already
been set. This could only happen if context_read() was called more
than once, which it isn't. This check also existed and was removed
from the following places:
sbr/context_del.c
sbr/context_find.c
sbr/context_replace.c
sbr/seq_read.c
sbr/seq_save.c
uip/flist.c
uip/folder.c
uip/rmf.c
2. A similar test for mypath was removed. No need to test it since it
doesn't happen. I'm just not a believer that
a = 1;
if (a != 1)
error();
is a good way to write code!
3. I removed the code makes a copy of the $HOME environment variable as
returned by getenv(). It's never changed, so it doesn't need copying.
4. I removed code that copied the pw_dir member of the passwd structure
returned by getpwuid() if $HOME isn't set. Yes, the returned structure
is static, but since the function is never called again the returned
values stay valid and don't need copying.
5. I removed the test for a NULL pw_dir member in the passwd structure
returned by getpwuid() since that never happens.
6. I removed code that removed a trailing / from mypath if mypath is more
than one character long. Unnecessary as // is interpreted as / anyway.
mypath never shows up in an error message, so nobody will ever see it.
Besides, this code didn't handle the case of multiple trailing slashes.
7. I removed code that replaced the MH environment variable contents with
an absolute path if it was a relative one. I'm a bit nervous about this
one, only testing will tell. Any nmh program that's invoked will use
the same context_read() code to convert a relative path to an absolute
one anyway. And there's no guarantee (or discussion) of this feature
in any of the documentation.
8. Althout context_read() tested the MH environment variable, install-mh
didn't. This means that the behavior was not consistent between
install-mh and all other nmh programs. I changed install-mh to be
consistent with context_read().
9. install-mh has been installed in the lib directory, not bin. So a
user would be unlikely to find it when prompted to run it. The
installation has been changed to add a link from bin to lib.
Shantonu Sen [Tue, 6 Feb 2001 20:35:40 +0000 (20:35 +0000)]
Be more picky about symbolic time zones, and accept either a symbolic
or numeric time zone, but never both, since a DST offset might be subtracted
twice. Also, be uniform about assuming that pre-1970 dates are Y2K problems.
Dan Harkless [Tue, 6 Feb 2001 04:28:04 +0000 (04:28 +0000)]
Say in README.developers to use `\date' in case anyone is like me and
has `date' aliased in their shell to use a nonstandard (but
subjectively more readable) format.
Dan Harkless [Tue, 6 Feb 2001 04:22:09 +0000 (04:22 +0000)]
Regenerated stamp-h.in using my tcsh alias `date', which uses a
nonstandard format. Replacing it with the standard format. I'll
update README.developers to say to use `\date'.
Dan Harkless [Tue, 6 Feb 2001 03:46:27 +0000 (03:46 +0000)]
* -L isn't sufficient for specifying the path of the Cyrus SASL
shared library. That'll allow us to link successfully, but on
many/most OSes that won't allow us to find libsasl at runtime. On
Solaris, we need to specify the library path with -R as well (or
else the user will have to use the $LD_LIBRARY_PATH kludge, which
is considered harmful). This fix should be extended to other OSes
as well.
* Print whether we have SASL support in the "nmh configuration"
summary configure prints out.
Shantonu Sen [Sun, 24 Dec 2000 10:04:58 +0000 (10:04 +0000)]
Fixed up the hesiod library test so that the location of res_send
actually helps to determine whether -lresolv needs to be passed
as a hesiod lib. Also, fixed the krb5 test to look for
-lk5crypto if it exists, since that's the new name for -lcrypto.
The old -lcrypto remains in case the new version isn't found.
Dan Harkless [Wed, 20 Dec 2000 03:30:14 +0000 (03:30 +0000)]
Just changed a "can" to a "could" since I don't know if most POP3 servers are
like qpopper in not allowing people with APOP activated to log in via normal
POP3.
Shantonu Sen [Thu, 14 Dec 2000 01:30:43 +0000 (01:30 +0000)]
Resolve the circular dependency of libmh on libmts on libmh. The
files mts/generic/client.c and mts.c are moved to sbr/, and mts/generic/mts.h
is moved to h/mts.h. Thus, libmh is self-contained. All header includes
have been appropriately updated, and the Makefiles and configure script
no longer build mts/generic.
Dan Harkless [Tue, 12 Dec 2000 06:19:25 +0000 (06:19 +0000)]
When Shantonu made the new libmts.a, he swapped $(MTSLIB) and libmh.a in
sbr/Makefile.in so that libmh.a comes first, but this causes the build to fail
on Solaris, because libmts.a has to get ruserpass() out of libmh.a. Swapping
them back to the way Ken Hornstein's patch (which I applied on Jul 20) put them,
with libmh.a correctly coming second. If there are times when libmts.a needs to
come second, then it would appear there's a circular dependency and someone
(Shantonu?) did an mts merge incorrectly.
projects / mmh / log