David Levine [Sun, 8 Jan 2012 19:46:47 +0000 (13:46 -0600)]
gcc -Wempty-body warned that the check of the result from the call to parse_mime() was ignored. It has been that way since the beginning of history and was probably of no consequence, but fixed anyway.
David Levine [Sat, 7 Jan 2012 16:03:35 +0000 (10:03 -0600)]
Added Content-Description header with the filename of the attachment, with attachformats 1 and 2. This seems to be common practice now and gives mhlist something useful to display.
Ken Hornstein [Fri, 6 Jan 2012 15:29:35 +0000 (10:29 -0500)]
Huh, turns out this define hasn't worked in forever ... the original
changes were made to the lexer output, and silently vanished a decade
ago when code was reorganized from zotnet to sbr!
Lyndon Nerenberg [Sun, 25 Dec 2011 19:58:38 +0000 (11:58 -0800)]
Make use of mkstemp() unconditional (vs. mktemp().
This patch also removes the m_scratch() and m_tmpfil() functions.
They have been deprecated for a while, and are no longer used in any of
the code base.
David Levine [Sun, 25 Dec 2011 01:36:32 +0000 (19:36 -0600)]
Replaced cvs with git references. I'm not sure about the cgit
URL at the very end. Also removed mention of source directories
that were deprecated and removed long ago.
David Levine [Tue, 13 Dec 2011 04:50:06 +0000 (22:50 -0600)]
Replaced use of GNU make shell function with backticks. These were
for the rpm target, which would most likely only be build on Linux.
So they probably would have been OK, but just in case.
David Levine [Tue, 13 Dec 2011 04:25:52 +0000 (22:25 -0600)]
The docs/Makefile install target didn't do anything before. Added
the files that go into doc to it, and removed them from nmh.spec.
nmh.spec should now require zero maintenance.
Peter Maydell [Tue, 21 Dec 2010 16:50:24 +0000 (16:50 +0000)]
Clean up code in inc.c
Clean up the confusing use of a variable 'i' in inc.c.
The case where it was being used as 'an error occurred
which means we should not truncate the mailspool' is now
called 'incerr' and merged with the equivalent 'p' variable
used in the POP-specific code. Cases where it was being
used as a random temporary are still called 'i' but now
declared with a much more restricted scope.
This fixes a compilation warning for some compilers.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Peter Maydell [Mon, 20 Dec 2010 21:13:32 +0000 (21:13 +0000)]
Suppress tsort diagnostic waffle
tsort produces waffle to standard error if it detects loops in its input.
For our purposes in ordering object files this is harmless, so just send
it all to /dev/null.
Signed-off-by: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Peter Maydell [Mon, 20 Dec 2010 21:13:32 +0000 (21:13 +0000)]
Fix unused-function warnings in lex output
Fix the unused-function warnings in the output of lex. In particular, we
silence a warning about yyunput being static but unused by exposing it as
a global function. This costs us a few hundred bytes in the binary but
the other available solutions are flex-specific or more complicated.
YY_NO_UNPUT used to silence this but no longer works in recent flex.
On the other hand YY_NO_INPUT does work to silence warnings about input().
Signed-off-by: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Peter Maydell [Mon, 20 Dec 2010 21:13:32 +0000 (21:13 +0000)]
Fix used-uninitialised warning in fmt_rfc2047.c
Fix a used-uninitialised warning in fmt_rfc2047.c.
I don't think it can actually be used uninitialised, but the
code is too complicated for the compiler to realise this.
Signed-off-by: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Peter Maydell [Mon, 20 Dec 2010 21:13:32 +0000 (21:13 +0000)]
Fix used-uninitialised warning in new.c
Fix a used-uninitialised warning in new.c by having the check_folders()
routine return first=last=NULL for empty folder lists. This is a more
sensible API anyway. (It would not actually have been possible for
the code to try to use last while it was uninitialised, as it happens.)
Signed-off-by: Peter Maydell <pmaydell@chiark.greenend.org.uk>
Peter Maydell [Mon, 20 Dec 2010 19:54:43 +0000 (19:54 +0000)]
Fix warning in sbr/folder_addmsg.c by code cleanup
Clean up some rather oddly written code in folder_addmsg()
so it is easier to understand for both humans and for the
compiler (and the compiler thus stops complaining about an
uninitialised variable).
Signed-off-by: Peter Maydell <pmaydell@chiark.greenend.org.uk>