markus schnalke [Thu, 5 Jan 2012 18:24:20 +0000 (19:24 +0100)]
Free memory after use in m_draft().
markus schnalke [Thu, 5 Jan 2012 18:18:12 +0000 (19:18 +0100)]
Explicit checks for return values of strcmp().
The return value of strcmp() is unintuitive for string equality tests.
I prefer explicit comparisions against 0. I changed this everywhere.
markus schnalke [Thu, 5 Jan 2012 11:26:09 +0000 (12:26 +0100)]
Removed isprefix() and replaced it with strncmp().
isprefix() had been ssequal(), which had not been what it advertised to be.
Now, all this is gone.
We could get problems if one of the arguments is NULL, as isprefix()
handled this situation, but strncmp() does not. It appears as if this case
does not show up in the code.
markus schnalke [Thu, 5 Jan 2012 10:56:44 +0000 (11:56 +0100)]
Removed forgotten unused variable.
markus schnalke [Thu, 5 Jan 2012 10:52:03 +0000 (11:52 +0100)]
Removed the non-LOCALE character code and the #ifdefs and simplified.
POSIX says: tolower() won't change its argument if it is not isupper().
And isupper() doesn't need an additional check for isalpha().
markus schnalke [Thu, 5 Jan 2012 10:28:18 +0000 (11:28 +0100)]
Refactoring in sbr/m_convert.c
markus schnalke [Thu, 5 Jan 2012 10:19:22 +0000 (11:19 +0100)]
Reserved special sequence names may be upper case too. Even without LOCALE.
markus schnalke [Thu, 5 Jan 2012 10:11:13 +0000 (11:11 +0100)]
Much more straight-forward handling of the beyond sequence.
Could remove the message flag SELECT_EMPTY in the same go.
This frees one more space for a user-defined sequence.
markus schnalke [Wed, 4 Jan 2012 20:04:56 +0000 (21:04 +0100)]
Various minor cleanups in sbr/m_convert.c.
markus schnalke [Wed, 4 Jan 2012 18:36:08 +0000 (19:36 +0100)]
Removed the unused message flag: DELETED.
Now we can store one user-defines seq more.
markus schnalke [Wed, 4 Jan 2012 17:57:18 +0000 (18:57 +0100)]
s/ALLOW_NEW/ALLOW_BEYOND/
markus schnalke [Wed, 4 Jan 2012 17:29:23 +0000 (18:29 +0100)]
Renamed all standard sequences (e.g. cur->c) and made them globally changeable
The full list:
cur -> c
first -> f
last -> l
next -> n
prev -> p
all -> a
new -> b (mnemonic: one beyond the last)
They are globally changeable in config/config.c
Could be that I'll add the old names again, as convenience aliases.
markus schnalke [Wed, 4 Jan 2012 13:49:09 +0000 (14:49 +0100)]
Inverted the second arg of seq_setunseen(), to be more natural.
markus schnalke [Wed, 4 Jan 2012 13:46:58 +0000 (14:46 +0100)]
Another fix for the strchr() transition: Check for NULL arguments.
Is now the point to reintroduce the brkany() helper? Hmm...
markus schnalke [Wed, 4 Jan 2012 11:35:19 +0000 (12:35 +0100)]
Activated default sequence negation (exclamation mark).
markus schnalke [Wed, 4 Jan 2012 11:04:44 +0000 (12:04 +0100)]
Activated a default unseen sequence; updated man pages to it.
markus schnalke [Wed, 4 Jan 2012 10:16:12 +0000 (11:16 +0100)]
Fixed bug in brkstring(), newly introduced by the switch to strchr().
strchr() treats the trailing null byte surprisingly:
``The terminating null byte is considered to be part of the string.''
markus schnalke [Wed, 4 Jan 2012 09:06:51 +0000 (10:06 +0100)]
Globally defined the names for the standard sequences.
I'll rework the whole code to use them and not have hard-coded names anymore.
The `new' sequence will be called `beyond' sequence (`b') from now on.
The `unseen' sequence will be set by default to `u' from now on.
The sequence negation will be set by default to `!' from now on.
markus schnalke [Wed, 4 Jan 2012 08:54:43 +0000 (09:54 +0100)]
sbr/brkstring.c: replaced static brkany() with call to strchr(); plus cleanups
markus schnalke [Tue, 3 Jan 2012 06:14:24 +0000 (07:14 +0100)]
Fixed minor typo in man page.
markus schnalke [Tue, 3 Jan 2012 05:41:27 +0000 (06:41 +0100)]
Removed remaining lines from the --with-pager=... removal, months ago.
markus schnalke [Tue, 3 Jan 2012 05:36:30 +0000 (06:36 +0100)]
s/vfork/fork/
I truly believe that vfork is wrong. Forking should not be too slow for us.
markus schnalke [Tue, 3 Jan 2012 05:16:30 +0000 (06:16 +0100)]
Relayouted all switch statements: case aligns with switch.
Desired style is:
switch (n) {
case foo:
...
}
markus schnalke [Mon, 2 Jan 2012 13:54:05 +0000 (14:54 +0100)]
Removed ``Face'' support in mhl.
It appears to be about `Face:' headers, but neither Jerry Peek, nor
Ken Hornstein knew more.
markus schnalke [Mon, 2 Jan 2012 10:50:35 +0000 (11:50 +0100)]
Removed references to unused default procs and commented config/config.c
markus schnalke [Mon, 2 Jan 2012 10:20:00 +0000 (11:20 +0100)]
Removed the configuration option NOPUBLICSEQ.
You can change it still, by setting mh_seq to NULL in config/config.c.
markus schnalke [Mon, 2 Jan 2012 09:57:24 +0000 (10:57 +0100)]
Renames: s/+outbox/+sent/ and s/cc:/Cc:/
IMO ``sent'' specifies more exactly what it contains. ``outbox'' would
mean to me that these messages are prepared for delivery, but are not
already sent.
markus schnalke [Mon, 2 Jan 2012 09:20:49 +0000 (10:20 +0100)]
Updated INSTALL and changed `nmh' strings to `mmh'
markus schnalke [Fri, 23 Dec 2011 11:09:55 +0000 (12:09 +0100)]
Reworked the man page system and some man page contents (mmh-intro).
Now it's possible to have two equally named pages in two different sections.
This appeared to be interesting for mmh(X), but I don't use it now. Let's
see if we keep the new system or even rework it to become simpler.
markus schnalke [Fri, 23 Dec 2011 08:00:59 +0000 (09:00 +0100)]
Be quiet! Only talk if you have something useful to say.
markus schnalke [Fri, 23 Dec 2011 07:32:41 +0000 (08:32 +0100)]
Adjusted Makefile to the rename: etc/scan.default -> etc/scan.nmh
markus schnalke [Fri, 23 Dec 2011 07:32:08 +0000 (08:32 +0100)]
Updated all man pages and renamed install-mh.man to mmh.man.
markus schnalke [Fri, 23 Dec 2011 07:13:22 +0000 (08:13 +0100)]
Unimportant stuff.
markus schnalke [Fri, 23 Dec 2011 07:12:20 +0000 (08:12 +0100)]
Replaced C program `install-mh' by shell script `mmh'.
It is updated to the separated directories.
markus schnalke [Fri, 23 Dec 2011 07:00:58 +0000 (08:00 +0100)]
Split nmh dir into mmh dir (~/.mmh) and mail storage (~/Mail).
The profile (~/.mh_profile) became (~/.mmh/profile).
The idea was to separate the configuration files and the data (= messages).
The environment variables changed accordingly:
MH -> MMHP (profile)
MHCONTEXT -> MMHC (context)
new: MMH (mmh dir)
mh-install is not adjusted, yet.
markus schnalke [Tue, 13 Dec 2011 13:20:32 +0000 (14:20 +0100)]
Fixed bug, reported by Phil: Profile entry Draft-Folder was case sensitive.
The components in the profile should be matched case*in*sensitive, always.
markus schnalke [Tue, 13 Dec 2011 13:19:40 +0000 (14:19 +0100)]
Cleanup in m_draft. There was some confusingly unnecessary code.
markus schnalke [Tue, 13 Dec 2011 12:10:15 +0000 (13:10 +0100)]
Minor change in output message
markus schnalke [Mon, 12 Dec 2011 13:09:44 +0000 (14:09 +0100)]
Removed the global alias file
Either use personal alias files or the MTA alias file.
markus schnalke [Mon, 12 Dec 2011 12:38:51 +0000 (13:38 +0100)]
Moved etcpath() from config/config.c to sbr/path.c
markus schnalke [Fri, 9 Dec 2011 21:12:34 +0000 (22:12 +0100)]
Code cosmetic
markus schnalke [Fri, 9 Dec 2011 20:56:44 +0000 (21:56 +0100)]
Adjusted the default scan listing: remove the body preview
The original listing is still available as etc/scan.nmh
markus schnalke [Fri, 9 Dec 2011 20:26:54 +0000 (21:26 +0100)]
Code cosmetics
markus schnalke [Fri, 9 Dec 2011 17:44:19 +0000 (18:44 +0100)]
We have `NULL' in order to not need to write `(char *)0' anymore.
markus schnalke [Fri, 9 Dec 2011 17:34:39 +0000 (18:34 +0100)]
Removed void casts for ignored return values of function calls.
IMO, this distracts from the important without being much worth.
markus schnalke [Fri, 9 Dec 2011 17:21:27 +0000 (18:21 +0100)]
We don't want to use copy() anymore; but kept it for concat() only
markus schnalke [Fri, 9 Dec 2011 17:11:10 +0000 (18:11 +0100)]
s/pfolder/curfolder/g
markus schnalke [Fri, 9 Dec 2011 16:32:28 +0000 (17:32 +0100)]
"." is no longer an alias for "cur"
Don't fear more typing, as "cur" will soon be cut down to "c",
likewise the other predefined sequences.
markus schnalke [Fri, 9 Dec 2011 16:17:50 +0000 (17:17 +0100)]
Removed the option to disable `~user' support (MHRC)
markus schnalke [Fri, 9 Dec 2011 15:34:57 +0000 (16:34 +0100)]
Completely reworked the path convertion functions
Moved everything (from sbr/getfolder.c and sbr/m_maildir.c) into
sbr/path.c, but actually replaced the code almost completely.
See h/prototypes.h for the function changes.
sbr/path.c provides explaining comments on the functions.
None of them allocates memory automatically.
Additionally:
- Like for other ``files'', `inc -audit file' places file relative
to the cwd, not relative to the mh-dir. This is for consistency.
- Replaced add(foo, NULL) with getcpy(foo), which ist clearer.
markus schnalke [Mon, 21 Nov 2011 10:29:03 +0000 (11:29 +0100)]
Cosmetic refactoring
markus schnalke [Sun, 20 Nov 2011 20:19:43 +0000 (21:19 +0100)]
Cosmetic change
markus schnalke [Sun, 20 Nov 2011 20:17:44 +0000 (21:17 +0100)]
Cosmetic change
markus schnalke [Sun, 20 Nov 2011 20:14:29 +0000 (21:14 +0100)]
Added comment
markus schnalke [Sun, 20 Nov 2011 20:13:07 +0000 (21:13 +0100)]
Simplification: Removed unnecessary variable
markus schnalke [Sun, 20 Nov 2011 11:38:17 +0000 (12:38 +0100)]
The existence of the profile entry Path is already enforced by context_read().
Hence, removed the obscure ``free(path("./", TFOLDER));'' calls.
Still I don't see the sense in these lines, but they won't get executed,
as the condition is checked before (and the program aborts then).
Probably that's obsolete stuff that remained through several reworks.
markus schnalke [Sat, 5 Nov 2011 18:07:47 +0000 (19:07 +0100)]
Code reformating.
markus schnalke [Sat, 5 Nov 2011 17:40:23 +0000 (18:40 +0100)]
Improved pluspath() and used it instead of path() where appropriate.
markus schnalke [Sat, 5 Nov 2011 17:13:17 +0000 (18:13 +0100)]
Refactored sbr/getfolder.c
markus schnalke [Sat, 5 Nov 2011 16:56:07 +0000 (17:56 +0100)]
Introduced FDEF and FCUR for speaking arguments to getfolder().
Maybe it would be better to two separate functions, but I cannot
imagine good names for them ... :-(
markus schnalke [Sat, 5 Nov 2011 16:51:30 +0000 (17:51 +0100)]
Rearranged code in the file.
markus schnalke [Sat, 5 Nov 2011 16:35:13 +0000 (17:35 +0100)]
Refactoring in sbr/path.c.
Especially: Replaced compath() with a more general packpath().
markus schnalke [Sat, 5 Nov 2011 13:04:02 +0000 (14:04 +0100)]
Renamed r1bindex() to mhbasename(), to make its function becomes clear.
All calls to r1bindex() had '/' as second argument. For everything else
one can use strrchr(3) instead of r1bindex().
markus schnalke [Sat, 5 Nov 2011 10:47:42 +0000 (11:47 +0100)]
Renamed ssequal() to isprefix(), because that's what it checks.
markus schnalke [Sat, 5 Nov 2011 09:31:30 +0000 (10:31 +0100)]
Removed defines for obsolete BSD bcopy functions; Use getc() directly.
markus schnalke [Sat, 5 Nov 2011 09:26:18 +0000 (10:26 +0100)]
We don't need macros for only putting two strings next to each other.
markus schnalke [Sat, 5 Nov 2011 08:43:56 +0000 (09:43 +0100)]
Removed references to bboards, as we don't support them anymore.
markus schnalke [Tue, 1 Nov 2011 14:55:31 +0000 (15:55 +0100)]
Broke long lines.
markus schnalke [Tue, 1 Nov 2011 08:29:08 +0000 (09:29 +0100)]
Don't call writev() anymore.
It might be a sexy syscall, but it's not portable and more complex than
the mainstream solution. For sexy source program, go elsewhere!
markus schnalke [Tue, 1 Nov 2011 08:10:19 +0000 (09:10 +0100)]
Removed outc(), which only called putchar(), while having the same signature.
I substituted all outc() calls with calls to putchar().
markus schnalke [Tue, 1 Nov 2011 08:05:30 +0000 (09:05 +0100)]
Removed the space between function names and the opening parenthesis.
markus schnalke [Mon, 31 Oct 2011 14:06:33 +0000 (15:06 +0100)]
Reformated comments and long lines
markus schnalke [Sun, 30 Oct 2011 10:35:54 +0000 (11:35 +0100)]
Removed the draft message in favor for a consistent draft folder facility
- reworked sbr/m_draft.c (of course)
- removed the -draftfolder/-draftmessage/-nodraftfolder switches
- removed the -draft switch from anno and refile
- no more need to question on existing draft message - yay!
Everything is more consistent now. Cornercases went away. :-)
(Also fixed the switch numbering, as already done for other files earlier.)
markus schnalke [Sun, 16 Oct 2011 17:50:26 +0000 (19:50 +0200)]
Fixed broken swit numbering (there are more files to fix)
markus schnalke [Sun, 16 Oct 2011 09:48:09 +0000 (11:48 +0200)]
Removed the whom program, which relayed on post(8) functionality.
We can later add one again, which only expands aliases but does not
require the MTA to support -bv.
markus schnalke [Sun, 16 Oct 2011 08:47:04 +0000 (10:47 +0200)]
Removed the split feature of send.
It would split large messages into several partial ones, using MIME.
But if a message contains one large file attached, it won't solve the
problem. We better go without this feature and leave it to the user.
markus schnalke [Fri, 7 Oct 2011 08:41:15 +0000 (10:41 +0200)]
Removed unneeded sbr code.
memmove() and strerror() removed again. ;-) Mmh takes C89, at least, for
available.
markus schnalke [Fri, 7 Oct 2011 06:35:27 +0000 (08:35 +0200)]
Rearranged whitespace (and comments) in all the code!
The primary goal was to only indent with tabs and not mix them with spaces.
Also, no more tabs should appear past the first printable char on each line.
Now editing the sources will be much easier, no matter which editor one uses,
and rearranging won't break aligned code.
(Beware, the changeset is huge, but the `diff -w' changes are moderate.)
markus schnalke [Wed, 5 Oct 2011 19:13:58 +0000 (21:13 +0200)]
Removed mhn, as it was already replaced by mhlist/mhshow/mhstore.
markus schnalke [Wed, 5 Oct 2011 17:09:27 +0000 (19:09 +0200)]
Removed msh, vmh and wmh.
The latter ones were long time obsolete; now they went away.
Msh has hardly to do with everyday mmh usage, and we don't support bboards
anymore.
This one changeset saves us about 7,000 lines of code. *yay*
markus schnalke [Wed, 5 Oct 2011 16:21:11 +0000 (18:21 +0200)]
Removed unused and not compiling program wmh.
It was added 1986, and is not even mentioned in nmh's history.
The website is (was?) http://wmh.sf.net
markus schnalke [Wed, 5 Oct 2011 16:14:41 +0000 (18:14 +0200)]
Removed obsolete MTS docs from README.developers
markus schnalke [Wed, 5 Oct 2011 10:29:01 +0000 (12:29 +0200)]
Clarification fix in man/mhparam.man, related to -debug.
markus schnalke [Wed, 5 Oct 2011 10:25:09 +0000 (12:25 +0200)]
Reworked LINK, now named `altmsglink', similar to BACKUP_PREFIX.
markus schnalke [Wed, 5 Oct 2011 09:42:08 +0000 (11:42 +0200)]
Moved default file/folder modes from acconfig.h to config/config.c
markus schnalke [Wed, 5 Oct 2011 09:28:46 +0000 (11:28 +0200)]
Removed --with-{editor,pager} configure options.
We keep defaulting to vi and more, but search in PATH at run time.
Nowadays, both programs should be available via PATH everywhere.
Otherwise, the the path in the profile.
markus schnalke [Wed, 5 Oct 2011 08:22:17 +0000 (10:22 +0200)]
Documented -debug switch or mhparam(1)
markus schnalke [Wed, 5 Oct 2011 07:55:16 +0000 (09:55 +0200)]
Moved sendmail item to better place in man page mh-profile(5)
markus schnalke [Wed, 5 Oct 2011 07:48:37 +0000 (09:48 +0200)]
Removed configure option --with-hash-prefix and moved backup-prefix to profile
markus schnalke [Tue, 4 Oct 2011 19:39:54 +0000 (21:39 +0200)]
Renamed configure.in to the more modern name configure.ac
markus schnalke [Tue, 4 Oct 2011 19:07:22 +0000 (21:07 +0200)]
Nicer structure in summary printing of the configure script.
markus schnalke [Tue, 4 Oct 2011 19:05:33 +0000 (21:05 +0200)]
Moved the sendmail path config line from mts.conf to the MH profile
This another step in getting rid of the mts stuff.
markus schnalke [Tue, 4 Oct 2011 17:04:28 +0000 (19:04 +0200)]
Removed TLS support. We don't need it anymore as we stopped talking SMTP
Libcrypto and thelike went away also, as they were needed only for TLS.
markus schnalke [Tue, 4 Oct 2011 16:53:49 +0000 (18:53 +0200)]
Removed SASL support. We don't need it anymore because we talk SMTP no more
markus schnalke [Tue, 4 Oct 2011 16:36:14 +0000 (18:36 +0200)]
Removed the MTS and post; now we always use /usr/sbin/sendmail -t
Mmh won't talk SMTP (nor POP).
Also moved OfficialName() from /mts/smtp/hosts.c to sbr/addrsbr.c.
markus schnalke [Tue, 4 Oct 2011 14:14:46 +0000 (16:14 +0200)]
Removed --with-smtpservers configure option and thelike
markus schnalke [Tue, 4 Oct 2011 13:27:47 +0000 (15:27 +0200)]
Removed all POP support
To retrieve mail from POP servers use external tools, e.g. fetchmail.
markus schnalke [Wed, 28 Sep 2011 14:17:08 +0000 (16:17 +0200)]
We'll always use sendmail (spost) now
markus schnalke [Wed, 28 Sep 2011 10:00:00 +0000 (12:00 +0200)]
Install to /usr/local/mmh
markus schnalke [Fri, 9 Sep 2011 19:05:43 +0000 (21:05 +0200)]
This is the birth of mmh. :-)