Explicit checks for return values of strcmp().

[mmh] / sbr / seq_read.c

diff --git a/sbr/seq_read.c b/sbr/seq_read.c
index 3a9633e..5707dae 100644 (file)
--- a/sbr/seq_read.c
+++ b/sbr/seq_read.c
@@ -132,11 +132,10 @@ seq_private(struct msgs *mp)
        plen = strlen(mp->foldpath) + 1;
 
        for (np = m_defs; np; np = np->n_next) {
-               if (strncmp(np->n_name, "atr-", alen)==0
-                               && (j = strlen(np->n_name) - plen) > alen
-                               && *(np->n_name + j) == '-'
-                               && strcmp(mp->foldpath, np->n_name + j + 1)
-                               == 0) {
+               if (strncmp(np->n_name, "atr-", alen)==0 &&
+                               (j = strlen(np->n_name) - plen) > alen &&
+                               *(np->n_name + j) == '-' &&
+                               strcmp(mp->foldpath, np->n_name + j + 1)==0) {
                        cp = getcpy(np->n_name + alen);
                        *(cp + j - alen) = '\0';
                        if ((i = seq_init(mp, cp, getcpy(np->n_field))) != -1)
@@ -166,7 +165,7 @@ seq_init(struct msgs *mp, char *name, char *field)
        ** Check if this is the cur sequence,
        ** so we can do some special things.
        */
-       is_current = !strcmp(seq_cur, name);
+       is_current = (strcmp(seq_cur, name)==0);
 
        /*
        ** Search for this sequence name to see if we've seen
@@ -175,7 +174,7 @@ seq_init(struct msgs *mp, char *name, char *field)
        ** mesages in this folder.
        */
        for (i = 0; mp->msgattrs[i]; i++) {
-               if (!strcmp(mp->msgattrs[i], name)) {
+               if (strcmp(mp->msgattrs[i], name)==0) {
                        for (j = mp->lowmsg; j <= mp->hghmsg; j++)
                                clear_sequence(mp, i, j);
                        break;