Explicit checks for return values of strcmp().

[mmh] / uip / aliasbr.c

diff --git a/uip/aliasbr.c b/uip/aliasbr.c
index 07c5e03..85260d8 100644 (file)
--- a/uip/aliasbr.c
+++ b/uip/aliasbr.c
@@ -134,7 +134,8 @@ alias(char *file)
        register struct aka *ak = NULL;
        register FILE *fp;
 
-       if (*file!='/' && (strncmp(file, "./", 2) && strncmp(file, "../", 3)))
+       if (*file!='/' && (strncmp(file, "./", 2)!=0 &&
+                       strncmp(file, "../", 3)!=0))
                file = etcpath(file);
        if ((fp = fopen(file, "r")) == NULL) {
                akerrst = file;
@@ -359,7 +360,7 @@ addgroup(struct aka *ak, char *grp)
                struct passwd *pw;
 #endif /* DBMPWD */
                for (hm = homehead; hm; hm = hm->h_next)
-                       if (!strcmp(hm->h_name, gp)) {
+                       if (strcmp(hm->h_name, gp)==0) {
                                add_aka(ak, hm->h_name);
                                break;
                        }
@@ -420,8 +421,8 @@ addall(struct aka *ak)
                Everyone = EVERYONE;
 
        for (hm = homehead; hm; hm = hm->h_next)
-               if (hm->h_uid > Everyone
-                               && (noshell || strcmp(hm->h_shell, NoShell)))
+               if (hm->h_uid > Everyone && (noshell ||
+                               strcmp(hm->h_shell, NoShell)!=0))
                        add_aka(ak, hm->h_name);
 
        return homehead != NULL;
@@ -466,7 +467,7 @@ add_aka(struct aka *ak, char *pp)
        register struct adr *ad, *ld;
 
        for (ad = ak->ak_addr, ld = NULL; ad; ld = ad, ad = ad->ad_next)
-               if (!strcmp(pp, ad->ad_text))
+               if (strcmp(pp, ad->ad_text)==0)
                        return;
 
        ad = (struct adr *) mh_xmalloc(sizeof(*ad));