Use sysexits.h for better exit-codes

[mmh] / uip / ap.c

diff --git a/uip/ap.c b/uip/ap.c
index a74eb96..af97e9e 100644 (file)
--- a/uip/ap.c
+++ b/uip/ap.c
@@ -10,6 +10,7 @@
 #include <h/addrsbr.h>
 #include <h/fmt_scan.h>
 #include <locale.h>
+#include <sysexits.h>
 
 #define NADDRS 100
 
@@ -62,23 +63,22 @@ main(int argc, char **argv)
                        switch (smatch(++cp, switches)) {
                        case AMBIGSW:
                                ambigsw(cp, switches);
-                               /* sysexits.h EX_USAGE */
-                               exit(1);
+                               exit(EX_USAGE);
 
                        case UNKWNSW:
-                               adios(NULL, "-%s unknown", cp);
+                               adios(EX_USAGE, NULL, "-%s unknown", cp);
 
                        case HELPSW:
                                snprintf(buf, sizeof(buf), "%s [switches] addrs ...", invo_name);
                                print_help(buf, switches, 1);
-                               exit(0);
+                               exit(argc == 2 ? EX_OK : EX_USAGE);
                        case VERSIONSW:
                                print_version(invo_name);
-                               exit(0);
+                               exit(argc == 2 ? EX_OK : EX_USAGE);
 
                        case FORMSW:
                                if (!(form = *argp++) || *form == '-')
-                                       adios(NULL, "missing argument to %s", argp[-2]);
+                                       adios(EX_USAGE, NULL, "missing argument to %s", argp[-2]);
                                continue;
 
                        case NORMSW:
@@ -90,14 +90,14 @@ main(int argc, char **argv)
                        }
                }
                if (addrp > NADDRS)
-                       adios(NULL, "more than %d addresses", NADDRS);
+                       adios(EX_USAGE, NULL, "more than %d addresses", NADDRS);
                else
                        addrs[addrp++] = cp;
        }
        addrs[addrp] = NULL;
 
        if (addrp == 0)
-               adios(NULL, "usage: %s [switches] addrs ...", invo_name);
+               adios(EX_USAGE, NULL, "usage: %s [switches] addrs ...", invo_name);
 
        /* get new format string */
        fmtstr = new_fs(form, FORMAT);
@@ -114,8 +114,7 @@ main(int argc, char **argv)
        for (addrp = 0; addrs[addrp]; addrp++)
                status += process(addrs[addrp], normalize);
 
-       exit(status);
-       return 1;
+       return status;
 }
 
 struct pqpair {
@@ -140,7 +139,7 @@ process(char *arg, int norm)
        while ((cp = getname(arg))) {
                if ((p = (struct pqpair *)
                                calloc((size_t) 1, sizeof(*p))) == NULL)
-                       adios(NULL, "unable to allocate pqpair memory");
+                       adios(EX_OSERR, NULL, "unable to allocate pqpair memory");
                if ((mp = getm(cp, NULL, 0, norm, error)) == NULL) {
                        p->pq_text = getcpy(cp);
                        p->pq_error = getcpy(error);