Explicit checks for return values of strcmp().

[mmh] / uip / conflict.c

diff --git a/uip/conflict.c b/uip/conflict.c
index 82dfdcc..4a20e4b 100644 (file)
--- a/uip/conflict.c
+++ b/uip/conflict.c
@@ -192,7 +192,7 @@ grp_names(void)
        setgrent();
        while ((gr = getgrent())) {
                for (i = 0; i < numgroups; i++)
-                       if (!strcmp(grps[i], gr->gr_name)) {
+                       if (strcmp(grps[i], gr->gr_name)==0) {
                                setup();
                                fprintf(out, "duplicate group %s(gid=%d)\n",
                                                gr->gr_name, (int) gr->gr_gid);
@@ -231,7 +231,7 @@ grp_members(void)
        while ((gr = getgrent())) {
                for (cp = gr->gr_mem; *cp; cp++) {
                        for (hm = homehead; hm; hm = hm->h_next)
-                               if (!strcmp(*cp, hm->h_name))
+                               if (strcmp(*cp, hm->h_name)==0)
                                        break;
                        if (hm == NULL) {
                                setup();
@@ -328,7 +328,7 @@ check(char *s)
        register struct home *hm;
 
        for (hm = homehead; hm; hm = hm->h_next)
-               if (!strcmp(s, hm->h_name))
+               if (strcmp(s, hm->h_name)==0)
                        return 1;
        return 0;
 }