Explicit checks for return values of strcmp().

[mmh] / uip / mhstoresbr.c

diff --git a/uip/mhstoresbr.c b/uip/mhstoresbr.c
index 0afcc99..0b1a9b3 100644 (file)
--- a/uip/mhstoresbr.c
+++ b/uip/mhstoresbr.c
@@ -632,14 +632,15 @@ got_filename:
                if (ct->c_folder) {
                        fprintf(stderr, " to folder %s as message %d\n",
                                        ct->c_folder, msgnum);
-               } else if (!strcmp(ct->c_storage, "-")) {
+               } else if (strcmp(ct->c_storage, "-")==0) {
                        fprintf(stderr, " to stdout\n");
                } else {
                        int cwdlen;
 
                        cwdlen = strlen(cwd);
                        fprintf(stderr, " as file %s\n",
-                                       strncmp(ct->c_storage, cwd, cwdlen) ||
+                                       strncmp(ct->c_storage, cwd,
+                                       cwdlen)!=0 ||
                                        ct->c_storage[cwdlen] != '/' ?
                                        ct->c_storage :
                                        ct->c_storage + cwdlen + 1);
@@ -678,11 +679,11 @@ output_content_file(CT ct, int appending)
                        return NOTOK;
                }
 
-               file = appending || !strcmp(ct->c_storage, "-") ?
+               file = appending || strcmp(ct->c_storage, "-")==0 ?
                                NULL : ct->c_storage;
                if ((fd = (*ct->c_ceopenfnx) (ct, &file)) == NOTOK)
                        return NOTOK;
-               if (!strcmp(file, ct->c_storage)) {
+               if (strcmp(file, ct->c_storage)==0) {
                        (*ct->c_ceclosefnx) (ct);
                        return OK;
                }
@@ -690,7 +691,7 @@ output_content_file(CT ct, int appending)
                /*
                ** Send to standard output
                */
-               if (!strcmp(ct->c_storage, "-")) {
+               if (strcmp(ct->c_storage, "-")==0) {
                        int gd;
 
                        if ((gd = dup(fileno(stdout))) == NOTOK) {
@@ -763,7 +764,7 @@ losing:
        last = ct->c_end;
        fseek(ct->c_fp, pos, SEEK_SET);
 
-       if (!strcmp(ct->c_storage, "-")) {
+       if (strcmp(ct->c_storage, "-")==0) {
                int gd;
 
                if ((gd = dup(fileno(stdout))) == NOTOK) {