10 years ago * uip/.cvsignore: added "new". PRE_POSIX_CONVERSION
David Levine [Tue, 31 Aug 2010 15:00:53 +0000 (15:00 +0000)]
* uip/.cvsignore:  added "new".

10 years ago#ifdef AI_ADDRCONFIG since older IPv4-only systems may not define this flag,
Earl Hood [Sat, 6 Feb 2010 07:47:38 +0000 (07:47 +0000)]
#ifdef AI_ADDRCONFIG since older IPv4-only systems may not define this flag,
causing files that use to not compile.

10 years agoFixed variable declaration so older compilers will not complain.
Earl Hood [Sat, 6 Feb 2010 07:45:47 +0000 (07:45 +0000)]
Fixed variable declaration so older compilers will not complain.
I.e. Older compilers may not support C99, so variables must be
declared at the beginning of a block.

10 years ago* Bug #15213, #18635: The use of the insecure m_scratch() and
Earl Hood [Thu, 4 Feb 2010 01:39:21 +0000 (01:39 +0000)]
* Bug #15213, #18635: The use of the insecure m_scratch() and
  m_tmpfil() functions have been replaced by m_mktemp()
  or m_mktemp2() functions (defined in sbr/m_mktemp.c).
  The new functions use mkstemp() to securely create
  temporary files to avoid the numerous race conditions
  that exist with the old functions.  This does assume
  that mkstemp() is available.  Unsure if we need to
  create an alternative implementation if mkstemp() is
  not available.  More information about new temp file
  functions in m_mktemp.c, including the support for
  MHTMPDIR, TMPDIR, and TMP envvars.

NOTE: The files sbr/m_scratch.c and sbr/m_tmpfil.c should be removed.
Until more testing verifies changes to support new functions have not
broken functionality, the files are be left in the tree, but comments
have been added stating the functions in them should not be called.

10 years ago* mts/smtp/smtp.c: added SASL support if mts configuration
Earl Hood [Wed, 3 Feb 2010 05:56:56 +0000 (05:56 +0000)]
* mts/smtp/smtp.c: added SASL support if mts configuration
  setting is set to "sendmail".  This is useful if sendmail
  conf option is to a custom script that creates a proxy
  connection to an smtp server.

* sbr/mts.c: added support for MHMTSCONF and MHMTSUSERCONF
  envvars.  The former specifies an alternative system
  mts.conf to use.  The later specifies a user-specific
  mts.conf to use.  This one will be read after the system
  conf, so the user's conf only needs to set options they
  want to override.  The MHMTSUSERCONF allows a user to set
  personal alternative mail submission methods w/o affecting
  other users on the system.

* uip/whom.c: added SASL-based options so address checking
  can work against a server that requires SASL.

10 years ago * uip/mhlistsbr.c, uip/mhlsbr.c, uip/picksbr.c: cast
David Levine [Wed, 30 Dec 2009 01:42:45 +0000 (01:42 +0000)]
* uip/mhlistsbr.c, uip/mhlsbr.c, uip/picksbr.c: cast
pointers to unsigned long before casting to unsigned int
to avoid warnings on 64-bit about casting from pointer
to int of different size.

10 years ago * uip/new.c: cast folder_len to int to avoid warning on
David Levine [Wed, 30 Dec 2009 01:41:47 +0000 (01:41 +0000)]
* uip/new.c: cast folder_len to int to avoid warning on
64-bit about passing a size_t to an int conversion specifier.

10 years ago * uip/inc.c: gcc 4.4.1 noticed that maildir could have been
David Levine [Fri, 25 Dec 2009 14:47:39 +0000 (14:47 +0000)]
* uip/inc.c: gcc 4.4.1 noticed that maildir could have been
used before initialization.  In fact, if that code was ever
reached, maildir would never have been initialized.  It's in
an adios call, so replaced with NULL.

10 years ago* mts/smtp/smtp.c: In sm_auth_sasl (), removed zeroing of
David Levine [Mon, 21 Dec 2009 17:18:04 +0000 (17:18 +0000)]
* mts/smtp/smtp.c: In sm_auth_sasl (), removed zeroing of
sasl_inbuffer because it could be used in sm_fget ().  Also,
removed allocation of sasl_inbuffer because that was done in
either smtp_init () or sendmail_init ().

11 years agoRemove duplicate sm_fgetc() declaration
Josh Bressers [Mon, 26 Jan 2009 13:38:13 +0000 (13:38 +0000)]
Remove duplicate sm_fgetc() declaration

11 years agoFix warning in getaddrinfo() call.
Ken Hornstein [Wed, 21 Jan 2009 19:38:36 +0000 (19:38 +0000)]
Fix warning in getaddrinfo() call.
Add missing support for -port in whatnow.
Make sure the SASL input buffer is allocated when using the sendmail mts.

11 years ago * etc/ Never try to make mhshow start xterm.
Eric Gillespie [Sun, 18 Jan 2009 04:48:42 +0000 (04:48 +0000)]
* etc/ Never try to make mhshow start xterm.

11 years agoNote 'new' commands.
Eric Gillespie [Sat, 17 Jan 2009 16:53:07 +0000 (16:53 +0000)]
Note 'new' commands.

11 years ago * test/runtest, test/tests/inc/test-deb359167,
Eric Gillespie [Sat, 17 Jan 2009 16:47:29 +0000 (16:47 +0000)]
* test/runtest, test/tests/inc/test-deb359167,
test/tests/inc/test-eom-align, test/tests/manpages/test-manpages:
Load via absolute path, otherwise some /bin/sh
(e.g. dash) can't load it.

* uip/, uip/new.c, test/tests/new/test-basic: Add new
program, and fn/fp/unseen symlinks.

* test/{runtest,setup-test}: Move MH profile under Mail directory
so each test script will have its own to muck with, if needed.

* h/, h/crawl_folders.h, sbr/,
sbr/crawl_folders.c, uip/folder.c: Extract the folder crawling
code from folder.c into new crawl_folders function, using a
callback to assemble the folder info in folder.c.  Drop compare
function and use strcmp instead.  Rename addfold and addir to
add_folder and add_children (add dir vs. add folder?
confusing names).

11 years agoMove freeaddrinfo() to inside of our loop; this prevents a memory leak
Ken Hornstein [Fri, 16 Jan 2009 15:48:09 +0000 (15:48 +0000)]
Move freeaddrinfo() to inside of our loop; this prevents a memory leak
and also prevents it from being called with a NULL pointer.

11 years agoMassive overhaul of networking code. Changes:
Ken Hornstein [Fri, 16 Jan 2009 02:28:54 +0000 (02:28 +0000)]
Massive overhaul of networking code.  Changes:

- All networking interfaces now converted to new APIs (getaddrinfo() and
  the like).  All networking now supports IPv6 (with the exception of
  the built-in FTP client).
- SASL security layers are now supported for SMTP.
- Command-line and profile-based selection of the SMTP server and port.

11 years ago* sbr/m_getfld.c: fix two bugs which could cause us to walk off
Peter Maydell [Fri, 26 Dec 2008 21:54:19 +0000 (21:54 +0000)]
* sbr/m_getfld.c: fix two bugs which could cause us to walk off
the beginning of the stdio or prefix-string buffer when checking
for presence of the end-of-message delimiter in some situations.
This might cause inc to dump core if you were unlucky. (This was
Debian bug 359167.)
* test/tests/inc/{md5sums,msgheader.txt,test-deb359167,
test-eom-align,fromline.txt,filler.txt,deb359167.mbox}: new tests
both for the specific problem and to try to check various alignments
of the eom string with the stdio buffer ending.
* test/ Added some functions for doing progress indicators.

11 years agotest/ new file for common utility functions for the test scripts.
Peter Maydell [Fri, 26 Dec 2008 16:32:07 +0000 (16:32 +0000)]
test/ new file for common utility functions for the test scripts.
Moved findprog out of manpage test script into this new file.

11 years agotest/runtest: automatically run setup-test if it hasn't already
Peter Maydell [Thu, 25 Dec 2008 23:30:33 +0000 (23:30 +0000)]
test/runtest: automatically run setup-test if it hasn't already
been done. Improve error handling in test script with 'set -e'.

11 years ago * h/mh.h: raised NAMESZ from 128 to 999. RFC 2822 limits line
David Levine [Thu, 23 Oct 2008 18:38:22 +0000 (18:38 +0000)]
* h/mh.h: raised NAMESZ from 128 to 999.  RFC 2822 limits line
lengths to 998 characters, so a header name can be at most that long.
m_getfld limits header names to 2 less than NAMESZ, which is fine,
because header names must be followed by a colon.  Add one for
terminating NULL.

11 years ago * sbr/m_getfld.c: in warning message, use NAMESZ-2 instead of
David Levine [Thu, 23 Oct 2008 18:14:52 +0000 (18:14 +0000)]
* sbr/m_getfld.c: in warning message, use NAMESZ-2 instead of
NAMESZ-1 bytes because the message says "exceeds", not
"is greater than or equal to".

11 years ago * docs/MAIL.FILTERING: added note on removing procmail -f or
David Levine [Thu, 23 Oct 2008 16:45:36 +0000 (16:45 +0000)]
* docs/MAIL.FILTERING: added note on removing procmail -f or
-r options to try to suppress generation of a "From " line on
incoming messages.

12 years
Eric Gillespie [Tue, 19 Aug 2008 04:36:42 +0000 (04:36 +0000)]

12 years ago * test/setup-test: Don't run unless needed. Build in a
Eric Gillespie [Thu, 14 Aug 2008 19:47:29 +0000 (19:47 +0000)]
* test/setup-test: Don't run unless needed.  Build in a
blddir under the temporary directory so as not to interfere with
whatever the developer may be doing in the source directory.
If the temporary directory already exists, rebuild and install it.

12 years agoThis is what happens with last-minute "safe" improvements: actually point
Eric Gillespie [Thu, 14 Aug 2008 06:19:08 +0000 (06:19 +0000)]
This is what happens with last-minute "safe" improvements: actually point
chset to something in the new merged InitText!

12 years ago * sbr/ambigsw.c: Send print_sw output to stderr. This avoids
Eric Gillespie [Thu, 14 Aug 2008 01:50:45 +0000 (01:50 +0000)]
* sbr/ambigsw.c: Send print_sw output to stderr.  This avoids
strange problems with scan `pick -bogus`, not to mention being
nicer anyway.

* sbr/getans.c, sbr/print_help.c, uip/msh.c: Send print_sw output
to stdout.

* h/prototypes.h, sbr/print_sw.c (print_sw): Add FILE * argument
and send output there rather than to stdout.

* test/tests/pick/test-stderr: Add test that error messages don't
end up going to stdout.

12 years ago * uip/pick.c: Ensure valid sequence name as soon as we parse it from
Eric Gillespie [Thu, 14 Aug 2008 01:31:11 +0000 (01:31 +0000)]
* uip/pick.c: Ensure valid sequence name as soon as we parse it from
command, instead of searching the messages first.

12 years ago * uip/pick.c: Print matching messages immediately, instead of
Eric Gillespie [Thu, 14 Aug 2008 01:28:56 +0000 (01:28 +0000)]
* uip/pick.c: Print matching messages immediately, instead of
waiting until the very end to print anything.

12 years ago * uip/, uip/popi.c: Remove popi.c, which has been dead
Eric Gillespie [Thu, 14 Aug 2008 01:11:12 +0000 (01:11 +0000)]
* uip/, uip/popi.c: Remove popi.c, which has been dead
since PatchSet 257 (2000/06/12 11:07:34 UTC).

12 years ago * h/mhparse.h: Move interfaces also used by mhbuildsbr.c here
Eric Gillespie [Thu, 14 Aug 2008 00:56:38 +0000 (00:56 +0000)]
* h/mhparse.h: Move interfaces also used by mhbuildsbr.c here
from mhparse.c.

* uip/ (mhbuild): Build with mhparse.o.

* uip/mhbuildsbr.c: Drop the duplication of mhparse.c.

* uip/mhbuild.c, uip/mhlist.c, uip/mhn.c, uip/mhshow.c,
uip/mhstore.c, uip/mhtest.c: Drop check swdeclaration, which is
now in mhparse.h.

* uip/mhparse.c: Move some declarations to mhparse.h, and remove
'static' from the definitions here.
(get_ctinfo): Take magic mhbuild support from mhbuildsbr.c's copy,
and adapt callers.
(incl_name_value, extract_name_value): Move from mhbuildsbr.c to
support get_ctinfo change).
(get_content, open7Bit): Add Content-Disposition support, added to
mhbuildsbr.c's copy in mhbuildsbr.c r1.12 (PatchSet 549).
(InitText): Default to CHARSET_UNSPECIFIED instead of "US-ASCII",
as mhbuildsbr.c's copy did.  Explain termproc.
(openBase64, openQuoted, open7Bit): Fix comment from r1.5:
suffixes, not prefixes.
(openMail): Explain showproc.

* test/tests/mhshow/test-cte-binary: Add test for
Content-Transfer-Encoding: binary (Debian #136976).

* test/tests/mhbuild/test-forw: Add an mhbuild test, testing forw
with and without RFC-934 mode.  More mhbuild tests would be nice.

12 years agoOops, meant to use $failed (number of failed checks) as the exit code.
Eric Gillespie [Wed, 13 Aug 2008 23:59:56 +0000 (23:59 +0000)]
Oops, meant to use $failed (number of failed checks) as the exit code.

12 years agoAdd descriptive headers, as other tests have.
Eric Gillespie [Wed, 13 Aug 2008 23:32:03 +0000 (23:32 +0000)]
Add descriptive headers, as other tests have.

12 years ago * test/tests/bad-input/test-header: Add test for it.
Eric Gillespie [Wed, 13 Aug 2008 18:27:36 +0000 (18:27 +0000)]
* test/tests/bad-input/test-header: Add test for it.

* sbr/m_getfld.c: If we reach the end of the line without finding
a ':' when parsing a header field, treat that line as the
beginning of the body rather than blowing up.  These messages are
usually spam, but it's nice to be able to at least scan them.

12 years ago * test/tests/mhshow/test-qp: Test various valid and invalid
Eric Gillespie [Wed, 13 Aug 2008 01:01:12 +0000 (01:01 +0000)]
* test/tests/mhshow/test-qp: Test various valid and invalid
escape sequences.

* uip/mhparse.c (openQuoted): Simplify the decode-or-show for loop by
peeking ahead to the next byte(s) when encountering '=', and just let
invalid escape sequences through as literals (fixes bug #15245).

12 years agoIgnore test-temp-dir.
Eric Gillespie [Wed, 13 Aug 2008 01:00:20 +0000 (01:00 +0000)]
Ignore test-temp-dir.

12 years agoadd one more hint for developers, to explicitly point at docs/README.developers
Paul Fox [Tue, 12 Aug 2008 21:01:30 +0000 (21:01 +0000)]
add one more hint for developers, to explicitly point at docs/README.developers

12 years (new file): add script for running the GNU autotools in the
Peter Maydell [Tue, 12 Aug 2008 18:04:29 +0000 (18:04 +0000)] (new file): add script for running the GNU autotools in the
right order. Mention and use new script in the appropriate places.

12 years ago * sbr/discard.c, sbr/m_getfld.c, uip/scansbr.c: Add support for
Eric Gillespie [Fri, 8 Aug 2008 23:45:24 +0000 (23:45 +0000)]
* sbr/discard.c, sbr/m_getfld.c, uip/scansbr.c: Add support for
DragonFlyBSD stdio (from NetBSD pkgsrc).

12 years agos/ls/cd/ in comment (probably pasted from test-ls)
Eric Gillespie [Fri, 8 Aug 2008 04:45:05 +0000 (04:45 +0000)]
s/ls/cd/ in comment (probably pasted from test-ls)

12 years agouip/folder.c: chdir(nmhdir) in main rather than in dodir, which
Peter Maydell [Tue, 5 Aug 2008 21:06:00 +0000 (21:06 +0000)]
uip/folder.c: chdir(nmhdir) in main rather than in dodir, which
is called many times.  Drop the chdir in get_folder_info, which
served no purpose at all.  If struct stat has d_type (BSD), use
that to skip processing (strcmp, stat, and so on) of message
files, mostly undoing the slow-down from the last change.
Plus autoconf machinery to detect d_type field. Patch from Eric Gillespie.

12 years agoDump hacky overoptimisation in addir -- it doesn't actually get the case
Peter Maydell [Tue, 5 Aug 2008 19:09:03 +0000 (19:09 +0000)]
Dump hacky overoptimisation in addir -- it doesn't actually get the case
of symlinks to directories right. Patch from Eric Gillespie.

12 years agoSimplify dodir/addir/addfold (patch from Eric Gillespie)
Peter Maydell [Tue, 5 Aug 2008 19:05:23 +0000 (19:05 +0000)]
Simplify dodir/addir/addfold (patch from Eric Gillespie)

12 years agobug #23319: rework the way we handle the working directory when invoking
Peter Maydell [Sun, 3 Aug 2008 18:47:56 +0000 (18:47 +0000)]
bug #23319: rework the way we handle the working directory when invoking
the user's shell, so that we don't have issues when the cwd contains a
space or shell special character.

12 years agotest/setup-test: use 'set -e' so we stop on compile failure.
Peter Maydell [Sun, 3 Aug 2008 18:45:34 +0000 (18:45 +0000)]
test/setup-test: use 'set -e' so we stop on compile failure.
Configure --enable-debug for convenience in debugging.

12 years agoAdd protective 'do { ... } while (0)' wrappers to multistatement macros
Peter Maydell [Sun, 3 Aug 2008 15:19:53 +0000 (15:19 +0000)]
Add protective 'do { ... } while (0)' wrappers to multistatement macros

12 years agoBug #23436: fix some minor manpage syntax errors and add a test which runs
Peter Maydell [Sun, 3 Aug 2008 15:14:23 +0000 (15:14 +0000)]
Bug #23436: fix some minor manpage syntax errors and add a test which runs
groff over them and checks that no warnings are emitted.

12 years agoAllow tests to indicate that they have been skipped by printing their
Peter Maydell [Sun, 3 Aug 2008 15:13:34 +0000 (15:13 +0000)]
Allow tests to indicate that they have been skipped by printing their
own message and returning with exit status 120.

12 years agoIgnore editor backup files
Peter Maydell [Sun, 3 Aug 2008 13:59:19 +0000 (13:59 +0000)]
Ignore editor backup files

12 years agoetc/replcomps, etc/replgroupcomps: Trim trailing whitespace from
Peter Maydell [Sun, 3 Aug 2008 13:54:37 +0000 (13:54 +0000)]
etc/replcomps, etc/replgroupcomps: Trim trailing whitespace from
Subject field (patch from Eric Gillespie)

12 years agoWhen doing an if-test on the result of a function which returns a string
Peter Maydell [Sun, 3 Aug 2008 13:32:17 +0000 (13:32 +0000)]
When doing an if-test on the result of a function which returns a string
result, check whether the string is non-empty (as the documentation says we
do). Previously we were always testing the integer 'value'.

12 years ago* test/setup-test: Run 'make clean' before building
Josh Bressers [Fri, 25 Jul 2008 01:07:39 +0000 (01:07 +0000)]
* test/setup-test: Run 'make clean' before building

12 years ago* test/runtest: cat test-temp-dir only once. Destroy and create
Josh Bressers [Fri, 25 Jul 2008 00:11:53 +0000 (00:11 +0000)]
* test/runtest: cat test-temp-dir only once.  Destroy and create
test Mail hierarchy here, so each test has its own independent
test data.

* test/setup-test: Drop needless pushd/popd, which don't exist in
sh anyway.  Don't use aclocal, which is part of automake.
Don't create Mail hierarchy here (see test/runtest).

* test/tests/folder/test-create, tests/folder/test-total: Drop
unused BINDIR.

* tests/pick/test-pick: Remove failing no-op test.

* test/tests/scan/test-scan: Write expected and actual output to
files and diff them.  This way, if the output differs, diff
provides the FAILing exit code and shows the differences.

12 years ago* man/, etc/mhl.reply:
Josh Bressers [Fri, 13 Jun 2008 00:11:49 +0000 (00:11 +0000)]
* man/, etc/mhl.reply:
Add an attribution line when replying to messages.

12 years agoRemove an accidentally committed file
Josh Bressers [Thu, 12 Jun 2008 23:29:16 +0000 (23:29 +0000)]
Remove an accidentally committed file

12 years agoWhen building on gcc, use noreturn attribute on adios and the various done
Peter Maydell [Mon, 2 Jun 2008 22:37:01 +0000 (22:37 +0000)]
When building on gcc, use noreturn attribute on adios and the various done

12 years agoBack out previous, completely broken, change (due to a foulup I was
Peter Maydell [Mon, 2 Jun 2008 22:05:11 +0000 (22:05 +0000)]
Back out previous, completely broken, change (due to a foulup I was
compiling a different tree to the one I was committing to CVS).

12 years agoIf we're compiling with gcc, mark adios() as never returning (better code
Peter Maydell [Mon, 2 Jun 2008 21:49:07 +0000 (21:49 +0000)]
If we're compiling with gcc, mark adios() as never returning (better code
and fewer spurious 'uninitialized variable) warnings)

12 years agoUpdate bit of docs about release announcements.
Peter Maydell [Sun, 1 Jun 2008 16:50:22 +0000 (16:50 +0000)]
Update bit of docs about release announcements.

12 years agoDon't use MB_CUR_MAX if we aren't compiled with multibyte support.
Peter Maydell [Thu, 22 May 2008 10:37:55 +0000 (10:37 +0000)]
Don't use MB_CUR_MAX if we aren't compiled with multibyte support.

12 years agoFactor out common code for writing ls shell command. Rework its length
Peter Maydell [Thu, 22 May 2008 10:21:48 +0000 (10:21 +0000)]
Factor out common code for writing ls shell command. Rework its length
checking so it doesn't rely on the return value of sprintf(), for the
benefit of SunOS 4.

12 years agoDon't rely on realloc() to follow POSIX in handling a NULL pointer
Peter Maydell [Wed, 21 May 2008 18:05:49 +0000 (18:05 +0000)]
Don't rely on realloc() to follow POSIX in handling a NULL pointer

12 years agoAdd some table size declarations for the benefit of elderly lexes with
Peter Maydell [Wed, 21 May 2008 17:16:44 +0000 (17:16 +0000)]
Add some table size declarations for the benefit of elderly lexes with
small defaults (eg SunOS 4)

12 years agoUpdate comment now we don't use lex -o.
Peter Maydell [Tue, 20 May 2008 19:04:57 +0000 (19:04 +0000)]
Update comment now we don't use lex -o.

12 years ago* sbr/addrsbr.c: removed "err" from conditional, because gcc
David Levine [Sun, 18 May 2008 13:56:58 +0000 (13:56 +0000)]
* sbr/addrsbr.c: removed "err" from conditional, because gcc
correctly warned that it would always evaluate as true.  It's
the address of a static array.

12 years agodon't use $< in target rules in makefiles, as POSIX says it's only defined
Oliver Kiddle [Fri, 16 May 2008 15:31:26 +0000 (15:31 +0000)]
don't use $< in target rules in makefiles, as POSIX says it's only defined
in inference rules

12 years ago*, INSTALL: if --enable-masquerade is not
David Levine [Tue, 13 May 2008 02:39:04 +0000 (02:39 +0000)]
*, INSTALL: if --enable-masquerade is not
specified to configure, enable all supported masquerade forms.
This allows users to masquerade with the default
configuration. That seems to be more worthwhile now than
trying to prevent users from using it, especially with
single-user installations or those where a user can edit

12 years agobug #23167: sbr/ruserpass.c (ruserpass): make bad permissions on .netrc be
Peter Maydell [Sun, 4 May 2008 20:58:35 +0000 (20:58 +0000)]
bug #23167: sbr/ruserpass.c (ruserpass): make bad permissions on .netrc be
an instantly fatal error. Previously we returned an error value; however, no
caller was checking it. So now ruserpass() has a void return type.

12 years ago* bug #23163: various minor fixes for the benefit of older Unixes
Peter Maydell [Sun, 4 May 2008 16:09:08 +0000 (16:09 +0000)]
* bug #23163: various minor fixes for the benefit of older Unixes
(specifically SunOS 4): reintroduce strerror() substitute implementation;
provide memmove() substitute implementation
* bug #23163: fix broken 'build outside source directory' feature
* bug #23162: sbr/dtime.c: fix stray HAVE_TM_GMTOFF that wasn't updated
to the new macro name.

12 years agoProvide SASL_CB_AUTHNAME callback (avoids problem with wrong username
Peter Maydell [Wed, 30 Apr 2008 18:47:02 +0000 (18:47 +0000)]
Provide SASL_CB_AUTHNAME callback (avoids problem with wrong username
being sent in some situations)

12 years agoCorrect various places in smtp.c where the reply string might not have been
Peter Maydell [Tue, 29 Apr 2008 21:05:30 +0000 (21:05 +0000)]
Correct various places in smtp.c where the reply string might not have been
correctly NUL-terminated. Includes a fix for a particularly nasty and long
standing screwup where the buffer length counting in smhear() was totally
broken for continued lines from the server.

12 years agoFix SASL issue properly, by making sm_rrecord() and thus sm_hear() set
Peter Maydell [Tue, 29 Apr 2008 20:59:04 +0000 (20:59 +0000)]
Fix SASL issue properly, by making sm_rrecord() and thus sm_hear() set
the length of the reply string correctly (the SASL libraries now care
if you pass in the wrong length).

12 years agoRevert previous SASL fix (wrong approach)
Peter Maydell [Tue, 29 Apr 2008 20:53:33 +0000 (20:53 +0000)]
Revert previous SASL fix (wrong approach)

12 years agoCope with sasl_decode64() returning SASL_CONTINUE as well as SASL_OK.
Peter Maydell [Tue, 29 Apr 2008 17:04:38 +0000 (17:04 +0000)]
Cope with sasl_decode64() returning SASL_CONTINUE as well as SASL_OK.

12 years agoAdd remark about how to update the homepage.
Peter Maydell [Mon, 28 Apr 2008 21:13:53 +0000 (21:13 +0000)]
Add remark about how to update the homepage.

12 years agoUpdate some of the 'how to do a release' documentation
Peter Maydell [Sun, 27 Apr 2008 20:58:50 +0000 (20:58 +0000)]
Update some of the 'how to do a release' documentation

12 years agoUp version string to 1.3-dev for the CVS trunk.
Peter Maydell [Sun, 27 Apr 2008 20:55:28 +0000 (20:55 +0000)]
Up version string to 1.3-dev for the CVS trunk.

12 years agoUse hyphen, not plus (corresponding to previous RCx naming convention) nmh-1_3_RC1
Peter Maydell [Sun, 27 Apr 2008 19:54:37 +0000 (19:54 +0000)]
Use hyphen, not plus (corresponding to previous RCx naming convention)

12 years agoBump version number, date for release of 1.3 RC1
Peter Maydell [Sun, 27 Apr 2008 19:44:58 +0000 (19:44 +0000)]
Bump version number, date for release of 1.3 RC1

12 years agomove most remaining macros out of acconfig.h which is an obsolete feature of
Oliver Kiddle [Fri, 11 Apr 2008 14:12:54 +0000 (14:12 +0000)]
move most remaining macros out of acconfig.h which is an obsolete feature of

12 years ago* bug #18655: fix use of admonish() for a fatal error (should
Peter Maydell [Sat, 5 Apr 2008 19:04:41 +0000 (19:04 +0000)]
* bug #18655: fix use of admonish() for a fatal error (should
be adios(); only actual effect would be wrong exit code).
Thanks to Craig Leres for spotting this.

12 years agoBug #20028 (Debian bug 399271): fix code assuming that pointer
Peter Maydell [Sat, 5 Apr 2008 18:41:37 +0000 (18:41 +0000)]
Bug #20028 (Debian bug 399271): fix code assuming that pointer
differences were 32 bits -- thanks to Dean Gaudet for the patch.

12 years ago* uip/mhshowsbr.c (show_all_messages): Be more generous when parsing
Josh Bressers [Fri, 25 Jan 2008 21:00:42 +0000 (21:00 +0000)]
* uip/mhshowsbr.c (show_all_messages): Be more generous when parsing
    multipart messages.

12 years agoInsert types for args of some function pointers to improve type checking.
Joel Reicher [Thu, 8 Nov 2007 02:28:38 +0000 (02:28 +0000)]
Insert types for args of some function pointers to improve type checking.

12 years agoReturn type of (*done)() changed to void. default_done() replaced by
Joel Reicher [Sun, 4 Nov 2007 11:54:32 +0000 (11:54 +0000)]
Return type of (*done)() changed to void. default_done() replaced by
exit(). All dead code "return 1" lines removed from *_done()s and replaced
by explicit "return 1" following done() calls in main()s (they should
never be reached). This should make cleaning up program termination
structures easier.

12 years agoRefactor cts pointer and free()ing on abnormal exit of associated list
Joel Reicher [Sun, 4 Nov 2007 08:52:17 +0000 (08:52 +0000)]
Refactor cts pointer and free()ing on abnormal exit of associated list
into mhfree.c, eliminating duplication.

12 years agoChange link-time overriding of done() to run-time reassigning of equivalent
Joel Reicher [Sun, 4 Nov 2007 04:47:17 +0000 (04:47 +0000)]
Change link-time overriding of done() to run-time reassigning of equivalent
(*done)(). This should make changing the return type of done and the
rationalisation of exit code easier.

13 years ago The MH web site is now and the MH
Bill Wohler [Mon, 24 Sep 2007 07:02:03 +0000 (07:02 +0000)]
  The MH web site is now and the MH
  book is now at

  Changed Questions

1.02 ...current version? mailutils 1.2
1.03 Where can I get MH? Debian 4.0 nmh 1.1-RC4, update links, mu 1.2
1.04 ...references for MH? Refer to SourceForge
1.06 How...print a MH manual? Refer to SourceForge
2.17 MH on a Mac? Use fink
4.05 to archive MH? Mention swish++, mairix, and namazu

13 years ago* Red Hat Bug #253342: inc.c, utils.c, utils.h: When inc is run with the
Josh Bressers [Tue, 21 Aug 2007 21:19:39 +0000 (21:19 +0000)]
* Red Hat Bug #253342: inc.c, utils.c, utils.h: When inc is run with the
-silent flag, don't exit(1) for no apparent reason.

13 years agoRename functions to avoid clash with C library exp2().
Peter Maydell [Sun, 29 Apr 2007 22:57:36 +0000 (22:57 +0000)]
Rename functions to avoid clash with C library exp2().

13 years agoSuppress 'uninitialised variable' warning.
Peter Maydell [Sun, 29 Apr 2007 22:34:04 +0000 (22:34 +0000)]
Suppress 'uninitialised variable' warning.

13 years agoOn Linux, define _GNU_SOURCE so that GNU libc exposes the wcwidth()
Peter Maydell [Sun, 29 Apr 2007 22:05:02 +0000 (22:05 +0000)]
On Linux, define _GNU_SOURCE so that GNU libc exposes the wcwidth()
prototype in wchar.h.

13 years agoChange name of internal function to avoid potential conflicts with GNU
Peter Maydell [Sun, 29 Apr 2007 22:01:04 +0000 (22:01 +0000)]
Change name of internal function to avoid potential conflicts with GNU
libc's getline() function.

13 years agoMinor rearrangement so variables/functions used only if !HAVE_LIBLOCKFILE
Peter Maydell [Sun, 29 Apr 2007 20:49:32 +0000 (20:49 +0000)]
Minor rearrangement so variables/functions used only if !HAVE_LIBLOCKFILE
are also declared only in that case.

13 years agoFor gcc, make the default CFLAGS include -Wno-pointer-sign if the compiler
Peter Maydell [Sun, 29 Apr 2007 19:36:14 +0000 (19:36 +0000)]
For gcc, make the default CFLAGS include -Wno-pointer-sign if the compiler
recognises it. gcc 4 now by default produces a large volume of these
warnings, which I believe are probably spurious and definitely a lot of
work to go through and fix. So we suppress them for now so that the other
warnings are more easily visible.

13 years agobuffer is compared with cp, and so needs to be changed to unsigned too.
Joel Reicher [Tue, 17 Apr 2007 04:53:54 +0000 (04:53 +0000)]
buffer is compared with cp, and so needs to be changed to unsigned too.

13 years agoInitial checkin of a testsuite
Josh Bressers [Tue, 17 Apr 2007 01:02:08 +0000 (01:02 +0000)]
Initial checkin of a testsuite

13 years agoChange all chars being passed to the ctype macros (isalph(), etc.) to
Joel Reicher [Fri, 13 Apr 2007 11:53:08 +0000 (11:53 +0000)]
Change all chars being passed to the ctype macros (isalph(), etc.) to
be unsigned chars, following through to change any other types as
necessary (e.g. comparison between two pointers). Not all chars have
been changed to unsigned chars; just those that were in danger of being
sign extended when passed to the int-taking ctype macros.

13 years agoWe're not using the .Bu macro anymore.
Joel Reicher [Tue, 10 Apr 2007 22:12:26 +0000 (22:12 +0000)]
We're not using the .Bu macro anymore.

13 years agoFix for bug #11139: mhl -form mhl.reply omits '> ' on some lines.
Joel Reicher [Tue, 10 Apr 2007 06:13:27 +0000 (06:13 +0000)]
Fix for bug #11139: mhl -form mhl.reply omits '> ' on some lines.

putcomp() was assuming only the first call on the body had the buffer
beginning at the start of a line.

13 years agoApplication of patch #5218: patch for bug #9742. Fixes a typo in the
Joel Reicher [Tue, 10 Apr 2007 03:32:48 +0000 (03:32 +0000)]
Application of patch #5218: patch for bug #9742. Fixes a typo in the
size arg of snprintf(). mhlist output which used to have incorrect lines
such as
     1.2   multipart/mixed            772
     1.21  text/plain                   9
     1.22  multipart/mixed            162
now have the correct
     1.2   multipart/mixed            772
     1.2.1 text/plain                   9
     1.2.2 multipart/mixed            162