mmh
9 years agoRemoved -format and -filter from send(1); they were just passed to (s)post(8).
markus schnalke [Thu, 9 Feb 2012 16:38:27 +0000 (17:38 +0100)]
Removed -format and -filter from send(1); they were just passed to (s)post(8).
-(no)format switches normalization of addresses on/off. If spost would
support address normalization, then it should be always enabled or disabled.
But as spost doesn't support it it's a no-op in mmh anyway.
-filter is for generating non-MIME messages for Bcc recipients. We'll use
MIME in this case ... as soon as this code is written.
Note: spost is still lagging behind the current development.

9 years agorepl: renamed -noformat to -nofilter; removed -format; default to -filter.
markus schnalke [Thu, 9 Feb 2012 16:22:52 +0000 (17:22 +0100)]
repl: renamed -noformat to -nofilter; removed -format; default to -filter.
The new default: Filter with the default filter file.

9 years agorepl: Changed the meaning of -mime: It's now orthogonal to -format/-filter.
markus schnalke [Thu, 9 Feb 2012 15:51:27 +0000 (16:51 +0100)]
repl: Changed the meaning of -mime: It's now orthogonal to -format/-filter.
See changes in man page repl(1) for explanations.

9 years agoMerged replsbr.c into repl.c.
markus schnalke [Thu, 9 Feb 2012 15:25:08 +0000 (16:25 +0100)]
Merged replsbr.c into repl.c.

9 years agoAdded a note about formataddr(), because this had confused me.
markus schnalke [Thu, 9 Feb 2012 15:14:46 +0000 (16:14 +0100)]
Added a note about formataddr(), because this had confused me.

9 years agoRemoved the -fcc switch from repl(1).
markus schnalke [Thu, 9 Feb 2012 14:47:14 +0000 (15:47 +0100)]
Removed the -fcc switch from repl(1).
None of comp, dist, forw has it, why should repl then have it?
It likely had been added as the replcomps are not just copied but processed.
It had been quite easy to add this feature but nobody went far enough to
process components, distcomps, forwcomps as well to be able to have such
an -fcc switch for those tools as well.

9 years agoMinor cleanups.
markus schnalke [Thu, 9 Feb 2012 14:31:20 +0000 (15:31 +0100)]
Minor cleanups.

9 years agoMoved mhl(1) from libdir to bindir.
markus schnalke [Thu, 9 Feb 2012 14:29:53 +0000 (15:29 +0100)]
Moved mhl(1) from libdir to bindir.
The user should be able to use this tool normally, without inconveniences.

9 years agoforw(1) does always MIMEify now.
markus schnalke [Thu, 9 Feb 2012 14:06:49 +0000 (15:06 +0100)]
forw(1) does always MIMEify now.
Removed the -(no)mime, -(no)format, -filter switches. If you like to forward
messages in non-MIME format, then manually read in the output of:
mhl -forwall -form mhl.forward `mhpath MSGS...`
Digest do get MIMEified too. To send non-MIME digests use:
mhl -forwall -from mhl.digest -digest X -volume Y -issue Z `mhpath ...`

9 years agoRemoved the -file switch from forw(1).
markus schnalke [Thu, 9 Feb 2012 13:00:37 +0000 (14:00 +0100)]
Removed the -file switch from forw(1).

9 years agocomp(1) has no -file switch anymore.
markus schnalke [Thu, 9 Feb 2012 12:51:11 +0000 (13:51 +0100)]
comp(1) has no -file switch anymore.

9 years agoUpdated man pages: Removed the notice that whatnow could be called internally.
markus schnalke [Thu, 9 Feb 2012 10:58:47 +0000 (11:58 +0100)]
Updated man pages: Removed the notice that whatnow could be called internally.
This bug had been solved within the previous commits.

9 years agoRemoved unnecessary dependencies from Makefile (annosbr.o).
markus schnalke [Wed, 8 Feb 2012 21:36:04 +0000 (22:36 +0100)]
Removed unnecessary dependencies from Makefile (annosbr.o).

9 years agoCall anno(1) instead of compiling annosbr.c into send(1).
markus schnalke [Wed, 8 Feb 2012 21:30:30 +0000 (22:30 +0100)]
Call anno(1) instead of compiling annosbr.c into send(1).
This time we don't even get slower. Not that I'd care for speed ...

9 years agoAnnotations will always be done inplace from now on.
markus schnalke [Wed, 8 Feb 2012 20:47:20 +0000 (21:47 +0100)]
Annotations will always be done inplace from now on.

9 years agoRemoved left-overs from the -idanno removal.
markus schnalke [Wed, 8 Feb 2012 20:17:43 +0000 (21:17 +0100)]
Removed left-overs from the -idanno removal.
post (not spost) had written into a temp file those addresses to which it
had delivered mail. annoaux() in send had read from this temp file and
annotated the original message with each of those addresses. Now, no
addresses at all get annotated, but only the date of the action.

9 years agoRemoved unnecessary prototypes.
markus schnalke [Wed, 8 Feb 2012 19:18:32 +0000 (20:18 +0100)]
Removed unnecessary prototypes.

9 years agoCosmetic changes.
markus schnalke [Wed, 8 Feb 2012 19:10:43 +0000 (20:10 +0100)]
Cosmetic changes.

9 years agoMerged h/mts.h into h/prototypes.h.
markus schnalke [Wed, 8 Feb 2012 17:38:54 +0000 (18:38 +0100)]
Merged h/mts.h into h/prototypes.h.
Note: spost.c is not up to date.

9 years agoMoved sendsbr.c into send.c as it is not compiled into other binaries anymore.
markus schnalke [Wed, 8 Feb 2012 17:04:44 +0000 (18:04 +0100)]
Moved sendsbr.c into send.c as it is not compiled into other binaries anymore.

9 years agoUpdated .gitignore and removed the unused mts.conf.in.
markus schnalke [Wed, 8 Feb 2012 16:52:49 +0000 (17:52 +0100)]
Updated .gitignore and removed the unused mts.conf.in.
I've forgotten to remove the mts.conf.in some days ago.

9 years agoReplaced sendfiles with a simpler version that uses send instead of viamail.
markus schnalke [Wed, 8 Feb 2012 16:46:27 +0000 (17:46 +0100)]
Replaced sendfiles with a simpler version that uses send instead of viamail.
Also moved it from etc/ to uip/. Updated man pages.

Note: The splitting of large messages by sendfile/viamail/or elsewhere
seems not to be available anymore, although it had been documented in the
man page. Either the man pages don't match the code or I've not found this
function yet.

9 years agoRemoved viamail.
markus schnalke [Wed, 8 Feb 2012 15:50:47 +0000 (16:50 +0100)]
Removed viamail.
It is pretty much outdated. We can send files as MIME messages better with
the new attachment system.

9 years agocomp, dist, forw, repl don't depend on sendsbr anymore.
markus schnalke [Wed, 8 Feb 2012 14:59:16 +0000 (15:59 +0100)]
comp, dist, forw, repl don't depend on sendsbr anymore.
I had forgotten to remove the deps in the makefile.

9 years agoImproved the patch for send(1) to handle absolute path name arguments.
markus schnalke [Wed, 8 Feb 2012 14:31:41 +0000 (15:31 +0100)]
Improved the patch for send(1) to handle absolute path name arguments.
See changeset 3df5ab3c116e6d4a2fb4bb5cc9dfc5f781825815

9 years agoFixed mhmail. (It wanted to read the profile to create a temp file.)
markus schnalke [Wed, 8 Feb 2012 13:58:01 +0000 (14:58 +0100)]
Fixed mhmail. (It wanted to read the profile to create a temp file.)

9 years agoRemoved the `-delete' option from the `quit' command at the whatnow prompt.
markus schnalke [Wed, 8 Feb 2012 13:33:30 +0000 (14:33 +0100)]
Removed the `-delete' option from the `quit' command at the whatnow prompt.
There already is a command `delete' that's equal to the removed `quit -delete'.

9 years agoSeparated send from whatnow, similar to the previous commit.
markus schnalke [Wed, 8 Feb 2012 13:24:08 +0000 (14:24 +0100)]
Separated send from whatnow, similar to the previous commit.
Again, I traded execution speed for less (doubled) code, clearer interfaces,
and modularization. Oh what an improvement!

9 years agoAlways exec whatnow; don't link the code into comp, repl, forw, dist.
markus schnalke [Wed, 8 Feb 2012 12:42:11 +0000 (13:42 +0100)]
Always exec whatnow; don't link the code into comp, repl, forw, dist.
Although this might slow it a bit down, it makes the boundaries clearer.
The main problem for me is the interweaving of the parts in nmh. Let's
trade a bit of speed for better modularization.

9 years agoCosmetic changes.
markus schnalke [Wed, 8 Feb 2012 12:32:06 +0000 (13:32 +0100)]
Cosmetic changes.

9 years agoBetter mime types for attachments. Use some command; e.g. `file --mime'.
markus schnalke [Wed, 8 Feb 2012 10:19:50 +0000 (11:19 +0100)]
Better mime types for attachments. Use some command; e.g. `file --mime'.
Up to now attachments had either been text/plain or application/octet-stream,
if one hadn't added mhshow-suffix- profile entries for any possible type.
Now we call mimetypequeryproc (default: `file -b --mime' for GNU file),
this can be changed with the profile entry `Mime-Type-Query'. This command
will be executed with the attachment filename as last argument. If your
file(1) command does not print MIME types, you can still grep your profile
for matching mhshow-suffix- entries. However, I suggest to store this data
somewhere else. IMO the profile is not the right location for it.

9 years agoLayouting and comment changes. (minor stuff)
markus schnalke [Wed, 8 Feb 2012 08:41:03 +0000 (09:41 +0100)]
Layouting and comment changes. (minor stuff)

9 years agoRemoved the -backup flag from spost.
markus schnalke [Sat, 4 Feb 2012 15:19:06 +0000 (16:19 +0100)]
Removed the -backup flag from spost.
Post hadn't had it as renaming the draft is done by send. It appears as
if it were only there for debugging purposes.

9 years agoImproved quoting the fullname.
markus schnalke [Sat, 4 Feb 2012 15:12:22 +0000 (16:12 +0100)]
Improved quoting the fullname.

9 years agoRemoved the suppress dups feature from slocal for simplicity reasons.
markus schnalke [Sat, 4 Feb 2012 12:39:32 +0000 (13:39 +0100)]
Removed the suppress dups feature from slocal for simplicity reasons.
Now we don't need dbm anymore. This removed a heavy dependency and
complicated configure code.

9 years agoRemoved mts.conf; the maildelivery option went into slocal directly.
markus schnalke [Sat, 4 Feb 2012 12:08:51 +0000 (13:08 +0100)]
Removed mts.conf; the maildelivery option went into slocal directly.
The MTS is a non-MUA part of MH, which is/gets removed in MMH.
Now, you cannot change the global maildelivery file without changing the
code. You stil can specify -maildelivery to slocal.
I've also remove support for the env vars MHMTSCONF and MHMTSUSERCONF,
which were added by Earl Hood in 2010. We might want to add support
for them again. I need to think about the future of slocal anyway.

9 years agoRemoved the built-in FTP client.
markus schnalke [Sat, 4 Feb 2012 10:57:16 +0000 (11:57 +0100)]
Removed the built-in FTP client.
That's another of these things that are not the MUA's tasks.
There are good FTP clients around, just use one of them.
We could provide an external FTP wrapper script around wget or so,
to use with nmh-access-ftp. However, I'm not sure how to deal with
message/external-body in general. Although this concept is great,
I've never seen any such message in all my email life.

9 years agoRefactoring in spost.
markus schnalke [Sat, 4 Feb 2012 09:51:26 +0000 (10:51 +0100)]
Refactoring in spost.

9 years agoRemoved the last masquerading type: username_extension.
markus schnalke [Fri, 3 Feb 2012 17:42:55 +0000 (18:42 +0100)]
Removed the last masquerading type: username_extension.
If you want some username extension, then change the From: line in the
message draft. If you want real masquerading, then consult your MTA.
mmh is an MUA, no MTA.
(spost hadn't supported username_extension maquerading, anyway.)

9 years agoRemoved draft_from masquerading.
markus schnalke [Fri, 3 Feb 2012 17:28:51 +0000 (18:28 +0100)]
Removed draft_from masquerading.
We're an MUA and should not care for SMTP envelopes at all.

9 years agoRemoved mmailid masquerading.
markus schnalke [Fri, 3 Feb 2012 17:07:11 +0000 (18:07 +0100)]
Removed mmailid masquerading.
That's an MTA's task, but mmh is an MUA.

9 years agoRemoved unused parameter from mbx_copy().
markus schnalke [Fri, 3 Feb 2012 16:02:11 +0000 (17:02 +0100)]
Removed unused parameter from mbx_copy().

9 years agoMajor bugfix: inc does not lose data anymore.
markus schnalke [Fri, 3 Feb 2012 11:25:42 +0000 (12:25 +0100)]
Major bugfix: inc does not lose data anymore.
What have I done in 70b2643e0da8485174480c644ad9785c84f5bff4 ?
Producing scan listings and inc'ing mail are too closely related.
By removing the body component from scan listings, I also had removed
the ability to copy bodies during inc. Hence this commit undos the
changes. (And reintroduces the body component in scan listings. :-( )
The code is too much interweaved!

9 years agoRemoved the -(no)remove switches from spost.
markus schnalke [Fri, 3 Feb 2012 10:16:05 +0000 (11:16 +0100)]
Removed the -(no)remove switches from spost.
I wonder why it existed, as the draft can get printed to stdout with -debug.
That should be enough for debugging without modifying source code.

9 years agoComment changes.
markus schnalke [Fri, 3 Feb 2012 09:50:13 +0000 (10:50 +0100)]
Comment changes.

9 years agoFixed abort of e.g. comp when draft folder is empty.
markus schnalke [Fri, 3 Feb 2012 09:42:49 +0000 (10:42 +0100)]
Fixed abort of e.g. comp when draft folder is empty.
In this case mp->lowoff is 1 but mp->lowmsg equal mp->hghmsg equal 0.
Hence we have an access at mp->msgstats[-1], which corrupted our mem.
Gdb hadn't helped me for this, but valgrind showed me the problem.

9 years agoSyntactic and comment changes.
markus schnalke [Fri, 3 Feb 2012 09:15:19 +0000 (10:15 +0100)]
Syntactic and comment changes.

9 years agospost: refactoring; removed -(no)format switches as they were not used.
markus schnalke [Tue, 31 Jan 2012 23:47:35 +0000 (00:47 +0100)]
spost: refactoring; removed -(no)format switches as they were not used.

9 years agospost: refactoring, added comments, removed unused code
markus schnalke [Tue, 31 Jan 2012 23:36:54 +0000 (00:36 +0100)]
spost: refactoring, added comments, removed unused code

9 years agoScan listings shall not contain body content. Hence, removed this feature.
markus schnalke [Mon, 30 Jan 2012 15:16:26 +0000 (16:16 +0100)]
Scan listings shall not contain body content. Hence, removed this feature.
Scan listings shall operator on message headers and non-message information
only. Displaying the beginning of the body complicates everything too much.
That's no surprise, because it's something completely different. If you
want to examine the body, then use show(1)/mhshow(1).
Changed the default scan formats accordingly.

9 years agoRemoved another deprecated mhn check.
markus schnalke [Mon, 30 Jan 2012 13:32:10 +0000 (14:32 +0100)]
Removed another deprecated mhn check.
The comment appeared to be wrong ... maybe inverted. I removed it.

9 years agoRemoved the, in 1997 deprecated, send option -noshowproc and env var NOMHNPROC.
markus schnalke [Mon, 30 Jan 2012 13:27:19 +0000 (14:27 +0100)]
Removed the, in 1997 deprecated, send option -noshowproc and env var NOMHNPROC.

9 years agoRemoved -pause from mhshow(1).
markus schnalke [Mon, 30 Jan 2012 11:42:06 +0000 (12:42 +0100)]
Removed -pause from mhshow(1).
My goal is to have show/mhshow generate a single stream of bytes to be
piped through a pager. Content not convertable to text shall not be displayed
directly. This is my idea currently.

9 years agoBugfix: Removed -reverse switch from scan(1).
markus schnalke [Mon, 30 Jan 2012 11:00:49 +0000 (12:00 +0100)]
Bugfix: Removed -reverse switch from scan(1).
No more to say but to quote MTR:
-[no]reverse under #ifdef BERK (I really HATE this)
And JLR:
Lists messages in reverse order with the `-reverse' switch.
This should be considered a bug.

9 years agoAlias: Removed the address group `*', which meant everyone on the system.
markus schnalke [Mon, 30 Jan 2012 10:33:59 +0000 (11:33 +0100)]
Alias: Removed the address group `*', which meant everyone on the system.
Therefore could remove `everyone' and `noshell' from mts.conf.
If one really needs to write mail to everyone on the system (not just
all regular users, which probably are in a group `user'), then he
shurely can invest a bit more effort to do so. Likely, the simple condition
to uids > 200 and not the shell `noshell' would anyways be to limited.
Better use awk or the like and do it by hand.

9 years agoRest of the MMDF-style mail drop support removal.
markus schnalke [Mon, 30 Jan 2012 10:03:29 +0000 (11:03 +0100)]
Rest of the MMDF-style mail drop support removal.
Only Unix-style (mbox) mail drops are supported now. Their location
is in `mailspool', which is reported in the  configure summary now.
If users like to have different locations, they can use the environment
variable MAILDROP or the profile entry MailDrop to overrule the default.
From mts.conf, mmdfldir and mmdflfil were removed.
msgchk(1) received several cleanups.
I touched sbr/m_getfld.c ... Wooohh ...

9 years agoRemoved mmdelim[12], which were the delimiters for MMDF-style mail drops.
markus schnalke [Sat, 28 Jan 2012 19:46:46 +0000 (20:46 +0100)]
Removed mmdelim[12], which were the delimiters for MMDF-style mail drops.

9 years agoRemoved paragraphs which looked like forgotten to remove.
markus schnalke [Sat, 28 Jan 2012 19:45:13 +0000 (20:45 +0100)]
Removed paragraphs which looked like forgotten to remove.

9 years agoRemoved support for MMDF-style mail drops.
markus schnalke [Sat, 28 Jan 2012 19:40:31 +0000 (20:40 +0100)]
Removed support for MMDF-style mail drops.
I'm not sure yet if I've removed all of it but it should be most of it.

9 years agoSynced man page mh-chart with send.
markus schnalke [Sat, 28 Jan 2012 17:58:07 +0000 (18:58 +0100)]
Synced man page mh-chart with send.
The man page mh-chart definately should be generated!
Automate this task, man!

9 years agoFixed path lookup for alias files: ali, send, whatnow.
markus schnalke [Sat, 28 Jan 2012 17:40:02 +0000 (18:40 +0100)]
Fixed path lookup for alias files: ali, send, whatnow.

9 years agoforw/repl/dist annotations won't add address lists anymore.
markus schnalke [Sat, 28 Jan 2012 15:05:54 +0000 (16:05 +0100)]
forw/repl/dist annotations won't add address lists anymore.
spost does not support it and I wonder if we need it.
Remove the undocumented -idanno switch, actually a no-op, from spost.

9 years agoTrivial typesetting fix in man page.
markus schnalke [Sat, 28 Jan 2012 14:21:44 +0000 (15:21 +0100)]
Trivial typesetting fix in man page.

9 years agoRemoved the ATTVIBUG compile option.
markus schnalke [Sat, 28 Jan 2012 12:35:42 +0000 (13:35 +0100)]
Removed the ATTVIBUG compile option.
If you do have the bug, then workaround it like described in the FAQ:

Subject: 06.01 What to do with "Problems with edit - draft removed".
From: John Romine <jromine at ics.uci.edu>
Date: Mon, 1 May 1995 00:00:00 -0800

  If your users are using an AT&T version of "vi", it's exiting with
  non-zero status (supposedly a count of the "errors" during the
  edit). Move "vi" to "broken_vi" and put it its place :

    #! /bin/sh
    /usr/ucb/broken_vi "$@"
    exit 0

  Alternatively, compile MH with the ATTVIBUG option.

  Then complain to your vendor that "vi" is broken, and they shouldfix it.

btw: ex-vi does not have this bug.

9 years agoRemoved EISREMOTE check.
markus schnalke [Sat, 28 Jan 2012 12:10:50 +0000 (13:10 +0100)]
Removed EISREMOTE check.
It's not in POSIX and Google finds only nmh code containing it.
Maybe it was some BSD experiment. Who knows.

9 years agoRemoved the undocumented -unique switches. Seems they were JLR-only stuff.
markus schnalke [Sat, 28 Jan 2012 12:04:59 +0000 (13:04 +0100)]
Removed the undocumented -unique switches. Seems they were JLR-only stuff.

9 years agoRemoved the -width switch from send, spost and repl.
markus schnalke [Sat, 28 Jan 2012 11:54:36 +0000 (12:54 +0100)]
Removed the -width switch from send, spost and repl.
Adressee header fields will always be folded for OUTPUTLINELEN (=72) chars.

9 years agoRemoved options to deactivate dashstuffing. Always dashstuff.
markus schnalke [Sat, 28 Jan 2012 11:26:36 +0000 (12:26 +0100)]
Removed options to deactivate dashstuffing. Always dashstuff.
Maybe there are few RFC 934 messages around, but dashstuffing is IMO
more useful than bad.

9 years agoRemoved unneeded options from send.
markus schnalke [Sat, 28 Jan 2012 11:12:21 +0000 (12:12 +0100)]
Removed unneeded options from send.
Most of them were supported by post but are not by spost.
We don't need them. (More about dashstuffing soon.)

9 years agoRemoved the UCI code to read the signatur (= name) from ~/.signature.
markus schnalke [Wed, 25 Jan 2012 21:56:43 +0000 (22:56 +0100)]
Removed the UCI code to read the signatur (= name) from ~/.signature.
If we want to read something from ~/.signature, then those lines that
form the footer of a mail message. What is called ``signature'' here
is the name of the sender; the name that is put into the From: line.
There are already several options to put it:
- environment variable: SIGNATURE (to change temporary)
- profile entry: Signature: (to set only for the mail system)
- GECOS field in passwd (fallback and global)
These should be enough.

9 years agoRemoved UCI-specific group leader code from conflict(8).
markus schnalke [Wed, 25 Jan 2012 21:38:54 +0000 (22:38 +0100)]
Removed UCI-specific group leader code from conflict(8).

9 years agoRemoved the UCI alternative name of anno(1): `fanno'.
markus schnalke [Wed, 25 Jan 2012 21:36:49 +0000 (22:36 +0100)]
Removed the UCI alternative name of anno(1): `fanno'.
fanno didn't add the date. If you want this, run `anno -nodate'. Hey, you
can create a shell alias for it. What about that? ;-)

9 years agoRemoved the -header option from scan(1).
markus schnalke [Wed, 25 Jan 2012 21:29:34 +0000 (22:29 +0100)]
Removed the -header option from scan(1).
The heading had been very simple since the advent of format strings anyway.
If someone wants a heading, he can run folder(1) before.

9 years agoRemoved (allmost all) JLR-specific code.
markus schnalke [Wed, 25 Jan 2012 21:21:56 +0000 (22:21 +0100)]
Removed (allmost all) JLR-specific code.
There still is one fragment in fmt_scan(), of which I don't understand
the logic. I don't want to remove stuff I don't understand.

9 years agoRemoved LBL compile condition (format: addtoseq).
markus schnalke [Wed, 25 Jan 2012 21:05:07 +0000 (22:05 +0100)]
Removed LBL compile condition (format: addtoseq).

9 years agoRemoved several `#if 0' fragments.
markus schnalke [Wed, 25 Jan 2012 21:00:58 +0000 (22:00 +0100)]
Removed several `#if 0' fragments.
We better don't carry dead code with us, it might start smelling.

9 years agoFinally fixed the annoying `Invalid cross-device link' problem.
markus schnalke [Wed, 25 Jan 2012 12:31:36 +0000 (13:31 +0100)]
Finally fixed the annoying `Invalid cross-device link' problem.
Due to a missing slash (/), temporary files were put into the parent
directory instead of the same one. See:
mhbuild: unable to rename output /home/meillo/Mail/send0zxfDu to
/home/meillo/MailmhbuildzQjMUm: Invalid cross-device link

9 years agoUpdated the man pages to the recent changes.
markus schnalke [Tue, 24 Jan 2012 23:04:05 +0000 (00:04 +0100)]
Updated the man pages to the recent changes.

9 years agoFixed -mime for forw and repl.
markus schnalke [Tue, 24 Jan 2012 23:01:51 +0000 (00:01 +0100)]
Fixed -mime for forw and repl.
If the value of an attachment header starts with `+', then it is treated
as the specification of a message in MH style: ``+folder msg''

9 years agoRemoved the mime command from whatnow and automimeproc (automhnproc).
markus schnalke [Tue, 24 Jan 2012 19:55:15 +0000 (20:55 +0100)]
Removed the mime command from whatnow and automimeproc (automhnproc).
The man pages need to be updated.
repl and forw are broken right now.

9 years agoActivated Jon's attachment system by default and steamlined it.
markus schnalke [Tue, 24 Jan 2012 19:08:35 +0000 (20:08 +0100)]
Activated Jon's attachment system by default and steamlined it.
I had done similar work already some time ago. See:
http://www.mail-archive.com/nmh-workers@nongnu.org/msg02112.html
This time it's the second go.

I changed Jon's attachment system to have a default attachment header
field name, or get it from the profile. I removed the command line options.
The new profile name is: `Attachment-Header'. Stored in attach_fmt.
I removed the the choice between several attachment formats.

A message gets mimeified if it has attachment headers or (and this is new)
contains any non-ASCII character. The body won't be scanned for lines
matching /^#/. The MIME structure is created automatically.

The content-typing of unknown attachments is still poor and needs to
be improved.

You shouldn't use the `mime' command at the whatnow prompt anymore.

9 years agoAdded a comment and a variable initialization.
markus schnalke [Tue, 24 Jan 2012 15:28:36 +0000 (16:28 +0100)]
Added a comment and a variable initialization.

9 years agoFree memory after use in m_draft().
markus schnalke [Thu, 5 Jan 2012 18:24:20 +0000 (19:24 +0100)]
Free memory after use in m_draft().

9 years agoExplicit checks for return values of strcmp().
markus schnalke [Thu, 5 Jan 2012 18:18:12 +0000 (19:18 +0100)]
Explicit checks for return values of strcmp().
The return value of strcmp() is unintuitive for string equality tests.
I prefer explicit comparisions against 0. I changed this everywhere.

9 years agoRemoved isprefix() and replaced it with strncmp().
markus schnalke [Thu, 5 Jan 2012 11:26:09 +0000 (12:26 +0100)]
Removed isprefix() and replaced it with strncmp().
isprefix() had been ssequal(), which had not been what it advertised to be.
Now, all this is gone.
We could get problems if one of the arguments is NULL, as isprefix()
handled this situation, but strncmp() does not. It appears as if this case
does not show up in the code.

9 years agoRemoved forgotten unused variable.
markus schnalke [Thu, 5 Jan 2012 10:56:44 +0000 (11:56 +0100)]
Removed forgotten unused variable.

9 years agoRemoved the non-LOCALE character code and the #ifdefs and simplified.
markus schnalke [Thu, 5 Jan 2012 10:52:03 +0000 (11:52 +0100)]
Removed the non-LOCALE character code and the #ifdefs and simplified.
POSIX says: tolower() won't change its argument if it is not isupper().
And isupper() doesn't need an additional check for isalpha().

9 years agoRefactoring in sbr/m_convert.c
markus schnalke [Thu, 5 Jan 2012 10:28:18 +0000 (11:28 +0100)]
Refactoring in sbr/m_convert.c

9 years agoReserved special sequence names may be upper case too. Even without LOCALE.
markus schnalke [Thu, 5 Jan 2012 10:19:22 +0000 (11:19 +0100)]
Reserved special sequence names may be upper case too. Even without LOCALE.

9 years agoMuch more straight-forward handling of the beyond sequence.
markus schnalke [Thu, 5 Jan 2012 10:11:13 +0000 (11:11 +0100)]
Much more straight-forward handling of the beyond sequence.
Could remove the message flag SELECT_EMPTY in the same go.
This frees one more space for a user-defined sequence.

9 years agoVarious minor cleanups in sbr/m_convert.c.
markus schnalke [Wed, 4 Jan 2012 20:04:56 +0000 (21:04 +0100)]
Various minor cleanups in sbr/m_convert.c.

9 years agoRemoved the unused message flag: DELETED.
markus schnalke [Wed, 4 Jan 2012 18:36:08 +0000 (19:36 +0100)]
Removed the unused message flag: DELETED.
Now we can store one user-defines seq more.

9 years agos/ALLOW_NEW/ALLOW_BEYOND/
markus schnalke [Wed, 4 Jan 2012 17:57:18 +0000 (18:57 +0100)]
s/ALLOW_NEW/ALLOW_BEYOND/

9 years agoRenamed all standard sequences (e.g. cur->c) and made them globally changeable
markus schnalke [Wed, 4 Jan 2012 17:29:23 +0000 (18:29 +0100)]
Renamed all standard sequences (e.g. cur->c) and made them globally changeable
The full list:
cur -> c
first -> f
last -> l
next -> n
prev -> p
all -> a
new -> b (mnemonic: one beyond the last)
They are globally changeable in config/config.c
Could be that I'll add the old names again, as convenience aliases.

9 years agoInverted the second arg of seq_setunseen(), to be more natural.
markus schnalke [Wed, 4 Jan 2012 13:49:09 +0000 (14:49 +0100)]
Inverted the second arg of seq_setunseen(), to be more natural.

9 years agoAnother fix for the strchr() transition: Check for NULL arguments.
markus schnalke [Wed, 4 Jan 2012 13:46:58 +0000 (14:46 +0100)]
Another fix for the strchr() transition: Check for NULL arguments.
Is now the point to reintroduce the brkany() helper? Hmm...

9 years agoActivated default sequence negation (exclamation mark).
markus schnalke [Wed, 4 Jan 2012 11:35:19 +0000 (12:35 +0100)]
Activated default sequence negation (exclamation mark).

9 years agoActivated a default unseen sequence; updated man pages to it.
markus schnalke [Wed, 4 Jan 2012 11:04:44 +0000 (12:04 +0100)]
Activated a default unseen sequence; updated man pages to it.

9 years agoFixed bug in brkstring(), newly introduced by the switch to strchr().
markus schnalke [Wed, 4 Jan 2012 10:16:12 +0000 (11:16 +0100)]
Fixed bug in brkstring(), newly introduced by the switch to strchr().
strchr() treats the trailing null byte surprisingly:
``The terminating null byte is considered to be part of the string.''

9 years agoGlobally defined the names for the standard sequences.
markus schnalke [Wed, 4 Jan 2012 09:06:51 +0000 (10:06 +0100)]
Globally defined the names for the standard sequences.
I'll rework the whole code to use them and not have hard-coded names anymore.
The `new' sequence will be called `beyond' sequence (`b') from now on.
The `unseen' sequence will be set by default to `u' from now on.
The sequence negation will be set by default to `!' from now on.