fix threadid NULL deref
authorPhilipp Takacs <philipp@bureaucracy.de>
Sun, 14 May 2023 00:12:49 +0000 (02:12 +0200)
committerPhilipp Takacs <philipp@bureaucracy.de>
Sun, 14 May 2023 00:15:53 +0000 (02:15 +0200)
strchr returns NULL if the character is not found.

sbr/getthreadid.c

index a1ad7a0..abac78d 100644 (file)
@@ -54,8 +54,11 @@ threadid(char *msgid, char *referens)
        }
 
        start = strchr(threadfrom, '<');
+       if (!start) {
+               return NULL;
+       }
        end = strchr(start, '>');
-       if (!(*start) || !(*end)) {
+       if (!end) {
                return NULL;
        }
        *end = '\0';