Peter Maydell [Sun, 3 Aug 2008 15:14:23 +0000 (15:14 +0000)]
Bug #23436: fix some minor manpage syntax errors and add a test which runs
groff over them and checks that no warnings are emitted.
Peter Maydell [Sun, 3 Aug 2008 15:13:34 +0000 (15:13 +0000)]
Allow tests to indicate that they have been skipped by printing their
own message and returning with exit status 120.
Peter Maydell [Sun, 3 Aug 2008 13:59:19 +0000 (13:59 +0000)]
Ignore editor backup files
Peter Maydell [Sun, 3 Aug 2008 13:54:37 +0000 (13:54 +0000)]
etc/replcomps, etc/replgroupcomps: Trim trailing whitespace from
Subject field (patch from Eric Gillespie)
Peter Maydell [Sun, 3 Aug 2008 13:32:17 +0000 (13:32 +0000)]
When doing an if-test on the result of a function which returns a string
result, check whether the string is non-empty (as the documentation says we
do). Previously we were always testing the integer 'value'.
Josh Bressers [Fri, 25 Jul 2008 01:07:39 +0000 (01:07 +0000)]
* test/setup-test: Run 'make clean' before building
Josh Bressers [Fri, 25 Jul 2008 00:11:53 +0000 (00:11 +0000)]
* test/runtest: cat test-temp-dir only once. Destroy and create
test Mail hierarchy here, so each test has its own independent
test data.
* test/setup-test: Drop needless pushd/popd, which don't exist in
sh anyway. Don't use aclocal, which is part of automake.
Don't create Mail hierarchy here (see test/runtest).
* test/tests/folder/test-create, tests/folder/test-total: Drop
unused BINDIR.
* tests/pick/test-pick: Remove failing no-op test.
* test/tests/scan/test-scan: Write expected and actual output to
files and diff them. This way, if the output differs, diff
provides the FAILing exit code and shows the differences.
Josh Bressers [Fri, 13 Jun 2008 00:11:49 +0000 (00:11 +0000)]
* man/repl.man, etc/mhl.reply:
Add an attribution line when replying to messages.
Josh Bressers [Thu, 12 Jun 2008 23:29:16 +0000 (23:29 +0000)]
Remove an accidentally committed file
Peter Maydell [Mon, 2 Jun 2008 22:37:01 +0000 (22:37 +0000)]
When building on gcc, use noreturn attribute on adios and the various done
functions.
Peter Maydell [Mon, 2 Jun 2008 22:05:11 +0000 (22:05 +0000)]
Back out previous, completely broken, change (due to a foulup I was
compiling a different tree to the one I was committing to CVS).
Peter Maydell [Mon, 2 Jun 2008 21:49:07 +0000 (21:49 +0000)]
If we're compiling with gcc, mark adios() as never returning (better code
and fewer spurious 'uninitialized variable) warnings)
Peter Maydell [Sun, 1 Jun 2008 16:50:22 +0000 (16:50 +0000)]
Update bit of docs about release announcements.
Peter Maydell [Thu, 22 May 2008 10:37:55 +0000 (10:37 +0000)]
Don't use MB_CUR_MAX if we aren't compiled with multibyte support.
Peter Maydell [Thu, 22 May 2008 10:21:48 +0000 (10:21 +0000)]
Factor out common code for writing ls shell command. Rework its length
checking so it doesn't rely on the return value of sprintf(), for the
benefit of SunOS 4.
Peter Maydell [Wed, 21 May 2008 18:05:49 +0000 (18:05 +0000)]
Don't rely on realloc() to follow POSIX in handling a NULL pointer
Peter Maydell [Wed, 21 May 2008 17:16:44 +0000 (17:16 +0000)]
Add some table size declarations for the benefit of elderly lexes with
small defaults (eg SunOS 4)
Peter Maydell [Tue, 20 May 2008 19:04:57 +0000 (19:04 +0000)]
Update comment now we don't use lex -o.
David Levine [Sun, 18 May 2008 13:56:58 +0000 (13:56 +0000)]
* sbr/addrsbr.c: removed "err" from conditional, because gcc
correctly warned that it would always evaluate as true. It's
the address of a static array.
Oliver Kiddle [Fri, 16 May 2008 15:31:26 +0000 (15:31 +0000)]
don't use $< in target rules in makefiles, as POSIX says it's only defined
in inference rules
David Levine [Tue, 13 May 2008 02:39:04 +0000 (02:39 +0000)]
* configure.in, INSTALL: if --enable-masquerade is not
specified to configure, enable all supported masquerade forms.
This allows users to masquerade with the default
configuration. That seems to be more worthwhile now than
trying to prevent users from using it, especially with
single-user installations or those where a user can edit
etc/mts.conf.
Peter Maydell [Sun, 4 May 2008 20:58:35 +0000 (20:58 +0000)]
bug #23167: sbr/ruserpass.c (ruserpass): make bad permissions on .netrc be
an instantly fatal error. Previously we returned an error value; however, no
caller was checking it. So now ruserpass() has a void return type.
Peter Maydell [Sun, 4 May 2008 16:09:08 +0000 (16:09 +0000)]
* bug #23163: various minor fixes for the benefit of older Unixes
(specifically SunOS 4): reintroduce strerror() substitute implementation;
provide memmove() substitute implementation
* bug #23163: fix broken 'build outside source directory' feature
* bug #23162: sbr/dtime.c: fix stray HAVE_TM_GMTOFF that wasn't updated
to the new macro name.
Peter Maydell [Wed, 30 Apr 2008 18:47:02 +0000 (18:47 +0000)]
Provide SASL_CB_AUTHNAME callback (avoids problem with wrong username
being sent in some situations)
Peter Maydell [Tue, 29 Apr 2008 21:05:30 +0000 (21:05 +0000)]
Correct various places in smtp.c where the reply string might not have been
correctly NUL-terminated. Includes a fix for a particularly nasty and long
standing screwup where the buffer length counting in smhear() was totally
broken for continued lines from the server.
Peter Maydell [Tue, 29 Apr 2008 20:59:04 +0000 (20:59 +0000)]
Fix SASL issue properly, by making sm_rrecord() and thus sm_hear() set
the length of the reply string correctly (the SASL libraries now care
if you pass in the wrong length).
Peter Maydell [Tue, 29 Apr 2008 20:53:33 +0000 (20:53 +0000)]
Revert previous SASL fix (wrong approach)
Peter Maydell [Tue, 29 Apr 2008 17:04:38 +0000 (17:04 +0000)]
Cope with sasl_decode64() returning SASL_CONTINUE as well as SASL_OK.
Peter Maydell [Mon, 28 Apr 2008 21:13:53 +0000 (21:13 +0000)]
Add remark about how to update the homepage.
Peter Maydell [Sun, 27 Apr 2008 20:58:50 +0000 (20:58 +0000)]
Update some of the 'how to do a release' documentation
Peter Maydell [Sun, 27 Apr 2008 20:55:28 +0000 (20:55 +0000)]
Up version string to 1.3-dev for the CVS trunk.
Peter Maydell [Sun, 27 Apr 2008 19:54:37 +0000 (19:54 +0000)]
Use hyphen, not plus (corresponding to previous RCx naming convention)
Peter Maydell [Sun, 27 Apr 2008 19:44:58 +0000 (19:44 +0000)]
Bump version number, date for release of 1.3 RC1
Oliver Kiddle [Fri, 11 Apr 2008 14:12:54 +0000 (14:12 +0000)]
move most remaining macros out of acconfig.h which is an obsolete feature of
autoconf
Peter Maydell [Sat, 5 Apr 2008 19:04:41 +0000 (19:04 +0000)]
* bug #18655: fix use of admonish() for a fatal error (should
be adios(); only actual effect would be wrong exit code).
Thanks to Craig Leres for spotting this.
Peter Maydell [Sat, 5 Apr 2008 18:41:37 +0000 (18:41 +0000)]
Bug #20028 (Debian bug 399271): fix code assuming that pointer
differences were 32 bits -- thanks to Dean Gaudet for the patch.
Josh Bressers [Fri, 25 Jan 2008 21:00:42 +0000 (21:00 +0000)]
* uip/mhshowsbr.c (show_all_messages): Be more generous when parsing
multipart messages.
Joel Reicher [Thu, 8 Nov 2007 02:28:38 +0000 (02:28 +0000)]
Insert types for args of some function pointers to improve type checking.
Joel Reicher [Sun, 4 Nov 2007 11:54:32 +0000 (11:54 +0000)]
Return type of (*done)() changed to void. default_done() replaced by
exit(). All dead code "return 1" lines removed from *_done()s and replaced
by explicit "return 1" following done() calls in main()s (they should
never be reached). This should make cleaning up program termination
structures easier.
Joel Reicher [Sun, 4 Nov 2007 08:52:17 +0000 (08:52 +0000)]
Refactor cts pointer and free()ing on abnormal exit of associated list
into mhfree.c, eliminating duplication.
Joel Reicher [Sun, 4 Nov 2007 04:47:17 +0000 (04:47 +0000)]
Change link-time overriding of done() to run-time reassigning of equivalent
(*done)(). This should make changing the return type of done and the
rationalisation of exit code easier.
Bill Wohler [Mon, 24 Sep 2007 07:02:03 +0000 (07:02 +0000)]
The MH web site is now rand-mh.sourceforge.net/ and the MH
book is now at http://rand-mh.sourceforge.net/book/.
Changed Questions
1.02 ...current version? mailutils 1.2
1.03 Where can I get MH? Debian 4.0 nmh 1.1-RC4, update links, mu 1.2
1.04 ...references for MH? Refer to SourceForge
1.06 How...print a MH manual? Refer to SourceForge
2.17 How...build MH on a Mac? Use fink
4.05 ...tools to archive MH? Mention swish++, mairix, and namazu
Josh Bressers [Tue, 21 Aug 2007 21:19:39 +0000 (21:19 +0000)]
* Red Hat Bug #253342: inc.c, utils.c, utils.h: When inc is run with the
-silent flag, don't exit(1) for no apparent reason.
Peter Maydell [Sun, 29 Apr 2007 22:57:36 +0000 (22:57 +0000)]
Rename functions to avoid clash with C library exp2().
Peter Maydell [Sun, 29 Apr 2007 22:34:04 +0000 (22:34 +0000)]
Suppress 'uninitialised variable' warning.
Peter Maydell [Sun, 29 Apr 2007 22:05:02 +0000 (22:05 +0000)]
On Linux, define _GNU_SOURCE so that GNU libc exposes the wcwidth()
prototype in wchar.h.
Peter Maydell [Sun, 29 Apr 2007 22:01:04 +0000 (22:01 +0000)]
Change name of internal function to avoid potential conflicts with GNU
libc's getline() function.
Peter Maydell [Sun, 29 Apr 2007 20:49:32 +0000 (20:49 +0000)]
Minor rearrangement so variables/functions used only if !HAVE_LIBLOCKFILE
are also declared only in that case.
Peter Maydell [Sun, 29 Apr 2007 19:36:14 +0000 (19:36 +0000)]
For gcc, make the default CFLAGS include -Wno-pointer-sign if the compiler
recognises it. gcc 4 now by default produces a large volume of these
warnings, which I believe are probably spurious and definitely a lot of
work to go through and fix. So we suppress them for now so that the other
warnings are more easily visible.
Joel Reicher [Tue, 17 Apr 2007 04:53:54 +0000 (04:53 +0000)]
buffer is compared with cp, and so needs to be changed to unsigned too.
Josh Bressers [Tue, 17 Apr 2007 01:02:08 +0000 (01:02 +0000)]
Initial checkin of a testsuite
Joel Reicher [Fri, 13 Apr 2007 11:53:08 +0000 (11:53 +0000)]
Change all chars being passed to the ctype macros (isalph(), etc.) to
be unsigned chars, following through to change any other types as
necessary (e.g. comparison between two pointers). Not all chars have
been changed to unsigned chars; just those that were in danger of being
sign extended when passed to the int-taking ctype macros.
Joel Reicher [Tue, 10 Apr 2007 22:12:26 +0000 (22:12 +0000)]
We're not using the .Bu macro anymore.
Joel Reicher [Tue, 10 Apr 2007 06:13:27 +0000 (06:13 +0000)]
Fix for bug #11139: mhl -form mhl.reply omits '> ' on some lines.
putcomp() was assuming only the first call on the body had the buffer
beginning at the start of a line.
Joel Reicher [Tue, 10 Apr 2007 03:32:48 +0000 (03:32 +0000)]
Application of patch #5218: patch for bug #9742. Fixes a typo in the
size arg of snprintf(). mhlist output which used to have incorrect lines
such as
1.2 multipart/mixed 772
1.21 text/plain 9
1.22 multipart/mixed 162
now have the correct
1.2 multipart/mixed 772
1.2.1 text/plain 9
1.2.2 multipart/mixed 162
Peter Maydell [Wed, 21 Mar 2007 00:21:10 +0000 (00:21 +0000)]
bug #18630, #18631, #18632, #18634: various patches from Craig Leres
fixing error message argument problems.
Peter Maydell [Wed, 21 Mar 2007 00:18:19 +0000 (00:18 +0000)]
bug #15212: remove configure test for broken AT&T vi. This test was broken
and unfixable. Support for manually defining ATTVIBUG remains.
Josh Bressers [Tue, 16 Jan 2007 02:08:10 +0000 (02:08 +0000)]
Add a missing header file
Joel Reicher [Sun, 5 Nov 2006 13:20:46 +0000 (13:20 +0000)]
Changed bold "-all" to unbolded "all". It's a reserved msgs word, not a flag.
David Levine [Tue, 24 Oct 2006 14:31:40 +0000 (14:31 +0000)]
* uip/sendsbr.c: with attachformat values of 1 or 2, add
name= portion to Content-Type header. This makes them
consistent with attachformat value 0. And it allows mhstore
to use that (file)name when extracting attachments.
Josh Bressers [Sun, 27 Aug 2006 01:19:39 +0000 (01:19 +0000)]
* configure.in: If we're not using dotlocking, there is no need to set inc
sgid.
Joel Reicher [Sun, 4 Jun 2006 08:37:24 +0000 (08:37 +0000)]
Fixed bug introduced when changing from check_folder() to new
create_folder() function. The folder name needed to be expanded to an
absolute path first. Similar things may have happened with other
conversions.
Joel Reicher [Thu, 27 Apr 2006 12:00:28 +0000 (12:00 +0000)]
Created pluspath function to check for '+' prefix and change flag for
path() appropriately. This eliminates some duplicate prefix processing,
but not all. The path functions need to be restructed; this is the first
step.
Joel Reicher [Mon, 24 Apr 2006 07:10:03 +0000 (07:10 +0000)]
ssequal() does not check for a substring, but for a prefix, so added a
comment to this effect. If this is sufficient, the function body should
remain unchanged but the name and comments should be modified. If not,
then the function needs to be corrected.
Paul Fox [Sat, 22 Apr 2006 16:33:48 +0000 (16:33 +0000)]
fixes case where a very long character-class range (128 or
more characters) causes negative indexing into pattern string.
Joel Reicher [Sun, 16 Apr 2006 06:47:59 +0000 (06:47 +0000)]
Fixed a typo.
Joel Reicher [Fri, 14 Apr 2006 14:10:15 +0000 (14:10 +0000)]
Created function open_form() to open form file or fallback to default
components file, with error handling. Replaced duplicated code with call
to this function.
Joel Reicher [Fri, 14 Apr 2006 08:42:04 +0000 (08:42 +0000)]
Fixed a couple of typos.
Joel Reicher [Fri, 14 Apr 2006 08:21:35 +0000 (08:21 +0000)]
Sanitised some dodgy homedir finding code, but it still might not make
sense.
Joel Reicher [Fri, 14 Apr 2006 07:54:26 +0000 (07:54 +0000)]
Get rid of some trivial warnings; unused variables, ambiguous if-else,
missing headers.
Joel Reicher [Thu, 13 Apr 2006 14:24:41 +0000 (14:24 +0000)]
Make print_aka() and print_usr() static. They're not used outside ali.c.
Joel Reicher [Tue, 11 Apr 2006 14:09:11 +0000 (14:09 +0000)]
Created app_msgarg() (append message arg) and a simple resizable array
struct to go with it that do almost exactly what the code they've replaced
was doing.
Replaced this (duplicated) code in many files with a call to app_msgarg().
Joel Reicher [Tue, 11 Apr 2006 05:48:43 +0000 (05:48 +0000)]
Completing the .cvsignore list(s).
Joel Reicher [Sun, 9 Apr 2006 14:06:31 +0000 (14:06 +0000)]
Fixed a small typo.
Paul Fox [Fri, 31 Mar 2006 15:14:49 +0000 (15:14 +0000)]
this commit:
- adds range support to character classes
- fixes out-of-bounds references to the case-folding array
when doing case comparisons for 8-bit message text
- makes character classes as case tolerant as the rest
of the pick regexp machine. (where lowercase chars in
patterns should match uppercase in the text.)
- fixes an uninitialized pointer warning, which might actually have
been a real bug
David Levine [Thu, 30 Mar 2006 22:19:50 +0000 (22:19 +0000)]
* uip/sendsbr.c: with attachformat values of 1 or 2, only
generate Content-Disposition headers for MIME attachments, not
for the message contents themselves. Microsoft Outlook Build
10.0.6626, at least, doesn't show the message contents if they
have Content-Disposition.
Bill Wohler [Fri, 10 Mar 2006 09:00:20 +0000 (09:00 +0000)]
Changed Questions
1.03 Where can I get MH? nmh 1.2
Bill Wohler [Fri, 10 Mar 2006 06:58:28 +0000 (06:58 +0000)]
Since faqs.org appears to be moribund, I'm now using my site as the
official location of the MH FAQ. I added some missing quotes in
various places, so now Emacs highlighting works better.
New Questions
5.26 How do I fix a bogus In-Reply-To or missing References field?
Changed Questions
1.02 current version? nmh 1.2
1.04 references for MH? New FAQ official site. MH-E manual URL
5.15 make sense of replcomps? Use 1.1 version
Josh Bressers [Thu, 9 Mar 2006 19:51:13 +0000 (19:51 +0000)]
* sbr/fmt_rfc2047.c (decode_rfc2047): Don't close the iconv descriptor if
it isn't valid.
Josh Bressers [Wed, 8 Mar 2006 12:14:15 +0000 (12:14 +0000)]
* (mh_strcasecmp): Rename the private strcasecmp function to mh_strcasecmp.
Oliver Kiddle [Sun, 5 Mar 2006 14:48:05 +0000 (14:48 +0000)]
and close iconv handle if encoded block empty
Oliver Kiddle [Sun, 5 Mar 2006 14:38:23 +0000 (14:38 +0000)]
don't try to malloc 0 bytes if an RFC2047 encoded block is empty
Peter Maydell [Sat, 4 Mar 2006 22:14:18 +0000 (22:14 +0000)]
Install scripts with INSTALL_SCRIPT so INSTALL_PROGRAM can be set to
'install -s' without it causing the installation of the scripts to fail.
David Levine [Sat, 25 Feb 2006 14:14:06 +0000 (14:14 +0000)]
* uip/sendsbr.c: replaced st_mtim with st_mtime, that's what
it should have been. Added #include of h/tws.h to pick up
dtime() prototype.
David Levine [Tue, 21 Feb 2006 04:13:06 +0000 (04:13 +0000)]
Replaced second line of Content-Tyhpe of -attachformat 0 example.
David Levine [Tue, 21 Feb 2006 03:58:31 +0000 (03:58 +0000)]
* h/mh.h, h/prototypes.h, uip/mhbuildsbr.c, uip/send.c,
uip/sendsbr.c, uip/viamail.c, uip/whatnowsbr.c, man/send.man:
added -attachformat switch to send, to support alternate MIME
header contents when using -attach. See send man page for
description.
David Levine [Tue, 21 Feb 2006 03:51:53 +0000 (03:51 +0000)]
* man/mhbuild.man: wrapped one appearance of "Content-Disposition"
with quotes, to be consistent with others.
Josh Bressers [Tue, 21 Feb 2006 01:11:51 +0000 (01:11 +0000)]
* h/utils.h, sbr/utils.c, uip/flist.c, uip/folder.c: Move duplicate
function num_digits into utils.c
Josh Bressers [Tue, 21 Feb 2006 01:05:24 +0000 (01:05 +0000)]
Add missing create_folder prototype.
Josh Bressers [Mon, 20 Feb 2006 03:09:07 +0000 (03:09 +0000)]
* sbr/m_draft.c, sbr/utils.c, uip/folder.c, uip/inc.c, uip/mhstoresbr.c,
uip/popi.c, uip/refile.c: Add create_folder() function, replacing duplicate
code during folder creation.
David Levine [Sat, 18 Feb 2006 16:26:37 +0000 (16:26 +0000)]
Added support for optional Content_Disposition header in mhbuild directive.s
David Levine [Sun, 12 Feb 2006 18:06:44 +0000 (18:06 +0000)]
Added RFC2183 to reference of RFC1806 for Content-Disposition header.
David Levine [Tue, 31 Jan 2006 02:50:57 +0000 (02:50 +0000)]
Added -nocontentid (and -contentid, for symmetry) switch to mhbuild. This allows users to disable generation of the Content-ID: header in MIME messages, in order to placate broken version(s) of Outlook.
Oliver Kiddle [Sun, 29 Jan 2006 19:34:42 +0000 (19:34 +0000)]
remove trailing newlines from components to fix bug with spaces at the end of
Subject/References in replies
Oliver Kiddle [Wed, 18 Jan 2006 18:08:16 +0000 (18:08 +0000)]
use AS_HELP_STRING for formatting help messages
Oliver Kiddle [Wed, 18 Jan 2006 17:07:28 +0000 (17:07 +0000)]
add autoconf magic to support old systems that don't support multibyte charsets
Oliver Kiddle [Wed, 18 Jan 2006 16:43:27 +0000 (16:43 +0000)]
fix bug with insertion of newline being wrong if the num function was used at
the end of the format buffer
David Levine [Wed, 18 Jan 2006 00:09:00 +0000 (00:09 +0000)]
Fixed make_bcc_file () to use contents of From: in draft, if draft_from masquerade flag is enabled.
Oliver Kiddle [Tue, 17 Jan 2006 18:06:58 +0000 (18:06 +0000)]
more robust multi-byte/column support for field widths
restore right justification feature
Josh Bressers [Mon, 16 Jan 2006 17:07:14 +0000 (17:07 +0000)]
* uip/post.c, uip/spost.c: Move the uptolow macro from spost.c to post.c
where it is needed.