bug #15212: remove configure test for broken AT&T vi. This test was broken

and unfixable. Support for manually defining ATTVIBUG remains.

diff --git a/ChangeLog b/ChangeLog
index 9e33cb8..d630a7c 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,12 @@
+2007-03-12  Peter Maydell <pmaydell@chiark.greenend.org.uk>
+
+       * bug #15212: configure.in, acconfig.h: remove configure test for
+       broken AT&T vi. This test was broken (it was always returning
+       failure even for non-broken vi implementations) and
+       unfixable. Nobody should be using AT&T vi any more so I have
+       simply moved it back to being a setting you can put manually into
+       acconfig.h if you must.
+
 2006-10-24  David Levine <levinedl@acm.org>
 
        * uip/sendsbr.c: with attachformat values of 1 or 2, add

diff --git a/acconfig.h b/acconfig.h
index 551b253..ba744a4 100644 (file)
--- a/acconfig.h
+++ b/acconfig.h
@@ -148,6 +148,12 @@
 /* This tells nmh to use the Linux _IO_*_ptr defines from libio.h */ 
 #undef LINUX_STDIO
 
+/*
+ * Define to 1 if your vi has ATT bug, such that it returns
+ * non-zero exit codes on `pseudo-errors'.
+ */
+#undef ATTVIBUG
+
 
 /***** END USER CONFIGURATION SECTION *****/
 @TOP@
@@ -239,12 +245,6 @@
 #undef sigset_t
 
 /*
- * Define to 1 if your vi has ATT bug, such that it returns
- * non-zero exit codes on `pseudo-errors'.
- */
-#undef ATTVIBUG
-
-/*
  * Define to 1 if you need to make `inc' set-group-id because your mail spool is
  * not world writable.  There are no guarantees as to the safety of doing this,
  * but this #define will add some extra security checks.

diff --git a/configure.in b/configure.in
index b66a6e5..b64c489 100644 (file)
--- a/configure.in
+++ b/configure.in
@@ -367,20 +367,6 @@ if test -z "$editorpath"; then
 fi
 AC_SUBST(editorpath)dnl
 
-dnl Check for broken vi
-AC_CACHE_CHECK(for broken vi, nmh_cv_attvibug,
-[if echo 'r /nonexist-file
-q' | ex > /dev/null
-then
-        nmh_cv_attvibug=no
-else
-        nmh_cv_attvibug=yes
-fi])
- 
-if test "$nmh_cv_attvibug" = yes; then
-  AC_DEFINE(ATTVIBUG)dnl
-fi
-
 dnl ----------------------------------------------------------
 dnl FIND MAIL SPOOL AND SEE IF WE NEED TO MAKE inc SETGID MAIL
 dnl ----------------------------------------------------------