Got rid of four warnings in Shantonu's new getpass.c. Needed to #include

<stdlib.h> for calloc(), <unistd.h> for ttyname(), and "h/mh.h" for adios().
Also changed ch from char to int to get rid of "comparison is always 1 due to
limited range of data type" on EOF.

diff --git a/ChangeLog b/ChangeLog
index 401456f..3bb7d27 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,8 +1,13 @@
-Tue May 09 00:11:55 2000 Dan Harkless <dan-nmh@dilvish.speed.net>
+Tue May 09 00:50:39 2000 Dan Harkless <dan-nmh@dilvish.speed.net>
 
        * Alphabetized Shantonu's $pop_kinds output on configure's "pop is
        enabled" line.  If POP3 is the only kind of POP enabled, say so,
        rather than just saying "yes" (which is ambiguous).
+
+       * Got rid of four warnings in Shantonu's new getpass.c.  Needed to
+       #include <stdlib.h> for calloc(), <unistd.h> for ttyname(), and
+       "h/mh.h" for adios().  Also changed ch from char to int to get rid
+       of "comparison is always 1 due to limited range of data type" on EOF.
        
 Mon May 08 23:51:55 2000 Dan Harkless <dan-nmh@dilvish.speed.net>
 

diff --git a/sbr/getpass.c b/sbr/getpass.c
index cca32f6..a8238fb 100644 (file)
--- a/sbr/getpass.c
+++ b/sbr/getpass.c
@@ -34,7 +34,10 @@
  */
 
 #include <stdio.h>
+#include <stdlib.h>   /* for calloc() */
 #include <termios.h>
+#include <unistd.h>   /* for ttyname() */
+#include "h/mh.h"     /* for adios() */
 
 #define PASSWORD_LEN 128
 
@@ -43,10 +46,10 @@
 #endif
 
 char *
-getpass(char *prompt)
+getpass(const char *prompt)
 {
   struct termios oterm, term;
-  char ch;
+  int ch;
   char *p, *ttystring, *buf;
   FILE *fout, *fin;